public inbox for gcc-prs@sourceware.org help / color / mirror / Atom feed
From: brendan@zen.org To: gcc-gnats@gcc.gnu.org Subject: libstdc++/3016: stl_queue.h bugs wrt compliance Date: Thu, 31 May 2001 14:56:00 -0000 [thread overview] Message-ID: <20010531215054.25516.qmail@sourceware.cygnus.com> (raw) >Number: 3016 >Category: libstdc++ >Synopsis: stl_queue.h bugs wrt compliance >Confidential: no >Severity: serious >Priority: medium >Responsible: unassigned >State: open >Class: sw-bug >Submitter-Id: net >Arrival-Date: Thu May 31 14:56:00 PDT 2001 >Closed-Date: >Last-Modified: >Originator: brendan@zen.org >Release: egcs3 branch >Organization: >Environment: >Description: Attached are some tweaks to the definition of queue and priority_queue to make the more compliant with the standard. Specifically, the constructors in the current stl_queue.h are missing default arguments, and in some cases there are too many versions of the ctors. Hope this helps, B >How-To-Repeat: >Fix: >Release-Note: >Audit-Trail: >Unformatted: ----gnatsweb-attachment---- Content-Type: text/plain; name="diffs-queues.txt" Content-Disposition: inline; filename="diffs-queues.txt" 2001-05-31 Brendan Kehoe <brendan@zen.org> * include/bits/stl_queue.h (class priority_queue): Fix ctors to match the standard. *** stl_queue.h.~1~ Fri May 25 19:27:04 2001 --- stl_queue.h Thu May 31 21:28:27 2001 *************** protected: *** 76,81 **** _Sequence c; public: ! queue() : c() {} ! explicit queue(const _Sequence& __c) : c(__c) {} bool empty() const { return c.empty(); } --- 76,80 ---- _Sequence c; public: ! explicit queue(const _Sequence& __c = _Sequence()) : c(__c) {} bool empty() const { return c.empty(); } *************** protected: *** 155,177 **** _Compare comp; public: ! priority_queue() : c() {} ! explicit priority_queue(const _Compare& __x) : c(), comp(__x) {} ! priority_queue(const _Compare& __x, const _Sequence& __s) : c(__s), comp(__x) { make_heap(c.begin(), c.end(), comp); } template <class _InputIterator> - priority_queue(_InputIterator __first, _InputIterator __last) - : c(__first, __last) { make_heap(c.begin(), c.end(), comp); } - - template <class _InputIterator> - priority_queue(_InputIterator __first, - _InputIterator __last, const _Compare& __x) - : c(__first, __last), comp(__x) - { make_heap(c.begin(), c.end(), comp); } - - template <class _InputIterator> priority_queue(_InputIterator __first, _InputIterator __last, ! const _Compare& __x, const _Sequence& __s) : c(__s), comp(__x) { --- 154,166 ---- _Compare comp; public: ! explicit priority_queue(const _Compare& __x = _Compare(), ! const _Sequence& __s = _Sequence()) : c(__s), comp(__x) { make_heap(c.begin(), c.end(), comp); } template <class _InputIterator> priority_queue(_InputIterator __first, _InputIterator __last, ! const _Compare& __x = _Compare(), ! const _Sequence& __s = _Sequence()) : c(__s), comp(__x) {
next reply other threads:[~2001-05-31 14:56 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2001-05-31 14:56 brendan [this message] 2001-05-31 15:16 Brendan Kehoe 2001-05-31 15:16 Phil Edwards 2001-05-31 15:26 Phil Edwards 2001-06-05 7:36 Gabriel Dos Reis 2001-06-05 7:46 Gabriel Dos Reis 2001-06-05 7:46 Gabriel Dos Reis 2001-06-05 8:26 Phil Edwards
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20010531215054.25516.qmail@sourceware.cygnus.com \ --to=brendan@zen.org \ --cc=gcc-gnats@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).