From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phil Edwards To: gerald@gcc.gnu.org Cc: gcc-prs@gcc.gnu.org Subject: Re: web/3044: Gnatsweb no longer working without Javascript Date: Fri, 08 Jun 2001 14:06:00 -0000 Message-id: <20010608210601.25026.qmail@sourceware.cygnus.com> X-SW-Source: 2001-06/msg00317.html List-Id: The following reply was made to PR web/3044; it has been noted by GNATS. From: Phil Edwards To: Mark Mitchell Cc: gerald@gcc.gnu.org, gcc-gnats@gcc.gnu.org Subject: Re: web/3044: Gnatsweb no longer working without Javascript Date: Fri, 8 Jun 2001 15:39:08 -0400 On Fri, Jun 08, 2001 at 02:16:01AM -0000, Mark Mitchell wrote: > >>>>> "Phil" == Phil Edwards writes: > > Phil> Phil P.S.- Anybody else think that high-priority PRs should > Phil> be disallowed altogether during initial submission? That a > > Yes -- but I don't know how to do that. For the record only: complete guesswork, utterly untested (how could I test it?) patch against stock GNATS 1.113 sources follows. One of these years there'll be enough time to persue this option with the gnats developers... String comparison tests written in decreasing order of likelihood, the idea is to fail as quickly as possible. --- pr.c.orig Tue Mar 2 19:18:54 1999 +++ pr.c Wed Feb 28 16:37:48 2001 @@ -747,6 +747,16 @@ if (verify_enum (i, pr[i].value, token)) found = TRUE; + /* This hack prohibits random net submitters from submitting + a high-priority PR; the idea is that maintainers should be + the only ones permitted to raise priority to high. + This should be more configurable. */ + if (found == TRUE && (!strcmp(pr[i].name,PRIORITY_STRING)) + && (!strcmp(pr[i].value,"high")) + && (!strcmp(field_value(SUBMITTER), + pr[SUBMITTER].default_value))) + found = FALSE; + if (found == FALSE) { if (check)