public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
From: bkoz@gcc.gnu.org
To: bkoz@gcc.gnu.org, gcc-bugs@gcc.gnu.org, gcc-prs@gcc.gnu.org,
	kenny.simpson@gs.com, nobody@gcc.gnu.org,
	theonetruekenny@yahoo.com
Subject: Re: libstdc++/3141: DR 243: basic_istream::get and getline when sentry reports failure
Date: Tue, 12 Jun 2001 14:36:00 -0000	[thread overview]
Message-ID: <20010612213631.2423.qmail@sourceware.cygnus.com> (raw)

Synopsis: DR 243: basic_istream::get and getline when sentry reports failure

Responsible-Changed-From-To: unassigned->bkoz
Responsible-Changed-By: bkoz
Responsible-Changed-When: Tue Jun 12 14:36:31 2001
Responsible-Changed-Why:
    Mine.
State-Changed-From-To: open->feedback
State-Changed-By: bkoz
State-Changed-When: Tue Jun 12 14:36:31 2001
State-Changed-Why:
    I've made the char_type() changes.
    
    For the rest, I think your analysis is wrong. The point is that the terminating NULL *is* added unconditionally, and this is clarifying language to support this. Thus, the moving of the adding char_type() to terminate the string inside the if(sentry) loop would cause a defect, not fix one.
    
    There's a reason for the not checking n > 0 for the second bit, I can't remember it offhand but it has to do with changing required error flags. It's checked for in the testsuite, so changing this one small bit will probably show the failure. Anyway.
    
    -benjamin

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view&pr=3141&database=gcc


             reply	other threads:[~2001-06-12 14:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-12 14:36 bkoz [this message]
  -- strict thread matches above, loose matches on Subject: below --
2001-11-16  9:16 Benjamin Kosnik
2001-11-15 13:52 rodrigc
2001-11-15 13:33 rodrigc
2001-06-12 10:26 theonetruekenny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010612213631.2423.qmail@sourceware.cygnus.com \
    --to=bkoz@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    --cc=gcc-prs@gcc.gnu.org \
    --cc=kenny.simpson@gs.com \
    --cc=nobody@gcc.gnu.org \
    --cc=theonetruekenny@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).