libstdc++/4071: "make install" installs .../include/g++-v3/Makefile

[Phil Richards <pgr@derived-software.demon.co.uk>]

>Number:         4071
>Category:       libstdc++
>Synopsis:       "make install" installs .../include/g++-v3/Makefile
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Aug 21 10:16:01 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Phil Richards
>Release:        3.0.1
>Organization:
Derived Software Limited
>Environment:
System: Linux derisoft.derived-software.demon.co.uk 2.4.5-5mdk #1 Sat Jun 16 08:08:07 EDT 2001 i686 unknown
Architecture: i686

host: i686-pc-linux-gnu
build: i686-pc-linux-gnu
target: i686-pc-linux-gnu
configured with: ../gcc-3.0.1/configure --prefix=/usr/local --enable-threads
>Description:

[I couldn't work out which category/class problems like this should go
under ... there doesn't appear to be an "install" class.]

Did "make bootstrap" as "normal user", and "make install" as root.
I keep a list of all files installed (for later clean-up), and when
cross-checking what needed keeping between gcc 3.0 and gcc 3.0.1
noticed that
    /usr/local/include/g++-v3/Makefile
existed in 3.0.1 and not 3.0.

A quick check showed that this was a copy of
    <builddir>/i686-pc-linux-gnu/libstdc++-v3/include/Makefile

The install-data-local: rule from that Makefile installs all
files in the directory (except stamp-*) into .../include/g++-v3;
this, of course, includes "Makefile".

>How-To-Repeat:

make bootstrap
make install

(not double checked, but that's what I did to cause it!)

>Fix:
gcc-3.0.1/libstdc++-v3/include/Makefile.am:420 needs to exclude Makefile.

Quick (tested on GNU find) hack:

diff -Nc3pad gcc-3.0.1/libstdc++-v3/include/Makefile.am gcc-3.0.1-pgr/libstdc++-v3/include/Makefile.am
*** gcc-3.0.1/libstdc++-v3/include/Makefile.am	Fri Aug 17 22:03:40 2001
--- gcc-3.0.1-pgr/libstdc++-v3/include/Makefile.am	Tue Aug 21 11:50:41 2001*************** ${thread_builddir}/gthr-default.h:
*** 417,423 ****
  gxx_include_dir = @gxx_include_dir@
  
  install-data-local:
! 	for file in `find . ! -name stamp-\* -print`; do \
  	installFile=${gxx_include_dir}/$${file} ;\
  	if [ -d $${file} ]; then \
  	  $(INSTALL) -d $${installFile} ;\
--- 417,423 ----
  gxx_include_dir = @gxx_include_dir@
  
  install-data-local:
! 	for file in `find . ! -name stamp-\* ! -name Makefile -print`; do \
  	installFile=${gxx_include_dir}/$${file} ;\
  	if [ -d $${file} ]; then \
  	  $(INSTALL) -d $${installFile} ;\
>Release-Note:
>Audit-Trail:
>Unformatted: