Re: java/2312: Check for initialization of all final fields erronously fails

Re: java/2312: Check for initialization of all final fields erronously fails

[tromey]

Synopsis: Check for initialization of all final fields erronously fails

Responsible-Changed-From-To: unassigned->tromey
Responsible-Changed-By: tromey
Responsible-Changed-When: Mon Dec 10 10:25:39 2001
Responsible-Changed-Why:
    I'm handling the PR.
State-Changed-From-To: open->closed
State-Changed-By: tromey
State-Changed-When: Mon Dec 10 10:25:39 2001
State-Changed-Why:
    I think Per's recent check-init changes fixed this.
    The example in the PR now works for me.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=2312&database=gcc

Re: java/2312: Check for initialization of all final fields erronously fails

[tromey]

The following reply was made to PR java/2312; it has been noted by GNATS.

From: tromey@gcc.gnu.org
To: bryce@albatross.co.nz, gcc-bugs@gcc.gnu.org, gcc-gnats@gcc.gnu.org,
  gcc-prs@gcc.gnu.org, java-prs@gcc.gnu.org, nobody@gcc.gnu.org,
  tromey@gcc.gnu.org
Cc:  
Subject: Re: java/2312: Check for initialization of all final fields erronously fails
Date: 10 Dec 2001 18:25:39 -0000

 Synopsis: Check for initialization of all final fields erronously fails
 
 Responsible-Changed-From-To: unassigned->tromey
 Responsible-Changed-By: tromey
 Responsible-Changed-When: Mon Dec 10 10:25:39 2001
 Responsible-Changed-Why:
     I'm handling the PR.
 State-Changed-From-To: open->closed
 State-Changed-By: tromey
 State-Changed-When: Mon Dec 10 10:25:39 2001
 State-Changed-Why:
     I think Per's recent check-init changes fixed this.
     The example in the PR now works for me.
 
 http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&pr=2312&database=gcc

java/2312: Check for initialization of all final fields erronously fails

[bryce]

>Number:         2312
>Category:       java
>Synopsis:       Check for initialization of all final fields erronously fails
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Mar 17 20:56:01 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     Bryce McKinlay
>Release:        gcc version 3.0 20010317 (prerelease)
>Organization:
>Environment:

>Description:
Compilation of the test case below fails because GCJ 
falsely determines that all the classes final fields may
not have been initialized:

$ gcj -c Final.java 
Final.java:11: Final variable initialization error in this constructor.
     {
      ^
1 error

The problem appears to be with the method
check_final_variable_indirect_assignment.

The workaround below permits correct compilation, but 
disables the final variable checking completely.

Index: parse.y
===================================================================
RCS file: /cvs/gcc/gcc/gcc/java/parse.y,v
retrieving revision 1.251.2.7
diff -u -r1.251.2.7 parse.y
--- parse.y     2001/03/17 21:53:11     1.251.2.7
+++ parse.y     2001/03/18 04:50:46
@@ -12271,6 +12271,10 @@
            if (fbody == error_mark_node)
              continue;
            fbody = BLOCK_EXPR_BODY (fbody);
+
+           DECL_FUNCTION_ALL_FINAL_INITIALIZED (mdecl) = 1;
+
+           /*
            if (check_final_variable_indirect_assignment (fbody) == 1)
              {
                DECL_FUNCTION_ALL_FINAL_INITIALIZED (mdecl) = 1;
@@ -12280,6 +12284,7 @@
              parse_error_context
                (lookup_cl (mdecl),
                 "Final variable initialization error in this constructor");
+           */
          }
        else
          nnctor++;

>How-To-Repeat:
class Final
{
  private final Integer foo;
  
  Final (Integer f)
  {
    foo = f;
  }
  
  Final ()
  {
    this (new Integer(9));
  }
}
>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted: