Re: preprocessor/5234: Variable arguments list in macro fail with another macro inclusion

[Andrew Pinski <pinskia@physics.uc.edu>]

The following reply was made to PR preprocessor/5234; it has been noted by GNATS.

From: Andrew Pinski <pinskia@physics.uc.edu>
To: david.taillandier@domainename.com
Cc: gcc-gnats@gcc.gnu.org
Subject: Re: preprocessor/5234: Variable arguments list in macro fail with another macro inclusion
Date: Tue, 1 Jan 2002 13:51:03 -0500

 This has been fixed in gcc 3.0.3 and gcc 3.1
 Thanks,
 Andrew Pinski
 
 PS here is what I get when I run the preprocessor on the source (with 
 the include removed):
 
 # 1 "myc.c"
 # 1 "<built-in>"
 # 1 "<command line>"
 # 1 "myc.c"
 # 9 "myc.c"
 int
 main( void )
 {
         printf( "123" "ending string\n" );
      printf( "456" "ending string\n" );
             printf( "789" );
 
      return 0;
 }
 
 
 On Tuesday, January 1, 2002, at 01:36 , 
 david.taillandier@domainename.com wrote:
 
 >
 >> Number:         5234
 >> Category:       preprocessor
 >> Synopsis:       Variable arguments list in macro fail with another 
 >> macro inclusion
 >> Confidential:   no
 >> Severity:       non-critical
 >> Priority:       medium
 >> Responsible:    unassigned
 >> State:          open
 >> Class:          rejects-legal
 >> Submitter-Id:   net
 >> Arrival-Date:   Tue Jan 01 10:46:01 PST 2002
 >> Closed-Date:
 >> Last-Modified:
 >> Originator:     David TAILLANDIER
 >> Release:        gcc version 2.95.3 20010315/djgpp (release)
 >> Organization:
 >> Environment:
 > Win95 / MS-DOS 6 / Win98
 >> Description:
 > In one case, clearly identified, when using variable
 > arguments list macro with another macro inside the first
 > one, the preprocessing process (duh) gives an error.
 > See sample, it's very simple.
 >
 > Hope I don't miss something.
 > david.taillandier@domainename.com
 >> How-To-Repeat:
 >
 > #include <stdio.h>
 >
 > #define _(text_to_translate)    text_to_translate
 >
 > #define    PROBLEM_HERE( text, vargs... )         printf( text 
 > _("ending string\n"),  ## vargs )
 > #define NO_PROBLEM_HERE( text, vargs... )         printf( text 
 > _("ending string\n") , ## vargs )
 > #define        NOR_HERE( text, vargs... )         printf( text, ## 
 > vargs )
 >
 > /* the only difference is the space before the comma witch is not 
 > present in PROBLEM_HERE */
 >
 > int
 > main( void )
 > {
 >        PROBLEM_HERE( "123" );
 >     NO_PROBLEM_HERE( "456" );
 >            NOR_HERE( "789" );
 >
 >     return 0;
 > }
 >> Fix:
 > I don't know how to fix this, sorry.
 > But a workaround is to add a space before the comma
 > preceding the ##
 >> Release-Note:
 >> Audit-Trail:
 >> Unformatted:
 >
 >