Re: libgcj/5670: verify.cc not properly merging states

[Todd Stock <toddastock@yahoo.com>]

The following reply was made to PR libgcj/5670; it has been noted by GNATS.

From: Todd Stock <toddastock@yahoo.com>
To: tromey@gcc.gnu.org
Cc: gcc-gnats@gcc.gnu.org
Subject: Re: libgcj/5670: verify.cc not properly merging states
Date: Thu, 14 Feb 2002 10:38:10 -0800

 As an extension to this I have another one.  Is the bug the same one you 
 mention as finding and needing fixing?
 
 I don't think this is the correct patch for the problem.  I am trying to 
 reproduce a third problem that also appears to show the same incomplete 
 type problem.
 
 -Todd
 
 The patch to fix this:
 
  +	else if (source->isInterface ())
  +	  {
  +	    for (int i = 0; i < target->interface_count; ++i)
  +	      {
  +		// We use a recursive call because we also need to
  +		// check superinterfaces.
  +		if (is_assignable_from_slow (target->interfaces[i], source))
  +		    return true;
  +	      }
  +	    target = target->getSuperclass ();
  +	    if (target == NULL)
  +	      return true;
 *^^^^^^^^^^^^^^^^^^^^^^^^^ return true instead of false.
  +	  }
 
 
 The code that produces the bug:
 
 import java.io.*;
 import java.util.*;
 
 public class Test2
   {
   Vector v = new Vector( );
   public void addBuildListener( TestListener l )
     {
       v.addElement( l );
     }
   }
 import java.io.*;
 import java.util.*;
 
 public class Test
   {
   Object x = null;
   int y = 0;
 
   public static void main (String[] args)
     {
 
       Test t = new Test( );
       try
         {
           t.doit( );
         }
       catch( Exception e )
         {
         }
     }
 
   private void doit( ) throws Exception
     {
       final Test2 t = new Test2();
       addListener(t);
     }
 
   protected void addListener( Test2 t )
     {
       t.addBuildListener(doitSub());
     }
 
   private TestLogger testE () throws IOException
     {
       return new TestLoggerDefault();
     }
 
   private TestLogger doitSub ()
     {
       TestLogger logger = null;
       if( x != null )
         {
           try
           {
             logger = testE();
           }
           catch( IOException e )
           {
             throw new RuntimeException( );
           }
           catch( Exception e )
           {
             throw new RuntimeException( );
           }
         }
       else
         {
           logger = new TestLoggerDefault( );
         }
   
       logger.print(y);
       return logger;
     }
   }
 public interface TestListener
   {
   }
 public class TestLoggerDefault implements TestLogger
   {
 
   public void print ( int y )
     {
     }
 
   }
 public interface TestLogger extends TestListener
   {
   void print ( int y );
   }
 
 
 
 
 _________________________________________________________
 Do You Yahoo!?
 Get your free @yahoo.com address at http://mail.yahoo.com