public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
From: Alan Matsuoka <alanm@redhat.com>
To: nobody@gcc.gnu.org
Cc: gcc-prs@gcc.gnu.org,
Subject: Re: target/5736: bootstraping CVS HEAD on powerpc fails in checked build
Date: Wed, 20 Feb 2002 10:06:00 -0000 [thread overview]
Message-ID: <20020220175604.23212.qmail@sources.redhat.com> (raw)
The following reply was made to PR target/5736; it has been noted by GNATS.
From: Alan Matsuoka <alanm@redhat.com>
To: pthomas@suse.de
Cc: gcc-prs@gcc.gnu.org, gcc-gnats@gcc.gnu.org, aj@suse.de, dje@watson.ibm.com
Subject: Re: target/5736: bootstraping CVS HEAD on powerpc fails in checked build
Date: Wed, 20 Feb 2002 12:46:12 -0500
## > >
## >
## > You might want to try this patch it's completly untested. I don't have enough time or resources to test it.
I sent that one in to gcc-patches last night.
I've bootstrapped in on ppc linux without any regressions.
I caught this one when working on the AltiVec stuff with
checking turned on.
Pre-Approved by Geoff Keating.
alanm@redhat.com (Alan Matsuoka) writes:
# > Hey guy,
# >
# >
# > I was running a build with all the checking flags turned on
# > while looking for a problem with my stuff when I ran into an
# > abort inside LEGITIMATE_OFFSET_ADDRESS_P
# >
# > *************** typedef struct rs6000_args
# > *** 1969,1973 ****
# > && INT_REG_OK_FOR_BASE_P (XEXP (X, 0), (STRICT)) \
# > && LEGITIMATE_ADDRESS_INTEGER_P (XEXP (X, 1), 0) \
# > ! && (! ALTIVEC_VECTOR_MODE (MODE) || INTVAL (X) == 0) \
# > && (((MODE) != DFmode && (MODE) != DImode) \
# > || (TARGET_32BIT \
# > --- 2116,2121 ----
# > && INT_REG_OK_FOR_BASE_P (XEXP (X, 0), (STRICT)) \
# > && LEGITIMATE_ADDRESS_INTEGER_P (XEXP (X, 1), 0) \
# > ! && (! ALTIVEC_VECTOR_MODE (mode) \
# > ! || (GET_CODE (XEXP (X,1)) == CONST_INT && INTVAL (XEXP (X,1)) == 0)) \
# > && (((MODE) != DFmode && (MODE) != DImode) \
# > || (TARGET_32BIT \
# >
# >
# > rtl checking aborts in the INTVAL (X) because it was looking at a const_int
# > I think that this is what fixes it.
#
# Good catch!
#
# Please send this to the FSF list, with a ChangeLog entry, and you can
# say I approved it in advance.
#
# --
# - Geoffrey Keating <geoffk@geoffk.org> <geoffk@redhat.com>
Bootstrapped on ppc linux without any regressions.
Wed Feb 20 00:03:25 EST 2002 Alan Matsuoka <alanm@redhat.com>
* config/rs6000/rs6000.h (LEGITIMATE_OFFSET_ADDRESS_P): Look
for (const_int 0) in X not just INTVAL.
Index: rs6000.h
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/rs6000/rs6000.h,v
retrieving revision 1.181
diff -d -c -p -r1.181 rs6000.h
*** rs6000.h 2002/02/19 02:53:36 1.181
--- rs6000.h 2002/02/20 04:52:08
*************** typedef struct rs6000_args
*** 1971,1977 ****
&& GET_CODE (XEXP (X, 0)) == REG \
&& INT_REG_OK_FOR_BASE_P (XEXP (X, 0), (STRICT)) \
&& LEGITIMATE_ADDRESS_INTEGER_P (XEXP (X, 1), 0) \
! && (! ALTIVEC_VECTOR_MODE (MODE) || INTVAL (X) == 0) \
&& (((MODE) != DFmode && (MODE) != DImode) \
|| (TARGET_32BIT \
? LEGITIMATE_ADDRESS_INTEGER_P (XEXP (X, 1), 4) \
--- 1971,1978 ----
&& GET_CODE (XEXP (X, 0)) == REG \
&& INT_REG_OK_FOR_BASE_P (XEXP (X, 0), (STRICT)) \
&& LEGITIMATE_ADDRESS_INTEGER_P (XEXP (X, 1), 0) \
! && (! ALTIVEC_VECTOR_MODE (mode) \
! || (GET_CODE (XEXP (X,1)) == CONST_INT && INTVAL (XEXP (X,1)) == 0)) \
&& (((MODE) != DFmode && (MODE) != DImode) \
|| (TARGET_32BIT \
? LEGITIMATE_ADDRESS_INTEGER_P (XEXP (X, 1), 4) \
## Graham.
##
## ChangeLog
##
## * config/rs6000/rs6000.h (LEGITIMATE_OFFSET_ADDRESS_P): Fix typo.
##
## ------------------------------------------------------------------------
## Index: gcc/config/rs6000/rs6000.h
## ===================================================================
## RCS file: /cvs/gcc/gcc/gcc/config/rs6000/rs6000.h,v
## retrieving revision 1.182
## diff -c -p -r1.182 rs6000.h
## *** rs6000.h 2002/02/20 04:56:34 1.182
## --- rs6000.h 2002/02/20 17:24:00
## *************** typedef struct rs6000_args
## *** 1974,1980 ****
## && GET_CODE (XEXP (X, 0)) == REG \
## && INT_REG_OK_FOR_BASE_P (XEXP (X, 0), (STRICT)) \
## && LEGITIMATE_ADDRESS_INTEGER_P (XEXP (X, 1), 0) \
## ! && (! ALTIVEC_VECTOR_MODE (MODE) || INTVAL (X) == 0) \
## && (((MODE) != DFmode && (MODE) != DImode) \
## || (TARGET_32BIT \
## ? LEGITIMATE_ADDRESS_INTEGER_P (XEXP (X, 1), 4) \
## --- 1974,1981 ----
## && GET_CODE (XEXP (X, 0)) == REG \
## && INT_REG_OK_FOR_BASE_P (XEXP (X, 0), (STRICT)) \
## && LEGITIMATE_ADDRESS_INTEGER_P (XEXP (X, 1), 0) \
## ! && (! ALTIVEC_VECTOR_MODE (MODE) \
## ! || INTVAL (XEXP (X, 1)) == 0) \
## && (((MODE) != DFmode && (MODE) != DImode) \
## || (TARGET_32BIT \
## ? LEGITIMATE_ADDRESS_INTEGER_P (XEXP (X, 1), 4) \
## ------------------------------------------------------------------------
Alan Matsuoka
GCC Engineering
Red Hat Canada, Ltd
mailto:alanm@redhat.com Tel: (416) 482-2661 x250 / Fax: (416) 482-6299
next reply other threads:[~2002-02-20 17:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-20 10:06 Alan Matsuoka [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-03-13 14:13 dje
2002-02-20 13:40 Graham Stott
2002-02-20 10:26 Alan Matsuoka
2002-02-20 10:06 David Edelsohn
2002-02-20 10:06 David Edelsohn
2002-02-20 10:06 Franz Sirl
2002-02-20 9:56 David Edelsohn
2002-02-20 9:56 Graham Stott
2002-02-20 9:26 pthomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020220175604.23212.qmail@sources.redhat.com \
--to=alanm@redhat.com \
--cc=gcc-prs@gcc.gnu.org \
--cc=nobody@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).