public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
From: mark@klomp.org
To: gcc-gnats@gcc.gnu.org
Subject: java/6391: Constant float to int conversions don't use ieee_real_to_integer when compiled to byte-code
Date: Sun, 21 Apr 2002 02:46:00 -0000	[thread overview]
Message-ID: <20020421094355.19915.qmail@sources.redhat.com> (raw)


>Number:         6391
>Category:       java
>Synopsis:       Constant float to int conversions don't use ieee_real_to_integer when compiled to byte-code
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 21 02:46:01 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     mark@klomp.org
>Release:        gcj 3.1
>Organization:
>Environment:

>Description:
See also the following thread:
http://gcc.gnu.org/ml/java/2002-04/msg00255.html

The following program:

public class DFT
{
        public static void main(String[] args)
        {
                System.out.println((int) 3.4e+32);
                System.out.println((long) 3.4e+32);

                System.out.println((int) 3.4e+32f);
                System.out.println((long) 3.4e+32f);
        }
}

Should produce the following output (which is does when compiling to native code):

2147483647
9223372036854775807
2147483647
9223372036854775807

But when compiling to byte-code it gives:

0
-4294967296
0
-4294967296

The problem seemed to be solved by the following patch  which makes sure that even when we emit a class file the special convert_ieee_real_to_integer is used and not just convert_to_integer.

diff -u -r1.44 typeck.c
--- typeck.c    3 Dec 2001 23:09:42 -0000       1.44
+++ typeck.c    19 Apr 2002 22:17:05 -0000
@@ -134,7 +134,6 @@
   if (code == INTEGER_TYPE)
     {
       if (! flag_unsafe_math_optimizations
-         && ! flag_emit_class_files
          && TREE_CODE (TREE_TYPE (expr)) == REAL_TYPE
          && TARGET_FLOAT_FORMAT == IEEE_FLOAT_FORMAT)
        return fold (convert_ieee_real_to_integer (type, expr));

Sadly this is not the solution since with this patch I get one regression: FAIL: Primes -O output from bytecode->native test

And although the above test program and the Mauve FloatTest produce correct results the Mauve DoubleTest now gives:

gnu/testlet/java/lang/Double/DoubleTest.java: In class
`gnu.testlet.java.lang.Double.DoubleTest':
gnu/testlet/java/lang/Double/DoubleTest.java: In method
`gnu.testlet.java.lang.Double.DoubleTest.test_longValue()':
gnu/testlet/java/lang/Double/DoubleTest.java:310: verification error at
PC=32
gnu/testlet/java/lang/Double/DoubleTest.java:310: invalid argument type
gnu/testlet/java/lang/Double/DoubleTest.java:310: expected type
'boolean' but stack contains 'void'
>How-To-Repeat:

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted:


             reply	other threads:[~2002-04-21  9:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-21  2:46 mark [this message]
2002-05-11 17:44 tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020421094355.19915.qmail@sources.redhat.com \
    --to=mark@klomp.org \
    --cc=gcc-gnats@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).