From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-prs-return-18632-listarch-gcc-prs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 12924 invoked by alias); 15 May 2002 12:57:34 -0000
Mailing-List: contact gcc-prs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Archive: <http://gcc.gnu.org/ml/gcc-prs/>
List-Post: <mailto:gcc-prs@gcc.gnu.org>
List-Help: <mailto:gcc-prs-help@gcc.gnu.org>
Sender: gcc-prs-owner@gcc.gnu.org
Received: (qmail 12863 invoked by uid 61); 15 May 2002 12:57:31 -0000
Date: Wed, 15 May 2002 05:57:00 -0000
Message-ID: <20020515125731.12862.qmail@sources.redhat.com>
To: bkoz@gcc.gnu.org, edh@twcny.rr.com, gcc-bugs@gcc.gnu.org,
  gcc-prs@gcc.gnu.org, nobody@gcc.gnu.org
From: bkoz@gcc.gnu.org
Reply-To: bkoz@gcc.gnu.org, bkoz@gcc.gnu.org, edh@twcny.rr.com,
  gcc-bugs@gcc.gnu.org, gcc-prs@gcc.gnu.org, nobody@gcc.gnu.org,
  gcc-gnats@gcc.gnu.org
Subject: Re: libstdc++/6594: strstreambuf leaks 16 bytes - gcc 3.0.x
X-SW-Source: 2002-05/txt/msg00415.txt.bz2
List-Id: <gcc-prs.sourceware.org>

Synopsis: strstreambuf leaks 16 bytes - gcc 3.0.x

Responsible-Changed-From-To: unassigned->bkoz
Responsible-Changed-By: bkoz
Responsible-Changed-When: Wed May 15 05:57:30 2002
Responsible-Changed-Why:
    Mine.
State-Changed-From-To: open->feedback
State-Changed-By: bkoz
State-Changed-When: Wed May 15 05:57:30 2002
State-Changed-Why:
    So it does....
    
    strstream.cc: 69 has
    
    strstreambuf::strstreambuf(streamsize initial_capacity)
      : _Base(),
        _M_alloc_fun(0), _M_free_fun(0),
        _M_dynamic(true), _M_frozen(false), _M_constant(false)
    {
      streamsize n = max(initial_capacity, streamsize(16));
    
      char* buf = _M_alloc(n);
      if (buf) {
        setp(buf, buf + n);
        setg(buf, buf, buf);
      }
    
    Wow. 
    
    Are you aware that this class has been deprecated by std::stringstream? You might consider using it instead.
    
    However, it turns out that the bug is pretty easy to fix. You might try this, and let me know how it goes. 
    
    2002-05-15  Benjamin Kosnik  <bkoz@redhat.com>
    
    	PR libstdc++/6594
    	* src/strstream.cc (strstreambuf): Fix leak.
    
    The patch is here:
    http://gcc.gnu.org/ml/gcc-patches/2002-05/msg01204.html
    
    best,
    benjamin

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=6594