From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13656 invoked by alias); 17 Jul 2002 19:06:01 -0000 Mailing-List: contact gcc-prs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-prs-owner@gcc.gnu.org Received: (qmail 13626 invoked by uid 71); 17 Jul 2002 19:06:01 -0000 Date: Wed, 17 Jul 2002 12:06:00 -0000 Message-ID: <20020717190601.13625.qmail@sources.redhat.com> To: amodra@gcc.gnu.org Cc: gcc-prs@gcc.gnu.org, From: Geoff Keating Subject: Re: other/7114: ICE building strcoll.op from glibc-2.2.5 Reply-To: Geoff Keating X-SW-Source: 2002-07/txt/msg00535.txt.bz2 List-Id: The following reply was made to PR other/7114; it has been noted by GNATS. From: Geoff Keating To: amodra@bigpond.net.au Cc: d.mueller@elsoft.ch, gcc-gnats@gcc.gnu.org, gcc-patches@gcc.gnu.org, dje@watson.ibm.com Subject: Re: other/7114: ICE building strcoll.op from glibc-2.2.5 Date: Wed, 17 Jul 2002 12:03:14 -0700 > Date: Wed, 17 Jul 2002 18:30:49 +0930 > From: Alan Modra > Cc: d.mueller@elsoft.ch, gcc-gnats@gcc.gnu.org, gcc-patches@gcc.gnu.org, > dje@watson.ibm.com > On Wed, Jul 17, 2002 at 12:07:11AM -0700, Geoff Keating wrote: > > So, why don't we go back to the push/pop implementation, but this time > > do it properly? We'd only need to push/pop in the (rare) > > nested-function case. > > I wasn't aware that powerpc used that scheme previously, and therefore > was worried that some mcount implementation might peek at the stack. > > Here we go. > > * config/rs6000/r6000.c (first_reg_to_save): Remove bogus > adjustments to first_reg for profiling case. > (output_function_profiler): Correct lr save slot for ABI_AIX_NODESC. > Disable profiling for 64 bit code on both ABI_V4 and ABI_AIX_NODESC. > Save static chain reg to sp + 12 on ABI_AIX_NODESC. > * config/rs6000/sysv4.h (ASM_OUTPUT_REG_PUSH): Define. > (ASM_OUTPUT_REG_POP): Define. > * config/rs6000/linux64.h (ASM_OUTPUT_REG_PUSH): Undef. > (ASM_OUTPUT_REG_POP): Undef. This is OK. I'm pretty sure it's right, and completely sure it's no worse than before. :-) -- - Geoffrey Keating