From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-prs-return-20787-listarch-gcc-prs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 14106 invoked by alias); 30 Jul 2002 18:46:02 -0000
Mailing-List: contact gcc-prs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Archive: <http://gcc.gnu.org/ml/gcc-prs/>
List-Post: <mailto:gcc-prs@gcc.gnu.org>
List-Help: <mailto:gcc-prs-help@gcc.gnu.org>
Sender: gcc-prs-owner@gcc.gnu.org
Received: (qmail 14082 invoked by uid 71); 30 Jul 2002 18:46:01 -0000
Resent-Date: 30 Jul 2002 18:46:01 -0000
Resent-Message-ID: <20020730184601.14081.qmail@sources.redhat.com>
Resent-From: gcc-gnats@gcc.gnu.org (GNATS Filer)
Resent-To: nobody@gcc.gnu.org
Resent-Cc: gcc-prs@gcc.gnu.org, gcc-bugs@gcc.gnu.org
Resent-Reply-To: gcc-gnats@gcc.gnu.org, shurik@sequoiap.com
Received: (qmail 12181 invoked by uid 61); 30 Jul 2002 18:37:05 -0000
Message-Id: <20020730183705.12180.qmail@sources.redhat.com>
Date: Tue, 30 Jul 2002 11:46:00 -0000
From: shurik@sequoiap.com
Reply-To: shurik@sequoiap.com
To: gcc-gnats@gcc.gnu.org
X-Send-Pr-Version: gnatsweb-2.9.3 (1.1.1.1.2.31)
Subject: libstdc++/7445: poor performance of std::locale::classic() in multi-threaded applications
X-SW-Source: 2002-07/txt/msg00789.txt.bz2
List-Id: <gcc-prs.sourceware.org>


>Number:         7445
>Category:       libstdc++
>Synopsis:       poor performance of std::locale::classic() in multi-threaded applications
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jul 30 11:46:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Alex Kompel
>Release:        gcc version 3.1.1
>Organization:
>Environment:
RedHat Linux 7.3
>Description:
poor performance of std::locale::classic() in multi-threaded applications. std::locale:classic() is using _STL_auto_lock too extensively. It should only be used when the locale object is initialized. It does locks the mutex
on every call at present. See the fix below.
>How-To-Repeat:

>Fix:
*** libstdc++-v3/src/locale.old Tue Jul 30 11:31:01 2002
--- libstdc++-v3/src/locale.cc  Tue Jul 30 11:31:13 2002
***************
*** 285,294 ****
    locale::classic()
    {
      static _STL_mutex_lock __lock __STL_MUTEX_INITIALIZER;
-     _STL_auto_lock __auto(__lock);

      if (!_S_classic)
        {
        try
          {
            // 26 Standard facets, 2 references.
--- 285,294 ----
    locale::classic()
    {
      static _STL_mutex_lock __lock __STL_MUTEX_INITIALIZER;

      if (!_S_classic)
        {
+         _STL_auto_lock __auto(__lock);
        try
          {
            // 26 Standard facets, 2 references.
>Release-Note:
>Audit-Trail:
>Unformatted: