public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
From: Graham Stott <graham.stott@btinternet.com>
To: nobody@gcc.gnu.org
Cc: gcc-prs@gcc.gnu.org,
Subject: Re: optimization/7460: gcc/g++ 3.1.1 20020714/20020718 (cygwin) segfault on __builtin_ia32_femms()
Date: Wed, 31 Jul 2002 16:56:00 -0000 [thread overview]
Message-ID: <20020731235601.19953.qmail@sources.redhat.com> (raw)
The following reply was made to PR optimization/7460; it has been noted by GNATS.
From: Graham Stott <graham.stott@btinternet.com>
To: gcc@tbp.dyndns.org
Cc: gcc-gnats@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: optimization/7460: gcc/g++ 3.1.1 20020714/20020718 (cygwin) segfault
on __builtin_ia32_femms()
Date: Thu, 01 Aug 2002 00:53:36 +0100
All,
Confirmed also present CVS mainline and not cygwin specific.
The problem here is the define_attr "memory" in i386.md assumes that an insn always has two operands
which is not the case for femms so when get_attr_memory tries to determine the "memory" attribute
for the femms insn it tries to access operand 2 which doesn't exist.
The patch fixes this problem for femms by explicitly specifying the "memory" attrib on the insn itself
so that get_attr_memory nevers gets called for this insn.
This doesn't fix the generic problem with the define_attr "memory" definition which is assuming an insn
always has two operands.
bootstrapped i686-pc-linux-gnu all languages no regressions.
OK for mainline and 3.2?
Graham
ChangeLog
2002-07-31 Graham Stott <graham.stott@btinternet.com>
* config/i386/i386.md ("femms"): Add "memory" attr "none".
-------------------------------------------------------------
Index: i386.md
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/i386/i386.md,v
retrieving revision 1.378
diff -c -p -r1.378 i386.md
*** i386.md 16 Jul 2002 10:24:11 -0000 1.378
--- i386.md 31 Jul 2002 23:35:13 -0000
*** 19819,19825 ****
(clobber (reg:DI 36))]
"TARGET_3DNOW"
"femms"
! [(set_attr "type" "mmx")])
(define_insn "pf2id"
[(set (match_operand:V2SI 0 "register_operand" "=y")
--- 19819,19826 ----
(clobber (reg:DI 36))]
"TARGET_3DNOW"
"femms"
! [(set_attr "type" "mmx")
! (set_attr "memory" "none")])
(define_insn "pf2id"
[(set (match_operand:V2SI 0 "register_operand" "=y")
-----------------------------------------------------------
next reply other threads:[~2002-07-31 23:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-31 16:56 Graham Stott [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-12-06 13:38 bangerth
2002-08-01 16:46 Richard Henderson
2002-07-31 15:26 gcc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020731235601.19953.qmail@sources.redhat.com \
--to=graham.stott@btinternet.com \
--cc=gcc-prs@gcc.gnu.org \
--cc=nobody@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).