public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
From: bkoz@gcc.gnu.org
To: bkoz@gcc.gnu.org, gcc-bugs@gcc.gnu.org, gcc-prs@gcc.gnu.org,
john_maddock@compuserve.com, nobody@gcc.gnu.org
Subject: Re: libstdc++/8463: std::ios_base has a non-virtual destructor
Date: Tue, 05 Nov 2002 08:29:00 -0000 [thread overview]
Message-ID: <20021105162947.19664.qmail@sources.redhat.com> (raw)
Synopsis: std::ios_base has a non-virtual destructor
Responsible-Changed-From-To: unassigned->bkoz
Responsible-Changed-By: bkoz
Responsible-Changed-When: Tue Nov 5 08:29:46 2002
Responsible-Changed-Why:
Mine.
State-Changed-From-To: open->feedback
State-Changed-By: bkoz
State-Changed-When: Tue Nov 5 08:29:46 2002
State-Changed-Why:
You are correct.
2002-11-05 Benjamin Kosnik <bkoz@redhat.com> PR libstdc++/8463 * include/bits/ios_base.h (~ios_base): Make virtual. Index: include/bits/ios_base.h =================================================================== RCS file: /cvs/gcc/gcc/libstdc++-v3/include/bits/ios_base.h,v retrieving revision 1.19 diff -c -p -r1.19 ios_base.h *** include/bits/ios_base.h 24 Jul 2002 23:17:12 -0000 1.19 --- include/bits/ios_base.h 5 Nov 2002 16:26:39 -0000 *************** namespace std *** 414,420 **** } // Destructor ! ~ios_base(); protected: ios_base(); --- 414,420 ---- } // Destructor ! virtual ~ios_base(); protected: ios_base();
Sadly, this cannot be applied to the gcc-3_2-branch at the moment as it changes the libstdc++ ABI.
-benjamin
http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=8463
next reply other threads:[~2002-11-05 16:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-05 8:29 bkoz [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-11-06 9:02 bkoz
2002-11-05 5:06 john_maddock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021105162947.19664.qmail@sources.redhat.com \
--to=bkoz@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
--cc=gcc-gnats@gcc.gnu.org \
--cc=gcc-prs@gcc.gnu.org \
--cc=john_maddock@compuserve.com \
--cc=nobody@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).