public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
From: jeffry@mail.utexas.edu
To: gcc-gnats@gcc.gnu.org
Subject: optimization/8530: toplev.c: Close of _DFI lreg dump file guarded with different condition than open
Date: Tue, 19 Nov 2002 12:16:00 -0000	[thread overview]
Message-ID: <20021111213537.2421.qmail@sources.redhat.com> (raw)


>Number:         8530
>Category:       optimization
>Synopsis:       toplev.c: Close of _DFI lreg dump file guarded with different condition than open
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Nov 11 13:36:05 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     Jeff Russell
>Release:        3.1
>Organization:
>Environment:
i686-pc-cygwin
>Description:
In toplev.c. the close_dump_file() call for DFI_lreg is guarded with an "if" statement, while the corresponding "open" is not. Thus, program flow can by-pass the clost_dump_file() call.
While logic in the called routines makes everything "work", it would clean up the source code and eliminate future "stupid" mistakes by moving the "close" outside the guarding "if" statement.
>How-To-Repeat:
Discovered with source code analysis.
>Fix:
Move call to close_dump_file() outside and following the "if" statement.
>Release-Note:
>Audit-Trail:
>Unformatted:


             reply	other threads:[~2002-11-11 21:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-19 12:16 jeffry [this message]
2002-12-11 12:51 bangerth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021111213537.2421.qmail@sources.redhat.com \
    --to=jeffry@mail.utexas.edu \
    --cc=gcc-gnats@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).