From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6396 invoked by alias); 5 Dec 2002 21:26:01 -0000 Mailing-List: contact gcc-prs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-prs-owner@gcc.gnu.org Received: (qmail 6377 invoked by uid 71); 5 Dec 2002 21:26:00 -0000 Resent-Date: 5 Dec 2002 21:26:00 -0000 Resent-Message-ID: <20021205212600.6376.qmail@sources.redhat.com> Resent-From: gcc-gnats@gcc.gnu.org (GNATS Filer) Resent-Cc: gcc-prs@gcc.gnu.org, gcc-bugs@gcc.gnu.org, abramo.bagnara@libero.it Resent-Reply-To: gcc-gnats@gcc.gnu.org, bagnara@cs.unipr.it Received: (qmail 5442 invoked by uid 61); 5 Dec 2002 21:20:45 -0000 Message-Id: <20021205212045.5441.qmail@sources.redhat.com> Date: Thu, 05 Dec 2002 13:26:00 -0000 From: bagnara@cs.unipr.it Reply-To: bagnara@cs.unipr.it To: gcc-gnats@gcc.gnu.org Cc: abramo.bagnara@libero.it X-Send-Pr-Version: gnatsweb-2.9.3 (1.1.1.1.2.31) X-GNATS-Notify: abramo.bagnara@libero.it Subject: optimization/8829: Over-optimization at -O2 and above (affecting GLIBC macros) X-SW-Source: 2002-12/txt/msg00305.txt.bz2 List-Id: >Number: 8829 >Category: optimization >Synopsis: Over-optimization at -O2 and above (affecting GLIBC macros) >Confidential: no >Severity: serious >Priority: medium >Responsible: unassigned >State: open >Class: wrong-code >Submitter-Id: net >Arrival-Date: Thu Dec 05 13:26:00 PST 2002 >Closed-Date: >Last-Modified: >Originator: Roberto Bagnara >Release: 3.2.1 >Organization: >Environment: RedHat 8.0 $ uname -a Linux zoltan.unisuv.it 2.4.20 #33 Sun Dec 1 21:23:01 CET 2002 i686 athlon i386 GNU/Linux $ gcc -v Reading specs from /usr/local/lib/gcc-lib/i686-pc-linux-gnu/3.2.1/specs Configured with: ../gcc-3.2.1/configure --prefix=/usr/local Thread model: posix gcc version 3.2.1 >Description: With -O2, gcc removes instructions that should not be removed. >How-To-Repeat: Compile the attached file, bug.cc, with $ gcc -S -O2 bug.c and notice that the instructions for swapping the bytes have been removed from get_float32() while, interestingly, they have not been removed from get_int32(). Notice also that, if the call to q(v) is uncommented from get_float32(), the over-optimization goes away. It is perhaps worth noticing that the macros in bug.c come from GLIBC. Here is the file bug.s that I obtain from bug.c (untouched) with the compilation command above: .file "bug.c" .text .p2align 4,,15 .globl get_float32 .type get_float32,@function get_float32: pushl %ebp movl %esp, %ebp subl $4, %esp movl 8(%ebp), %eax flds (%eax) movl %ebp, %esp popl %ebp ret .Lfe1: .size get_float32,.Lfe1-get_float32 .p2align 4,,15 .globl get_int32 .type get_int32,@function get_int32: pushl %ebp movl %esp, %ebp subl $4, %esp movl 8(%ebp), %eax movl (%eax), %eax movl %eax, -4(%ebp) movl %ebp, %esp #APP rorw $8, %ax;rorl $16, %eax;rorw $8, %ax #NO_APP popl %ebp ret .Lfe2: .size get_int32,.Lfe2-get_int32 .ident "GCC: (GNU) 3.2.1" >Fix: >Release-Note: >Audit-Trail: >Unformatted: ----gnatsweb-attachment---- Content-Type: application/octet-stream; name="bug.c" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="bug.c" Ci8qIFN3YXAgYnl0ZXMgaW4gMzIgYml0IHZhbHVlLiAgKi8KI2RlZmluZSBfX2Jzd2FwX2NvbnN0 YW50XzMyKHgpIFwKICAgICAoKCgoeCkgJiAweGZmMDAwMDAwKSA+PiAyNCkgfCAoKCh4KSAmIDB4 MDBmZjAwMDApID4+ICA4KSB8CQkgICAgICBcCiAgICAgICgoKHgpICYgMHgwMDAwZmYwMCkgPDwg IDgpIHwgKCgoeCkgJiAweDAwMDAwMGZmKSA8PCAyNCkpCgojaWYgZGVmaW5lZCBfX0dOVUNfXyAm JiBfX0dOVUNfXyA+PSAyCi8qIFRvIHN3YXAgdGhlIGJ5dGVzIGluIGEgd29yZCB0aGUgaTQ4NiBw cm9jZXNzb3JzIGFuZCB1cCBwcm92aWRlIHRoZQogICBgYnN3YXAnIG9wY29kZS4gIE9uIGkzODYg d2UgaGF2ZSB0byB1c2UgdGhyZWUgaW5zdHJ1Y3Rpb25zLiAgKi8KIyBpZiAhZGVmaW5lZCBfX2k0 ODZfXyAmJiAhZGVmaW5lZCBfX3BlbnRpdW1fXyAmJiAhZGVmaW5lZCBfX3BlbnRpdW1wcm9fXwoj ICBkZWZpbmUgX19ic3dhcF8zMih4KQkJCQkJCQkgICAgICBcCiAgICAgKF9fZXh0ZW5zaW9uX18J CQkJCQkJICAgICAgXAogICAgICAoeyByZWdpc3RlciB1bnNpZ25lZCBpbnQgX192LCBfX3ggPSAo eCk7CQkJCSAgICAgIFwKCSBpZiAoX19idWlsdGluX2NvbnN0YW50X3AgKF9feCkpCQkJCSAgICAg IFwKCSAgIF9fdiA9IF9fYnN3YXBfY29uc3RhbnRfMzIgKF9feCk7CQkJCSAgICAgIFwKCSBlbHNl CQkJCQkJCQkgICAgICBcCgkgICBfX2FzbV9fICgicm9ydyAkOCwgJXcwOyIJCQkJCSAgICAgIFwK CQkgICAgInJvcmwgJDE2LCAlMDsiCQkJCQkgICAgICBcCgkJICAgICJyb3J3ICQ4LCAldzAiCQkJ CQkgICAgICBcCgkJICAgIDogIj1yIiAoX192KQkJCQkJICAgICAgXAoJCSAgICA6ICIwIiAoX194 KQkJCQkJCSAgICAgIFwKCQkgICAgOiAiY2MiKTsJCQkJCQkgICAgICBcCgkgX192OyB9KSkKIyBl bHNlCiMgIGRlZmluZSBfX2Jzd2FwXzMyKHgpIFwKICAgICAoX19leHRlbnNpb25fXwkJCQkJCQkg ICAgICBcCiAgICAgICh7IHJlZ2lzdGVyIHVuc2lnbmVkIGludCBfX3YsIF9feCA9ICh4KTsJCQkJ ICAgICAgXAoJIGlmIChfX2J1aWx0aW5fY29uc3RhbnRfcCAoX194KSkJCQkJICAgICAgXAoJICAg X192ID0gX19ic3dhcF9jb25zdGFudF8zMiAoX194KTsJCQkJICAgICAgXAoJIGVsc2UJCQkJCQkJ CSAgICAgIFwKCSAgIF9fYXNtX18gKCJic3dhcCAlMCIgOiAiPXIiIChfX3YpIDogIjAiIChfX3gp KTsJCSAgICAgIFwKCSBfX3Y7IH0pKQojIGVuZGlmCiNlbHNlCiMgZGVmaW5lIF9fYnN3YXBfMTYo eCkgXAogICAgIChfX2V4dGVuc2lvbl9fCQkJCQkJCSAgICAgIFwKICAgICAgKHsgcmVnaXN0ZXIg dW5zaWduZWQgaW50IF9feCA9ICh4KTsgX19ic3dhcF9jb25zdGFudF8zMiAoX194KTsgfSkpCiNl bmRpZgoKc3RhdGljIGlubGluZSB2b2lkIHN3YXBfZmxvYXQzMihmbG9hdCogcCkKewoJKihpbnQq KXAgPSBfX2Jzd2FwXzMyKCooaW50KilwKTsKfQoKc3RhdGljIGlubGluZSB2b2lkIHN3YXBfaW50 MzIoaW50KiBwKQp7CgkqKGludCopcCA9IF9fYnN3YXBfMzIoKihpbnQqKXApOwp9CgpmbG9hdCBn ZXRfZmxvYXQzMih2b2lkICpwZGF0YSkKewoJZmxvYXQgdiA9ICooZmxvYXQqKXBkYXRhOwoJc3dh cF9mbG9hdDMyKCZ2KTsKLy8JcSh2KTsKCXJldHVybiB2Owp9CgkJCmludCBnZXRfaW50MzIodm9p ZCAqcGRhdGEpCnsKCWludCB2ID0gKihpbnQqKXBkYXRhOwoJc3dhcF9pbnQzMigmdik7Ci8vCXEo dik7CglyZXR1cm4gdjsKfQoJCQo=