public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
From: peturr02@ru.is
To: gcc-gnats@gcc.gnu.org
Subject: libstdc++/9425: filebuf::pbackfail broken
Date: Thu, 23 Jan 2003 19:06:00 -0000	[thread overview]
Message-ID: <20030123190404.6059.qmail@sources.redhat.com> (raw)


>Number:         9425
>Category:       libstdc++
>Synopsis:       filebuf::pbackfail broken
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 23 19:06:01 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     peturr02@ru.is
>Release:        gcc-3.2.1
>Organization:
>Environment:
Red Hat Linux 8.0
>Description:
basic_filebuf<>::pbackfail calls basic_filebuf<>::seekoff, but fails to check the return value. If seekoff fails for some reason (including, but not limited to codecvt<>::encoding() <= 0), strange things happen.
>How-To-Repeat:
See attachment.
>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted:
----gnatsweb-attachment----
Content-Type: text/plain; name="pbackfailbug.cc"
Content-Disposition: inline; filename="pbackfailbug.cc"

#include <fstream>
#include <locale>
#include <cstdio>
#include <cwchar>

#undef NDEBUG
#include <cassert>

using namespace std;

class Variable : public codecvt<char, char, mbstate_t>
{
	int do_encoding() const throw() { return 0; }
};

int main()
{
	char buf[BUFSIZ];
	
	filebuf fb01;
	fb01.open("filebuf_virtuals-1.txt", ios_base::in);
	streamsize sz1 = fb01.sgetn(buf, BUFSIZ);
	assert(sz1 == BUFSIZ);

	fb01.sgetc();
	int n1 = fb01.sputbackc('a');
	if (n1 == EOF)
		return 0;

	streamsize sz2 = fb01.sgetn(buf, BUFSIZ);
	assert(buf[0] == 'a');
	fb01.close();

	filebuf fb02;
	locale loc;
	loc = locale(loc, new Variable);
	fb02.pubimbue(loc);
	fb02.open("filebuf_virtuals-1.txt", ios_base::in);
	streamsize sz3 = fb02.sgetn(buf, BUFSIZ);
	assert(sz3 == BUFSIZ);

	fb02.sgetc();
	int n2 = fb02.sputbackc('a');
	if (n2 == EOF)
		return 0;

	streamsize sz4 = fb02.sgetn(buf, BUFSIZ);
	assert(buf[0] == 'a');
	assert(sz4 == sz2);


	return 0;
}


             reply	other threads:[~2003-01-23 19:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-23 19:06 peturr02 [this message]
2003-02-02 21:03 paolo
2003-02-05 19:22 paolo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030123190404.6059.qmail@sources.redhat.com \
    --to=peturr02@ru.is \
    --cc=gcc-gnats@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).