From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27884 invoked by alias); 30 Jan 2003 13:56:00 -0000 Mailing-List: contact gcc-prs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-prs-owner@gcc.gnu.org Received: (qmail 27864 invoked by uid 71); 30 Jan 2003 13:56:00 -0000 Resent-Date: 30 Jan 2003 13:56:00 -0000 Resent-Message-ID: <20030130135600.27863.qmail@sources.redhat.com> Resent-From: gcc-gnats@gcc.gnu.org (GNATS Filer) Resent-Cc: gcc-prs@gcc.gnu.org, gcc-bugs@gcc.gnu.org Resent-Reply-To: gcc-gnats@gcc.gnu.org, pfeifer@dbai.tuwien.ac.at (Gerald Pfeifer) Received: (qmail 22679 invoked from network); 30 Jan 2003 13:46:36 -0000 Received: from unknown (HELO vexpert.dbai.tuwien.ac.at) (128.130.111.12) by 172.16.49.205 with SMTP; 30 Jan 2003 13:46:36 -0000 Received: from naos.dbai.tuwien.ac.at (naos [128.130.111.28]) by vexpert.dbai.tuwien.ac.at (8.12.6/8.12.6) with ESMTP id h0UDkVZb008455; Thu, 30 Jan 2003 14:46:31 +0100 (CET) Received: (from pfeifer@localhost) by naos.dbai.tuwien.ac.at (8.12.6/8.12.6/Submit) id h0UDkTOQ066803; Thu, 30 Jan 2003 14:46:29 +0100 (CET) Message-Id: <200301301346.h0UDkTOQ066803@naos.dbai.tuwien.ac.at> Date: Thu, 30 Jan 2003 13:56:00 -0000 From: pfeifer@dbai.tuwien.ac.at (Gerald Pfeifer) To: gcc-gnats@gcc.gnu.org X-Send-Pr-Version: 3.113 Subject: target/9506: ABI breakage: structure return X-SW-Source: 2003-01/txt/msg01723.txt.bz2 List-Id: >Number: 9506 >Category: target >Synopsis: ABI breakage: structure return >Confidential: no >Severity: serious >Priority: medium >Responsible: unassigned >State: open >Class: sw-bug >Submitter-Id: net >Arrival-Date: Thu Jan 30 13:56:00 UTC 2003 >Closed-Date: >Last-Modified: >Originator: >Release: 3.4 20030130 (experimental) >Organization: >Environment: System: FreeBSD naos.dbai.tuwien.ac.at 4.7-RELEASE FreeBSD 4.7-RELEASE #0: Thu Jan 9 09:25:29 CET 2003 root@aludra.dbai.tuwien.ac.at:/usr/src/sys/compile/DBAI-MP i386 host: i386-unknown-freebsd4.7 build: i386-unknown-freebsd4.7 target: i386-unknown-freebsd4.7 configured with: /sw/test/gcc/cvs/configure --prefix=/sw/gcc-current --enable-languages=c,c++ --disable-checking >Description: Unless I am completely mistaken, the following patch is responsible for an ABI change I am seeing on FreeBSD (and apparently also Cygwin, Interix, OpenBSD, NetBSD) on i386 platforms for GCC 3.2.1 as well as the 3.3 branch and mainline: Thu Oct 31 18:08:00 CET 2002 Jan Hubicka * i386.c (override_options): Set defaults for flag_omit_frame_pointer, flag_asynchronous_unwind_tables, flag_pcc_struct_return. * i386.c (optimization_options): Set flag_omit_frame_pointer, flag_asynchronous_unwind_tables, flag_pcc_struct_return to 2. Do not clear -momit-leaf-frame-pointer when profiling. (ix86_frame_pointer_required): Frame pointer is always required when profiling. http://gcc.gnu.org/ml/gcc-patches/2002-10/msg01887.html >How-To-Repeat: #include #include int main() { div_t d = div(20,5); printf("20/5 = %d mod %d\n",d.quot,d.rem); } will print something different from "20/5 = 4 mod 0". >Fix: What I believe is wrong with this patch is that it _completely_ ignores DEFAULT_PCC_STRUCT_RETURN when setting flag_pcc_struct_return: gcc/config/i386% grep DEFAULT_PCC_STRUCT_RETURN *.h | wc -l 19 gcc/config/i386% grep DEFAULT_PCC_STRUCT_RETURN i386.c | wc -l 0 >Release-Note: >Audit-Trail: >Unformatted: