public inbox for gcc-prs@sourceware.org help / color / mirror / Atom feed
From: "Joseph S. Myers" <jsm28@cam.ac.uk> To: nobody@gcc.gnu.org Cc: gcc-prs@gcc.gnu.org, Subject: Re: c/9072: -Wconversion should be split into two distinct flags Date: Mon, 03 Feb 2003 00:16:00 -0000 [thread overview] Message-ID: <20030203001601.1557.qmail@sources.redhat.com> (raw) The following reply was made to PR c/9072; it has been noted by GNATS. From: "Joseph S. Myers" <jsm28@cam.ac.uk> To: <bangerth@dealii.org>, <128950@bugs.debian.org>, <agthorr@barsoom.org>, <gcc-bugs@gcc.gnu.org>, <segher@koffie.nl>, <gcc-gnats@gcc.gnu.org> Cc: Subject: Re: c/9072: -Wconversion should be split into two distinct flags Date: Mon, 3 Feb 2003 00:08:30 +0000 (GMT) On 2 Feb 2003 bangerth@dealii.org wrote: > Has been analyzed. Patch is even in the audit trail, but > seems to have become stuck in gcc's patch acceptance machinery... The patch isn't even one suitable for review, as it lacks testcases. It is established procedure [0] that patches failing to follow the standards adequately get ignored. Even with them, it just papers over particular problems rather than actually implementing a sensible consistent specification for -Wconversion. [0] This is very bad procedure; ignoring patches rather than explaining what is wrong is far too likely to lose potential contributors. It is, however, what happens; patches not following the standards are more tedious to review than ones following the standards, and even many good patches following the standards get ignored. However, this patch was not ignored; it received several comments on what ought to be done. I expect a patch that followed the GNU and GCC coding standards, including thorough testcases, and implemented the simple specification I gave for -Wconversion (warn for any implicit conversion that may change a value), would get reviewed. -- Joseph S. Myers jsm28@cam.ac.uk
next reply other threads:[~2003-02-03 0:16 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2003-02-03 0:16 Joseph S. Myers [this message] -- strict thread matches above, loose matches on Subject: below -- 2003-02-03 16:36 Wolfgang Bangerth 2003-02-03 2:36 Agthorr 2003-02-03 2:06 Segher Boessenkool 2003-02-02 22:54 bangerth 2002-12-29 4:06 Joseph S. Myers 2002-12-29 1:06 Zack Weinberg 2002-12-29 0:56 Segher Boessenkool 2002-12-29 0:46 Zack Weinberg 2002-12-28 22:16 Segher Boessenkool 2002-12-27 15:36 Matthias Klose
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20030203001601.1557.qmail@sources.redhat.com \ --to=jsm28@cam.ac.uk \ --cc=gcc-prs@gcc.gnu.org \ --cc=nobody@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).