public inbox for gcc-prs@sourceware.org help / color / mirror / Atom feed
From: "Pétur Runólfsson" <peturr02@ru.is> To: nobody@gcc.gnu.org Cc: gcc-prs@gcc.gnu.org, Subject: RE: libstdc++/9876: filebuf::sputc more than 10% slower than putc Date: Mon, 03 Mar 2003 11:16:00 -0000 [thread overview] Message-ID: <20030303111601.8414.qmail@sources.redhat.com> (raw) The following reply was made to PR libstdc++/9876; it has been noted by GNATS. From: =?iso-8859-1?Q?P=E9tur_Run=F3lfsson?= <peturr02@ru.is> To: "Paolo Carlini" <pcarlini@unitus.it> Cc: <paolo@gcc.gnu.org>, <gcc-bugs@gcc.gnu.org>, <nobody@gcc.gnu.org>, <gcc-gnats@gcc.gnu.org> Subject: RE: libstdc++/9876: filebuf::sputc more than 10% slower than putc Date: Mon, 3 Mar 2003 11:07:44 -0000 > Very Interesting issues... Indeed, putc_unlocked is _much_=20 > faster (3 x ?) >=20 > However... >=20 > The interesting thing is the following: a series of streambuf::sputc, > does _not_ call an underlying C-library putc, but instead,=20 > upon overflow, > an underlying _M_file.xsputn, which means an underlying=20 > _locked_ fwrite, > _not_ an underlying fwrite_unlocked! >=20 > So, I would argue that your comparison was not fair before,=20 > and it's not > fair now! ;) The locking inside fwrite seems to be totally wasted, since filebuf isn't threadsafe at all (for that, [io]stream::sentry would need to handle the locking), and also _M_really_overflow calls fwrite twice (once with BUFSIZ characters, and then with 1 character). > Needless to say, you are right, and Nathan is right, about the need to > improve our streambuf::sputc, but we still do _not_ have real numbers > to use as a point of reference. >=20 > Are you willing to work on this? Yup. Petur
next reply other threads:[~2003-03-03 11:16 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2003-03-03 11:16 Pétur Runólfsson [this message] -- strict thread matches above, loose matches on Subject: below -- 2003-05-16 18:06 Benjamin Kosnik 2003-05-16 17:56 Paolo Carlini 2003-03-23 19:46 Pétur Runólfsson 2003-02-28 16:46 Paolo Carlini 2003-02-28 16:06 Pétur Runólfsson 2003-02-27 20:22 paolo 2003-02-27 10:36 peturr02
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20030303111601.8414.qmail@sources.redhat.com \ --to=peturr02@ru.is \ --cc=gcc-prs@gcc.gnu.org \ --cc=nobody@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).