public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
From: Richard Henderson <rth@redhat.com>
To: nobody@gcc.gnu.org
Cc: gcc-prs@gcc.gnu.org,
Subject: Re: middle-end/8502: [3.2 regression] wrong code generated for switch statement
Date: Thu, 27 Mar 2003 22:36:00 -0000 [thread overview]
Message-ID: <20030327223600.19279.qmail@sources.redhat.com> (raw)
The following reply was made to PR middle-end/8502; it has been noted by GNATS.
From: Richard Henderson <rth@redhat.com>
To: Volker Reichelt <reichelt@igpm.rwth-aachen.de>
Cc: gcc-gnats@gcc.gnu.org, gcc-bugs@gcc.gnu.org, rveldema@cs.vu.nl,
gcc-patches@gcc.gnu.org
Subject: Re: middle-end/8502: [3.2 regression] wrong code generated for switch statement
Date: Thu, 27 Mar 2003 14:28:07 -0800
On Tue, Mar 25, 2003 at 02:05:43PM +0100, Volker Reichelt wrote:
> I strongly suspect your patch
>
> http://gcc.gnu.org/ml/gcc-cvs/2003-03/msg01201.html
>
> is responsible for the new failure of this PR because it modifies
> cfgrtl.c where the original failure was fixed.
Blah. Test case broke again only at -O0. Fixed thus.
r~
* cfgrtl.c (try_redirect_by_replacing_jump): Disable removing
tablejumps with no optimization.
Index: cfgrtl.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/cfgrtl.c,v
retrieving revision 1.29.2.6.2.2
diff -c -p -d -u -r1.29.2.6.2.2 cfgrtl.c
--- cfgrtl.c 23 Mar 2003 20:41:22 -0000 1.29.2.6.2.2
+++ cfgrtl.c 27 Mar 2003 22:23:00 -0000
@@ -665,7 +665,6 @@ try_redirect_by_replacing_jump (e, targe
edge tmp;
rtx set;
int fallthru = 0;
- rtx table;
/* Verify that all targets will be TARGET. */
for (tmp = src->succ; tmp; tmp = tmp->succ_next)
@@ -675,11 +674,7 @@ try_redirect_by_replacing_jump (e, targe
if (tmp || !onlyjump_p (insn))
return false;
- if (flow2_completed && JUMP_LABEL (insn)
- && (table = NEXT_INSN (JUMP_LABEL (insn))) != NULL_RTX
- && GET_CODE (table) == JUMP_INSN
- && (GET_CODE (PATTERN (table)) == ADDR_VEC
- || GET_CODE (PATTERN (table)) == ADDR_DIFF_VEC))
+ if ((!optimize || flow2_completed) && tablejump_p (insn))
return false;
/* Avoid removing branch with side effects. */
next reply other threads:[~2003-03-27 22:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-27 22:36 Richard Henderson [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-03-28 4:31 rth
2003-03-25 15:46 Volker Reichelt
2003-03-25 13:06 reichelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030327223600.19279.qmail@sources.redhat.com \
--to=rth@redhat.com \
--cc=gcc-prs@gcc.gnu.org \
--cc=nobody@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).