public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
From: "Dhananjay R. Deshpande" <dhananjayd@kpit.com>
To: kazu@gcc.gnu.org
Cc: gcc-prs@gcc.gnu.org,
Subject: Re: target/10205: Incorrect code generated for H8300 "normal" mode
Date: Fri, 28 Mar 2003 07:56:00 -0000 [thread overview]
Message-ID: <20030328073600.28662.qmail@sources.redhat.com> (raw)
The following reply was made to PR target/10205; it has been noted by GNATS.
From: "Dhananjay R. Deshpande" <dhananjayd@kpit.com>
To: <kazu@gcc.gnu.org>,
<gcc-bugs@gcc.gnu.org>,
<mnmoran@bellsouth.net>,
<gcc-gnats@gcc.gnu.org>,
<gcc-patches@gcc.gnu.org>
Cc: "Kazu Hirata" <kazu@cs.umass.edu>
Subject: Re: target/10205: Incorrect code generated for H8300 "normal" mode
Date: Fri, 28 Mar 2003 13:01:11 +0530
Hi,
>Synopsis: Incorrect code generated for H8300 "normal" mode
>State-Changed-From-To: open->analyzed
>State-Changed-By: kazu
>State-Changed-When: Thu Mar 27 19:59:48 2003
>State-Changed-Why:
> Still present in mainline. Here is a smaller testcase.
=20
The patch below fixes this. If it is OK, it should be applied to both =
mainline=20
and 3.3 branch.
- Dhannajay
Changelog
2003-03-28 Dhananjay Deshpande <dhananjayd@kpit.com>
PR target/10205
* config/h8300/h8300.c (h8300_initial_elimination_offset): =
Remove hack in=20
adjustment of offset for normal mode.
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D
--- h8300.c.orig Fri Mar 28 12:07:21 2003
+++ h8300.c Fri Mar 28 12:04:57 2003
@@ -1717,7 +1717,8 @@ h8300_initial_elimination_offset (from,=20
int offset =3D 0;
=20
if (from =3D=3D ARG_POINTER_REGNUM && to =3D=3D FRAME_POINTER_REGNUM)
- offset =3D UNITS_PER_WORD + frame_pointer_needed * UNITS_PER_WORD;
+ offset =3D (POINTER_SIZE / BITS_PER_UNIT) + frame_pointer_needed *
+ UNITS_PER_WORD;
else if (from =3D=3D RETURN_ADDRESS_POINTER_REGNUM && to =3D=3D =
FRAME_POINTER_REGNUM)
offset =3D frame_pointer_needed * UNITS_PER_WORD;
else
@@ -1734,11 +1735,8 @@ h8300_initial_elimination_offset (from,=20
offset +=3D round_frame_size (get_frame_size ());
=20
if (from =3D=3D ARG_POINTER_REGNUM && to =3D=3D =
STACK_POINTER_REGNUM)
- offset +=3D UNITS_PER_WORD; /* Skip saved PC */
+ offset +=3D (POINTER_SIZE / BITS_PER_UNIT); /* Skip saved =
PC */
}
-
- if ((TARGET_H8300H || TARGET_H8300S) && TARGET_NORMAL_MODE)
- offset -=3D 2;
=20
return offset;
}
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D
next reply other threads:[~2003-03-28 7:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-28 7:56 Dhananjay R. Deshpande [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-03-28 16:56 Kazu Hirata
2003-03-28 15:26 kazu
2003-03-28 15:07 Kazu Hirata
2003-03-27 20:12 kazu
2003-03-27 13:12 kazu
2003-03-25 5:46 mnmoran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030328073600.28662.qmail@sources.redhat.com \
--to=dhananjayd@kpit.com \
--cc=gcc-prs@gcc.gnu.org \
--cc=kazu@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).