From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19132 invoked by alias); 28 Mar 2003 15:26:01 -0000 Mailing-List: contact gcc-prs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-prs-owner@gcc.gnu.org Received: (qmail 19056 invoked by uid 71); 28 Mar 2003 15:26:00 -0000 Date: Fri, 28 Mar 2003 16:56:00 -0000 Message-ID: <20030328152600.19055.qmail@sources.redhat.com> To: kazu@gcc.gnu.org Cc: gcc-prs@gcc.gnu.org, From: Kazu Hirata Subject: Re: target/10205: Incorrect code generated for H8300 "normal" mode Reply-To: Kazu Hirata X-SW-Source: 2003-03/txt/msg02002.txt.bz2 List-Id: The following reply was made to PR target/10205; it has been noted by GNATS. From: Kazu Hirata To: , , , Cc: Subject: Re: target/10205: Incorrect code generated for H8300 "normal" mode Date: Fri, 28 Mar 2003 10:21:26 -0500 (EST) Hi, Here is the final patch I committed to 3.3 branch and mainline. Kazu Hirata 2003-03-28 Kazu Hirata , Dhananjay Deshpande PR target/10205 * config/h8300/h8300.c (h8300_initial_elimination_offset): Correct the offset computation when TARGET_NORMAL. Index: h8300.c =================================================================== RCS file: /cvs/gcc/gcc/gcc/config/h8300/h8300.c,v retrieving revision 1.221 diff -u -r1.221 h8300.c --- h8300.c 22 Mar 2003 15:22:37 -0000 1.221 +++ h8300.c 28 Mar 2003 14:50:38 -0000 @@ -1715,9 +1715,11 @@ int from, to; { int offset = 0; + /* The number of bytes that the return address takes on the stack. */ + int pc_size = POINTER_SIZE / BITS_PER_UNIT; if (from == ARG_POINTER_REGNUM && to == FRAME_POINTER_REGNUM) - offset = UNITS_PER_WORD + frame_pointer_needed * UNITS_PER_WORD; + offset = pc_size + frame_pointer_needed * UNITS_PER_WORD; else if (from == RETURN_ADDRESS_POINTER_REGNUM && to == FRAME_POINTER_REGNUM) offset = frame_pointer_needed * UNITS_PER_WORD; else @@ -1734,11 +1736,9 @@ offset += round_frame_size (get_frame_size ()); if (from == ARG_POINTER_REGNUM && to == STACK_POINTER_REGNUM) - offset += UNITS_PER_WORD; /* Skip saved PC */ + /* Skip saved PC. */ + offset += pc_size; } - - if ((TARGET_H8300H || TARGET_H8300S) && TARGET_NORMAL_MODE) - offset -= 2; return offset; }