public inbox for gcc-prs@sourceware.org
help / color / mirror / Atom feed
From: Zack Weinberg <zack@codesourcery.com>
To: zack@gcc.gnu.org
Cc: gcc-prs@gcc.gnu.org,
Subject: Re: preprocessor/7312: bootstrap failure due to invalid use of errno
Date: Fri, 09 May 2003 15:36:00 -0000	[thread overview]
Message-ID: <20030509153601.20392.qmail@sources.redhat.com> (raw)

The following reply was made to PR preprocessor/7312; it has been noted by GNATS.

From: Zack Weinberg <zack@codesourcery.com>
To: gcc-bugs@gcc.gnu.org, bruno@clisp.org
Cc: gcc-gnats@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: preprocessor/7312: bootstrap failure due to invalid use of
 errno
Date: Fri, 09 May 2003 08:26:33 -0700

 http://gcc.gnu.org/PR?7312
 
 I apologize for not noticing this bug earlier.  It's indeed a bug, but
 I don't think your suggested fix is right.  At that point in the code,
 nothing has been done to give errno a meaningful value, so ->err_no
 should just be cleared to 0.
 
 I will apply this patch later today, along with some other changes, if
 bootstrap succeeds.
 
 zw
 
         PR preprocessor/7312
         * cppfiles.c (find_or_create_entry): Initialize file->err_no
         to 0, not errno.
 
 ===================================================================
 Index: cppfiles.c
 --- cppfiles.c	21 Apr 2003 19:21:53 -0000	1.168
 +++ cppfiles.c	9 May 2003 15:24:48 -0000
 @@ -184,7 +184,7 @@ find_or_create_entry (pfile, fname)
        file = xcnew (struct include_file);
        file->name = name;
        file->header_name = name;
 -      file->err_no = errno;
 +      file->err_no = 0;
        node = splay_tree_insert (pfile->all_include_files,
  				(splay_tree_key) file->name,
  				(splay_tree_value) file);


             reply	other threads:[~2003-05-09 15:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-09 15:36 Zack Weinberg [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-05-11 14:56 neil
2003-05-09 22:26 Zack Weinberg
2003-05-09 22:16 Neil Booth
2003-05-09 16:06 Bruno Haible
2003-05-09 15:26 zack
2003-05-09 15:20 bangerth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030509153601.20392.qmail@sources.redhat.com \
    --to=zack@codesourcery.com \
    --cc=gcc-prs@gcc.gnu.org \
    --cc=zack@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).