public inbox for gcc-prs@sourceware.org help / color / mirror / Atom feed
From: Zack Weinberg <zack@codesourcery.com> To: nobody@gcc.gnu.org Cc: gcc-prs@gcc.gnu.org, Subject: Re: c/10829: Macros that worked in 2.95.3 don't work in 3.3 Date: Sat, 17 May 2003 05:26:00 -0000 [thread overview] Message-ID: <20030517052600.4771.qmail@sources.redhat.com> (raw) The following reply was made to PR c/10829; it has been noted by GNATS. From: Zack Weinberg <zack@codesourcery.com> To: aaronw@net.com Cc: gcc-gnats@gcc.gnu.org Subject: Re: c/10829: Macros that worked in 2.95.3 don't work in 3.3 Date: Fri, 16 May 2003 22:25:46 -0700 aaronw@net.com writes: > #define TEST(t, num) (PAP_ ## t ## (c->PAT_ ## t ## ( ## num ## ))) Your code is not valid: the C standard clearly states that applying ## to two tokens whose concatenation does not form a single valid token provokes undefined behavior. There is nothing that can be combined with a ( or a ) to produce a single valid token, except a "placemarker" which occurs only under exotic conditions. A correct version of your macro would be #define TEST(t, num) (PAP_ ## t (c->PAT_ ## t (num))) This expands exactly the same way, but does not give the warnings. Rule of thumb: if the things on either side of ##, after argument substitution, are not identifiers or pp-numbers, you have made a mistake. This is overbroad -- one may legitimately paste together a + and an = in that order, for instance -- but covers all the normal uses of ##. zw
next reply other threads:[~2003-05-17 5:26 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2003-05-17 5:26 Zack Weinberg [this message] -- strict thread matches above, loose matches on Subject: below -- 2003-05-17 6:26 Zack Weinberg 2003-05-17 6:16 Aaron Williams 2003-05-17 5:31 zack 2003-05-17 4:36 aaronw
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20030517052600.4771.qmail@sources.redhat.com \ --to=zack@codesourcery.com \ --cc=gcc-prs@gcc.gnu.org \ --cc=nobody@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).