public inbox for gcc-regression@sourceware.org help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@kam.mff.cuni.cz> To: Tobias Burnus <tobias@codesourcery.com> Cc: "sunil.k.pandey" <skpandey@sc.intel.com>, fortran <fortran@gcc.gnu.org>, gcc-patches@gcc.gnu.org, gcc-regression@gcc.gnu.org Subject: Re: [Patch] (was: Re: [r12-4457 Regression] FAIL: gfortran.dg/deferred_type_param_6.f90 -Os execution test on Linux/x86_64) Date: Sat, 16 Oct 2021 20:54:37 +0200 [thread overview] Message-ID: <20211016185437.GB23986@kam.mff.cuni.cz> (raw) In-Reply-To: <bd183830-0e3f-a1c9-9c6c-97005cced372@codesourcery.com> > > Fortran has for a long time 'character(len=5), allocatable" or > "character(len=*)". In the first case, the "5" can be ignored as both > caller and callee know the length. In the second case, the length is > determined by the argument, but it cannot be changed. > > Since a not-that-short while, 'len=:' together with allocatable/pointer > is supported. > > In the latter case, the value can be change when the array > association/allocation is changed. > > I attached a patch, which was not tested. I am not quite sure whether > the pointer address can actually escape or not - I think cannot but I > played safe. > > Tobias > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 > Fortran: Fix fn spec for character-returning functions > > gcc/fortran/ChangeLog > * trans-types.c (create_fn_spec): For character-returning functions, > set the hidden string-length argument to 'R' only when the "len=:", > i.e. deferred length which goes alongside with allocatable/pointer. > > diff --git a/gcc/fortran/trans-types.c b/gcc/fortran/trans-types.c > index 220976babb8..637d2c71d01 100644 > --- a/gcc/fortran/trans-types.c > +++ b/gcc/fortran/trans-types.c > @@ -3008,7 +3008,14 @@ create_fn_spec (gfc_symbol *sym, tree fntype) > } > if (sym->ts.type == BT_CHARACTER) > { > - spec[spec_len++] = 'R'; > + if (!sym->ts.u.cl->length > + && ((sym->attr.allocatable && sym->attr.target) > + || sym->attr.pointer)) > + spec[spec_len++] = '.'; > + if (!sym->ts.u.cl->length && sym->attr.allocatable) > + spec[spec_len++] = 'w'; > + else > + spec[spec_len++] = 'R'; > spec[spec_len++] = ' '; Thanks a lot! I was just looking into that function and was quite confused on what is going there. Are you going to commit the patch? Also escaping is quite important bit of information so it would be good to figure out if it really can escape rather than playing safe. Honza > } > }
next prev parent reply other threads:[~2021-10-16 18:54 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-16 16:11 [r12-4457 Regression] FAIL: gfortran.dg/deferred_type_param_6.f90 -Os execution test on Linux/x86_64 sunil.k.pandey 2021-10-16 18:23 ` Jan Hubicka 2021-10-16 18:48 ` [Patch] (was: Re: [r12-4457 Regression] FAIL: gfortran.dg/deferred_type_param_6.f90 -Os execution test on Linux/x86_64) Tobias Burnus 2021-10-16 18:54 ` Jan Hubicka [this message] 2021-10-19 14:49 ` [Patch, committed] Fortran: Fix 'fn spec' for deferred character length " Tobias Burnus 2021-10-18 9:51 ` [r12-4457 Regression] FAIL: gfortran.dg/deferred_type_param_6.f90 -Os execution test on Linux/x86_64 Richard Biener
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211016185437.GB23986@kam.mff.cuni.cz \ --to=hubicka@kam.mff.cuni.cz \ --cc=fortran@gcc.gnu.org \ --cc=gcc-patches@gcc.gnu.org \ --cc=gcc-regression@gcc.gnu.org \ --cc=skpandey@sc.intel.com \ --cc=tobias@codesourcery.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).