From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id 877403858CDB for ; Sat, 8 Oct 2022 07:09:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 877403858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-x334.google.com with SMTP id i81-20020a1c3b54000000b003c3c60c13f5so641023wma.0 for ; Sat, 08 Oct 2022 00:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=list-id:mime-version:subject:message-id:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=Z1eDByDGUaExd9MG5CwWIsALwSI3SSgtb2yXQnjuF1U=; b=Z3/M8k9CqvCESajTb1BYwPAKGm2Dr5ghUgYOdhfkChD8w4+j4DZobO6LorT02+yYVU WNenfD2da57YBv30PnztQU4QgyVUONMYSrbfSAokg0aZPfAaFTjEjlgPZQ1hSTimRzKw 3qXO9ilj64uTXv3AkCwXWPkWtqH8WPdfYyteFlslZCSCeCeHKNET25vsd9geSZrfGmYR yLoH9nAOJRbv2Dsd8rUmQW6D2jszOgGqtTIXFpn7l6w092ZXJrftMwSo6zS59ld7VJQn bbdPwfsNlsqU0eqdTgtAVhJJDRYpIB/JPwb86EnTmNkUKPBHiGMJdM7JyRSO/moIkODh LG+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=list-id:mime-version:subject:message-id:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z1eDByDGUaExd9MG5CwWIsALwSI3SSgtb2yXQnjuF1U=; b=E7iWWfcGxOmCXuo8d7Cfeh4EP4EIHxQxvkglQZIeEuTIlxZUiejTHVuMwaNFZ5pPxz fsPi2tpeZelDrpc83AB08RK7KEMiA5nFWioZyoP5xeb+Ek8fwxegqJkS5u8F+fXofdf+ UNoLI+cg5QnBBY5jWm9gpGMvLGbe6f7gxbzOLs1T72kX9WH7nggEYSB5C0nL717F5db9 kjUZpbbTC5OLEEH+bytghqeThpMWk6xA22Az0FhsvIJsl/WFGePTT0qcec7TfiYqf7Zy 6sTLb9GvuRsbIdXoqh8twkjXsxawoDHWwcIOpfgDt7TS16HYbW4uvlFBtxr4MPckGpHn 6dAw== X-Gm-Message-State: ACrzQf2WdUIYM78lj1ub/mGhs/bwuzhAX9JWrbfbKXZcrN/uc7Tif8rD rCIr+dtNZ7SZ+HiZsYx2nWJIcg== X-Google-Smtp-Source: AMsMyM4CEHqiuBrgWRYUl6G1BSlRctGtNF3RUNy24LO6NyaifNBsSueEn92uhgu+ZKSkLMYU4QEtpA== X-Received: by 2002:a05:600c:1f06:b0:3c1:abc3:895d with SMTP id bd6-20020a05600c1f0600b003c1abc3895dmr5660767wmb.138.1665212951285; Sat, 08 Oct 2022 00:09:11 -0700 (PDT) Received: from jenkins.jenkins (ci.linaro.org. [88.99.136.175]) by smtp.gmail.com with ESMTPSA id q5-20020a05600000c500b0022e2eaa2bdcsm3804984wrx.98.2022.10.08.00.09.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Oct 2022 00:09:10 -0700 (PDT) From: ci_notify@linaro.org X-Google-Original-From: linaro-infrastructure-errors@lists.linaro.org Date: Sat, 8 Oct 2022 07:09:09 +0000 (UTC) To: Eugene Rozenfeld Cc: gcc-regression@gcc.gnu.org Message-ID: <2033316938.8665.1665212950522@jenkins.jenkins> Subject: [TCWG CI] Failure after basepoints/gcc-13-3172-gf30e9fd33e5: Set discriminators for call stmts on the same line within the same basic block. MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_8664_2112137705.1665212949560" X-Jenkins-Job: TCWG Build tcwg_gcc_bootstrap/master-aarch64-bootstrap_lto X-Jenkins-Result: SUCCESS List-ID: X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_LOTSOFHASH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org ------=_Part_8664_2112137705.1665212949560 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Failure after basepoints/gcc-13-3172-gf30e9fd33e5: Set discriminators for call stmts on the same line within the same basic block.: Results changed to -10 # true: 0 # build_abe binutils: 1 # build_abe bootstrap_lto: # FAILED # First few build errors in logs: # 00:05:38 make[3]: [Makefile:1814: aarch64-unknown-linux-gnu/bits/largefile-config.h] Error 1 (ignored) # 00:05:38 make[3]: [Makefile:1815: aarch64-unknown-linux-gnu/bits/largefile-config.h] Error 1 (ignored) # 00:30:18 make[3]: [Makefile:1814: aarch64-unknown-linux-gnu/bits/largefile-config.h] Error 1 (ignored) # 00:30:18 make[3]: [Makefile:1815: aarch64-unknown-linux-gnu/bits/largefile-config.h] Error 1 (ignored) # 00:42:56 make[3]: [Makefile:1814: aarch64-unknown-linux-gnu/bits/largefile-config.h] Error 1 (ignored) # 00:42:56 make[3]: [Makefile:1815: aarch64-unknown-linux-gnu/bits/largefile-config.h] Error 1 (ignored) # 00:45:55 make[2]: *** [Makefile:25727: compare] Error 1 # 00:45:55 make[1]: *** [Makefile:25707: stage3-bubble] Error 2 # 00:45:55 make: *** [Makefile:1064: all] Error 2 from -10 # true: 0 # build_abe binutils: 1 # build_abe bootstrap_lto: 2 THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT. For latest status see comments in https://linaro.atlassian.net/browse/GNU-692 . Status of basepoints/gcc-13-3172-gf30e9fd33e5 commit for tcwg_gcc_bootstrap: commit f30e9fd33e56a5a721346ea6140722e1b193db42 Author: Eugene Rozenfeld Date: Thu Apr 21 16:43:24 2022 -0700 Set discriminators for call stmts on the same line within the same basic block. Call statements are possible split points of a basic block so they may end up in different basic blocks by the time pass_ipa_auto_profile executes. This change will also simplify call site lookups since now location with discriminator will uniquely identify the call site (no callee function name is needed). This change is based on commit 1e6c4a7a8fb8e20545bb9f9032d3854f3f794c18 by Dehao Chen in vendors/google/heads/gcc-4_8. Tested on x86_64-pc-linux-gnu. gcc/ChangeLog: * tree-cfg.cc (assign_discriminators): Set discriminators for call stmts on the same line within the same basic block. * master-aarch64-bootstrap_lto ** Failure after basepoints/gcc-13-3172-gf30e9fd33e5: Set discriminators for call stmts on the same line within the same basic block.: ** https://ci.linaro.org/job/tcwg_gcc_bootstrap-build-master-aarch64-bootstrap_lto/464/ Bad build: https://ci.linaro.org/job/tcwg_gcc_bootstrap-build-master-aarch64-bootstrap_lto/464/artifact/artifacts Good build: https://ci.linaro.org/job/tcwg_gcc_bootstrap-build-master-aarch64-bootstrap_lto/463/artifact/artifacts Reproduce current build: mkdir -p investigate-gcc-f30e9fd33e56a5a721346ea6140722e1b193db42 cd investigate-gcc-f30e9fd33e56a5a721346ea6140722e1b193db42 # Fetch scripts git clone https://git.linaro.org/toolchain/jenkins-scripts # Fetch manifests for bad and good builds mkdir -p bad/artifacts good/artifacts curl -o bad/artifacts/manifest.sh https://ci.linaro.org/job/tcwg_gcc_bootstrap-build-master-aarch64-bootstrap_lto/464/artifact/artifacts/manifest.sh --fail curl -o good/artifacts/manifest.sh https://ci.linaro.org/job/tcwg_gcc_bootstrap-build-master-aarch64-bootstrap_lto/463/artifact/artifacts/manifest.sh --fail # Reproduce bad build (cd bad; ../jenkins-scripts/tcwg_gnu-build.sh ^^ true %%rr[top_artifacts] artifacts) # Reproduce good build (cd good; ../jenkins-scripts/tcwg_gnu-build.sh ^^ true %%rr[top_artifacts] artifacts) Full commit (up to 1000 lines): commit f30e9fd33e56a5a721346ea6140722e1b193db42 Author: Eugene Rozenfeld Date: Thu Apr 21 16:43:24 2022 -0700 Set discriminators for call stmts on the same line within the same basic block. Call statements are possible split points of a basic block so they may end up in different basic blocks by the time pass_ipa_auto_profile executes. This change will also simplify call site lookups since now location with discriminator will uniquely identify the call site (no callee function name is needed). This change is based on commit 1e6c4a7a8fb8e20545bb9f9032d3854f3f794c18 by Dehao Chen in vendors/google/heads/gcc-4_8. Tested on x86_64-pc-linux-gnu. gcc/ChangeLog: * tree-cfg.cc (assign_discriminators): Set discriminators for call stmts on the same line within the same basic block. --- gcc/tree-cfg.cc | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/gcc/tree-cfg.cc b/gcc/tree-cfg.cc index 42f40f17c56..41f2925665f 100644 --- a/gcc/tree-cfg.cc +++ b/gcc/tree-cfg.cc @@ -1203,8 +1203,40 @@ assign_discriminators (void) { edge e; edge_iterator ei; + gimple_stmt_iterator gsi; gimple *last = last_stmt (bb); location_t locus = last ? gimple_location (last) : UNKNOWN_LOCATION; + location_t curr_locus = UNKNOWN_LOCATION; + int curr_discr = 0; + + /* Traverse the basic block, if two function calls within a basic block + are mapped to the same line, assign a new discriminator because a call + stmt could be a split point of a basic block. */ + for (gsi = gsi_start_bb (bb); !gsi_end_p (gsi); gsi_next (&gsi)) + { + gimple *stmt = gsi_stmt (gsi); + expanded_location curr_locus_e; + if (curr_locus == UNKNOWN_LOCATION) + { + curr_locus = gimple_location (stmt); + curr_locus_e = expand_location (curr_locus); + } + else if (!same_line_p (curr_locus, &curr_locus_e, gimple_location (stmt))) + { + curr_locus = gimple_location (stmt); + curr_locus_e = expand_location (curr_locus); + curr_discr = 0; + } + else if (curr_discr != 0) + { + location_t loc = gimple_location (stmt); + location_t dloc = location_with_discriminator (loc, curr_discr); + gimple_set_location (stmt, dloc); + } + /* Allocate a new discriminator for CALL stmt. */ + if (gimple_code (stmt) == GIMPLE_CALL) + curr_discr = next_discriminator_for_locus (curr_locus); + } if (locus == UNKNOWN_LOCATION) continue; ------=_Part_8664_2112137705.1665212949560--