Re: [Linaro-TCWG-CI] gcc-14-8680-g2f14c0dbb78: FAIL: 3 regressions on arm

[Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>]

> On Feb 1, 2024, at 16:07, ci_notify--- via Gcc-regression <gcc-regression@gcc.gnu.org> wrote:
> 
> Dear contributor, our automatic CI has detected problems related to your patch(es).  Please find some details below.  If you have any questions, please follow up on linaro-toolchain@lists.linaro.org mailing list, Libera's #linaro-tcwg channel, or ping your favourite Linaro toolchain developer on the usual project channel.
> 
> We appreciate that it might be difficult to find the necessary logs or reproduce the issue locally. If you can't get what you need from our CI within minutes, let us know and we will be happy to help.
> 
> We track this report status in https://linaro.atlassian.net/browse/GNU-1140 , please let us know if you are looking at the problem and/or when you have a fix.
> 
> In gcc_check master-arm after:
> 
>  | commit gcc-14-8680-g2f14c0dbb78
>  | Author: Roger Sayle <roger@nextmovesoftware.com>
>  | Date:   Thu Feb 1 06:10:42 2024 +0000
>  | 
>  |     PR target/113560: Enhance is_widening_mult_rhs_p.
>  |     
>  |     This patch resolves PR113560, a code quality regression from GCC12
>  |     affecting x86_64, by enhancing the middle-end's tree-ssa-math-opts.cc
>  |     to recognize more instances of widening multiplications.
>  |     
>  |     The widening multiplication perception code identifies cases like:
>  | ... 116 lines of the commit log omitted.
> 
> FAIL: 3 regressions
> 
> regressions.sum:
> === gcc tests ===
> 
> Running gcc:gcc.target/arm/arm.exp ...
> FAIL: gcc.target/arm/wmul-5.c scan-assembler umlal
> FAIL: gcc.target/arm/wmul-6.c scan-assembler smlalbb
> FAIL: gcc.target/arm/wmul-7.c scan-assembler umlal

Hi Roger,

Your patch seems to regress the above 3 tests for all 32-bit ARM targets (see [1]).  Would you please check if the regressions can be avoided?

For reference, here are configure options we use for arm-linux-gnueabihf cross-toolchain: [2].

[1] https://linaro.atlassian.net/browse/GNU-1140
[2] https://ci.linaro.org/job/tcwg_gnu_cross_check_gcc--master-arm-build/1303/artifact/artifacts/notify/configure-make.txt/*view*/ 

Thanks!

--
Maxim Kuvyrkov
https://www.linaro.org


> 
> 
> You can find the failure logs in *.log.1.xz files in
> - https://ci.linaro.org/job/tcwg_gcc_check--master-arm-build/1650/artifact/artifacts/00-sumfiles/
> The full lists of regressions and progressions as well as configure and make commands are in
> - https://ci.linaro.org/job/tcwg_gcc_check--master-arm-build/1650/artifact/artifacts/notify/
> The list of [ignored] baseline and flaky failures are in
> - https://ci.linaro.org/job/tcwg_gcc_check--master-arm-build/1650/artifact/artifacts/sumfiles/xfails.xfail
> 
> The configuration of this build is:
> CI config tcwg_gcc_check master-arm
> 
> -----------------8<--------------------------8<--------------------------8<--------------------------
> The information below can be used to reproduce a debug environment:
> 
> Current build   : https://ci.linaro.org/job/tcwg_gcc_check--master-arm-build/1650/artifact/artifacts
> Reference build : https://ci.linaro.org/job/tcwg_gcc_check--master-arm-build/1649/artifact/artifacts
> 
> Reproduce last good and first bad builds: https://git-us.linaro.org/toolchain/ci/interesting-commits.git/plain/gcc/sha1/2f14c0dbb789852947cb58fdf7d3162413f053fa/tcwg_gcc_check/master-arm/reproduction_instructions.txt
> 
> Full commit : https://github.com/gcc-mirror/gcc/commit/2f14c0dbb789852947cb58fdf7d3162413f053fa
> 
> List of configurations that regressed due to this commit :
> * tcwg_gcc_check
> ** master-arm
> *** FAIL: 3 regressions
> *** https://git-us.linaro.org/toolchain/ci/interesting-commits.git/plain/gcc/sha1/2f14c0dbb789852947cb58fdf7d3162413f053fa/tcwg_gcc_check/master-arm/details.txt
> *** https://ci.linaro.org/job/tcwg_gcc_check--master-arm-build/1650/artifact/artifacts