From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 428123858402 for ; Wed, 22 Dec 2021 16:15:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 428123858402 Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BMFsIJb011086; Wed, 22 Dec 2021 16:15:18 GMT Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com with ESMTP id 3d472s0djf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Dec 2021 16:15:17 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1BMG8odg003481; Wed, 22 Dec 2021 16:15:17 GMT Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by ppma03dal.us.ibm.com with ESMTP id 3d179bu5k9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Dec 2021 16:15:16 +0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1BMGFFxn20971858 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 22 Dec 2021 16:15:15 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 651E0C60BC; Wed, 22 Dec 2021 16:15:15 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4DA89C607D; Wed, 22 Dec 2021 16:15:14 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.211.110.94]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 22 Dec 2021 16:15:13 +0000 (GMT) Message-ID: <25103f22a93cbc1c3b6e40cd9ba919a3dbdfb3e3.camel@us.ibm.com> From: Carl Love To: Maxim Kuvyrkov , cel@us.ibm.com Cc: gcc-regression@gcc.gnu.org Date: Wed, 22 Dec 2021 08:14:59 -0800 In-Reply-To: References: <485385377.5313.1639722152898@jenkins.jenkins> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-16.el8) X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 6XeeB0D97MeHz2PK_OKm0ZIcX2Zfv6V0 X-Proofpoint-GUID: 6XeeB0D97MeHz2PK_OKm0ZIcX2Zfv6V0 Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 10 URL's were un-rewritten MIME-Version: 1.0 Subject: RE: [TCWG CI] Regression caused by binutils: gdb: Powerpc mark xfail in gdb.base/catch-syscall.exp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2021-12-22_07,2021-12-22_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1011 malwarescore=0 lowpriorityscore=0 mlxscore=0 priorityscore=1501 adultscore=0 impostorscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112220091 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_LOTSOFHASH, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-regression@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-regression mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Dec 2021 16:15:21 -0000 Maxim: Thanks for the email. I just wanted to double check with you if there is something that needs to be done. I have only had a chance to quickly look at the original email. It sounds like my patch is OK, just an issue with the CI. Note, I am traveling and only checking email occasionally. Thanks for your help with this. Carl On Tue, 2021-12-21 at 17:39 +0300, Maxim Kuvyrkov wrote: > Hi Carl, > > This was sent out due to a bug in our CI. Sorry for the noise. > > Regards, > > -- > Maxim Kuvyrkov > https://www.linaro.org > > > On 17 Dec 2021, at 09:22, ci_notify@linaro.org wrote: > > > > [TCWG CI] Regression caused by binutils: gdb: Powerpc mark xfail in > > gdb.base/catch-syscall.exp: > > commit 408db576c98b232de0b1a1ee3495bad0d1c704cf > > Author: Carl Love > > > > gdb: Powerpc mark xfail in gdb.base/catch-syscall.exp > > > > Results regressed to > > # reset_artifacts: > > -10 > > # build_abe binutils: > > -9 > > # build_abe stage1 -- --set gcc_override_configure=--disable- > > libsanitizer --set gcc_override_configure=--disable-multilib --set > > gcc_override_configure=--with-cpu=cortex-m4 --set > > gcc_override_configure=--with-mode=thumb --set > > gcc_override_configure=--with-float=hard: > > -8 > > # build_abe newlib: > > -6 > > # build_abe stage2 -- --set gcc_override_configure=--disable- > > libsanitizer --set gcc_override_configure=--disable-multilib --set > > gcc_override_configure=--with-cpu=cortex-m4 --set > > gcc_override_configure=--with-mode=thumb --set > > gcc_override_configure=--with-float=hard: > > -5 > > # benchmark -- -Os_LTO_mthumb artifacts/build- > > 408db576c98b232de0b1a1ee3495bad0d1c704cf/results_id: > > 1 > > > > from > > # reset_artifacts: > > -10 > > # build_abe binutils: > > -9 > > # build_abe stage1 -- --set gcc_override_configure=--disable- > > libsanitizer --set gcc_override_configure=--disable-multilib --set > > gcc_override_configure=--with-cpu=cortex-m4 --set > > gcc_override_configure=--with-mode=thumb --set > > gcc_override_configure=--with-float=hard: > > -8 > > # build_abe newlib: > > -6 > > # build_abe stage2 -- --set gcc_override_configure=--disable- > > libsanitizer --set gcc_override_configure=--disable-multilib --set > > gcc_override_configure=--with-cpu=cortex-m4 --set > > gcc_override_configure=--with-mode=thumb --set > > gcc_override_configure=--with-float=hard: > > -5 > > # benchmark -- -Os_LTO_mthumb artifacts/build-baseline/results_id: > > 1 > > > > THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, > > REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT. > > > > This commit has regressed these CI configurations: > > - tcwg_bmk_gnu_eabi_stm32/gnu_eabi-master-arm_eabi-coremark-Os_LTO > > > > First_bad build: > > https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/10/artifact/artifacts/build-408db576c98b232de0b1a1ee3495bad0d1c704cf/ > > > > Last_good build: > > https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/10/artifact/artifacts/build-e6582e1b3c194b01a2461f5c5326fcf358303607/ > > > > Baseline build: > > https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/10/artifact/artifacts/build-baseline/ > > > > Even more details: > > https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/10/artifact/artifacts/ > > > > > > Reproduce builds: > > > > mkdir investigate-binutils-408db576c98b232de0b1a1ee3495bad0d1c704cf > > cd investigate-binutils-408db576c98b232de0b1a1ee3495bad0d1c704cf > > > > # Fetch scripts > > git clone > > https://git.linaro.org/toolchain/jenkins-scripts > > > > > > # Fetch manifests and test.sh script > > mkdir -p artifacts/manifests > > curl -o artifacts/manifests/build-baseline.sh > > https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/10/artifact/artifacts/manifests/build-baseline.sh > > --fail > > curl -o artifacts/manifests/build-parameters.sh > > https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/10/artifact/artifacts/manifests/build-parameters.sh > > --fail > > curl -o artifacts/test.sh > > https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/10/artifact/artifacts/test.sh > > --fail > > chmod +x artifacts/test.sh > > > > # Reproduce the baseline build (build all pre-requisites) > > ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build- > > baseline.sh > > > > # Save baseline build state (which is then restored in > > artifacts/test.sh) > > mkdir -p ./bisect > > rsync -a --del --delete-excluded --exclude /bisect/ --exclude > > /artifacts/ --exclude /binutils/ ./ ./bisect/baseline/ > > > > cd binutils > > > > # Reproduce first_bad build > > git checkout --detach 408db576c98b232de0b1a1ee3495bad0d1c704cf > > ../artifacts/test.sh > > > > # Reproduce last_good build > > git checkout --detach e6582e1b3c194b01a2461f5c5326fcf358303607 > > ../artifacts/test.sh > > > > cd .. > > > > > > Full commit (up to 1000 lines): > > > > commit 408db576c98b232de0b1a1ee3495bad0d1c704cf > > Author: Carl Love > > Date: Mon Nov 29 16:28:42 2021 +0000 > > > > gdb: Powerpc mark xfail in gdb.base/catch-syscall.exp > > > > Powerpc is not reporting the > > > > Catchpoint 1 (returned from syscall execve), .... > > > > as expected. The issue appears to be with the kernel not > > returning the > > expected result. This patch marks the test failure as an xfail. > > > > Bug: > > https://sourceware.org/bugzilla/show_bug.cgi?id=28623 > > > > --- > > gdb/testsuite/gdb.base/catch-syscall.exp | 37 > > ++++++++++++++++++++++++++------ > > 1 file changed, 31 insertions(+), 6 deletions(-) > > > > diff --git a/gdb/testsuite/gdb.base/catch-syscall.exp > > b/gdb/testsuite/gdb.base/catch-syscall.exp > > index cdd5e2aec47..b0d524c1a03 100644 > > --- a/gdb/testsuite/gdb.base/catch-syscall.exp > > +++ b/gdb/testsuite/gdb.base/catch-syscall.exp > > @@ -127,7 +127,28 @@ proc check_return_from_syscall { syscall { > > pattern "" } } { > > } > > > > set thistest "syscall $syscall has returned" > > - gdb_test "continue" "Catchpoint $decimal \\(returned from > > syscall ${pattern}\\).*" $thistest > > + if { $pattern eq "execve" } { > > + gdb_test_multiple "continue" $thistest { > > + -re -wrap "Catchpoint $decimal \\(returned from syscall > > ${pattern}\\).*" { > > + pass $thistest > > + return 1 > > + } > > + -re -wrap ".*Breakpoint $decimal, main .*" { > > + # On Powerpc the kernel does not report the returned > > from > > + # syscall as expected by the test. GDB bugzilla 28623. > > + if { [istarget "powerpc64*-linux*"] } { > > + xfail $thistest > > + } else { > > + fail $thistest > > + } > > + return 0 > > + } > > + } > > + > > + } else { > > + gdb_test "continue" "Catchpoint $decimal \\(returned from > > syscall ${pattern}\\).*" $thistest > > + return 1 > > + } > > } > > > > # Internal procedure that performs two 'continue' commands and > > checks if > > @@ -142,7 +163,7 @@ proc check_continue { syscall { pattern "" } } > > { > > # Testing if the inferior has called the syscall. > > check_call_to_syscall $syscall $pattern > > # And now, that the syscall has returned. > > - check_return_from_syscall $syscall $pattern > > + return [check_return_from_syscall $syscall $pattern] > > } > > > > # Inserts a syscall catchpoint with an argument. > > @@ -348,11 +369,15 @@ proc test_catch_syscall_execve {} { > > # Check for entry/return across the execve, making sure that > > the > > # syscall_state isn't lost when turning into a new process. > > insert_catch_syscall_with_arg "execve" > > - check_continue "execve" > > + if [check_continue "execve"] { > > + # The check_continue test generates an XFAIL on > > Powerpc. In > > + # that case, gdb is already at main so don't do the > > continue. > > + > > > > - # Continue to main so extended-remote can read files as needed. > > - # (Otherwise that "Reading" output confuses > > gdb_continue_to_end.) > > - gdb_continue "main" > > + # Continue to main so extended-remote can read files as > > needed. > > + # (Otherwise that "Reading" output confuses > > gdb_continue_to_end.) > > + gdb_continue "main" > > + } > > > > # Now can we finish? > > check_for_program_end > >