From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by sourceware.org (Postfix) with ESMTPS id 987383858C2C for ; Tue, 21 Dec 2021 14:31:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 987383858C2C Received: by mail-lj1-x234.google.com with SMTP id b19so21624854ljr.12 for ; Tue, 21 Dec 2021 06:31:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=sr5whKoJ3YXGhGs0G7Iam8FcVCje3UYMMMXHxN0BT7E=; b=AopL3p4hoIj0z4BTrXboX+pM9HmZp3PDPBi78QYcrD1fd8WnTcuP09dQsBZnC4TQbV hEONuCu+2NtBMyUjnqgWns3KoW9AyO5sXhW7l/CqUJZeZQrlMQZjy0fH5XTgVJyKnwvu 86KYTfEHdxOz1bD0Shexcsxv6GQA82oLkw5HPbD9F7oJhSWZrHJCgneU/pcamZyDC0SP JNtBcDW9HOms5JU3/XPchDSBTzwG2DMzjv+z/pCF2C7aMkoaTZefNs0xM31RjEDMNJpz fbiE+AcB9/845XBXV5zAyDKtFk1NqjRA+Yr+nijFHTwwrrU2Jrl6NyhvjaWwODykwUKJ 3/8g== X-Gm-Message-State: AOAM5316EKXrsfJuksUcVdy7HLzmdfjVbqjymt1yvXSD20FBkC0MSNgC 6ZgEcRG0cJmU3Z20s185u7wh X-Google-Smtp-Source: ABdhPJxWEP4sTGf2a6V6x4BJ1+saiPUNJcIWQv9trFC10HZAG+V5kF1Mc573uhCBKJ7KCmEJ4vL1/A== X-Received: by 2002:a05:651c:154a:: with SMTP id y10mr2677258ljp.314.1640097074308; Tue, 21 Dec 2021 06:31:14 -0800 (PST) Received: from [192.168.0.135] ([185.30.228.158]) by smtp.gmail.com with ESMTPSA id w23sm2730518lfa.191.2021.12.21.06.31.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Dec 2021 06:31:13 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: [TCWG CI] Regression caused by gcc: Add new constant data structure. From: Maxim Kuvyrkov In-Reply-To: Date: Tue, 21 Dec 2021 17:31:13 +0300 Cc: gcc-regression@gcc.gnu.org Content-Transfer-Encoding: quoted-printable Message-Id: <493E5005-98F5-4327-80B0-4DDBB6352F94@linaro.org> References: <881183432.5892.1639861927052@jenkins.jenkins> To: Michael Meissner X-Mailer: Apple Mail (2.3608.120.23.2.7) X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-regression@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-regression mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Dec 2021 14:31:17 -0000 Hi Michael, This was sent out due to a bug in our CI. Sorry for the noise. > On 20 Dec 2021, at 09:46, Michael Meissner via Gcc-regression = wrote: >=20 > On Sat, Dec 18, 2021 at 09:12:06PM +0000, ci_notify@linaro.org wrote: >> [TCWG CI] Regression caused by gcc: Add new constant data structure.: >> commit c6756b3bc1d2af1c8e86f0ad1711e9b9134520ba >> Author: Michael Meissner >>=20 >> Add new constant data structure. >>=20 ... >=20 > Given the files that I changed were in the config/rs6000 directory, = and you are > building an arm toolchain, I don't see how this particular change = broke your > build. I believe that it must have been one of the changes after my = particular > commit that broke your build. You should really list all of the = commits that > occurred between your last sucessful build and the failure. This CI bisects performance problems down to a single commit. Due to a = bug in script that compares two sets of results it thought that your = patch increased code-size of CoreMark. >=20 > Also, it was nearly impossible to trace through the build to find what = really > caused the error. Because this report was due to a bug it didn=E2=80=99t have the actual = details on code-size regression (no surprise, since there was no = regression :-) ). Here=E2=80=99s an example of a proper recent report: = https://gcc.gnu.org/pipermail/gcc-regression/2021-December/076034.html . Regards, -- Maxim Kuvyrkov https://www.linaro.org >=20 >> Full commit (up to 1000 lines): >> >> commit c6756b3bc1d2af1c8e86f0ad1711e9b9134520ba >> Author: Michael Meissner >> Date: Wed Dec 15 00:56:25 2021 -0500 >>=20 >> Add new constant data structure. >>=20 >> This patch provides the data structure and function to convert a >> CONST_INT, CONST_DOUBLE, CONST_VECTOR, or VEC_DUPLICATE of a = constant) to >> an array of bytes, half-words, words, and double words that can = be loaded >> into a 128-bit vector register. >>=20 >> The next patches will use this data structure to generate code = that >> generates load of the vector/floating point registers using the = XXSPLTIDP, >> XXSPLTIW, and LXVKQ instructions that were added in power10. >>=20 >> 2021-12-15 Michael Meissner >>=20 >> gcc/ >>=20 >> * config/rs6000/rs6000-protos.h (VECTOR_128BIT_BITS): New = macro. >> (VECTOR_128BIT_BYTES): Likewise. >> (VECTOR_128BIT_HALF_WORDS): Likewise. >> (VECTOR_128BIT_WORDS): Likewise. >> (VECTOR_128BIT_DOUBLE_WORDS): Likewise. >> (vec_const_128bit_type): New structure type. >> (vec_const_128bit_to_bytes): New declaration. >> * config/rs6000/rs6000.c (constant_int_to_128bit_vector): = New >> helper function. >> (constant_fp_to_128bit_vector): New helper function. >> (vec_const_128bit_to_bytes): New function. >=20 > --=20 > Michael Meissner, IBM > PO Box 98, Ayer, Massachusetts, USA, 01432 > email: meissner@linux.ibm.com