From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by sourceware.org (Postfix) with ESMTPS id 411273858C2C for ; Tue, 21 Dec 2021 14:20:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 411273858C2C Received: by mail-lf1-x136.google.com with SMTP id x21so21476620lfa.5 for ; Tue, 21 Dec 2021 06:20:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=4Fl7Ri0bqn/yxsIUFsFV7M21K9aTORJyZyOFFi+Oui0=; b=k5Gn7d9W06m/nRiKtzc0xK9CVlCngrIEo7KEhBwYBQTg2AyVcMrSjY70GoEAGNJxv9 tXrGISD32n/GFshlmYKppXwI0+M5hMBmNwXdmAxhMRKVwaQb+7NfSGznudYxfREZm141 wlUosrrEgUp0Ig28UYNyh/SR3ztXU2fQ1NBTwMrExdeGomcNKveNGt/g+tUTdX6Xita8 u1KlIrNDCMnGcY7vEyWKkYNUpPFYMHZi5DlabbJegoAbLCgHvjM1ADKwWCgH6+HkJYhV aibfocoeNNTwTAlsEovACK+vWZNfPI55HianhFUtCMvT8TdQk4c46SxQQ84RopytpMrt dwxg== X-Gm-Message-State: AOAM5308z2qXRLhW9gBPAC/Izf979l7rgOpqcQ4x+w7MC2Ql2LkMIYde TZ93mvapUmXC9rDpNLRZZvoIeLCDOPDs X-Google-Smtp-Source: ABdhPJzCe4RMb7+gJ3YegXf6lQkNZEh/IOEkwlbQv4l5Rg3A58AAEx+ABRkhYUYRj4cn/oKp66fIDQ== X-Received: by 2002:a05:6512:ea3:: with SMTP id bi35mr3323175lfb.510.1640096424845; Tue, 21 Dec 2021 06:20:24 -0800 (PST) Received: from [192.168.0.135] ([185.30.228.158]) by smtp.gmail.com with ESMTPSA id e17sm2725261lfr.296.2021.12.21.06.20.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Dec 2021 06:20:24 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: [TCWG CI] Regression caused by gcc: For -foffload= suggest also 'disable' and 'default' [PR103644] From: Maxim Kuvyrkov In-Reply-To: <637115673.6287.1639989206830@jenkins.jenkins> Date: Tue, 21 Dec 2021 17:20:24 +0300 Cc: gcc-regression@gcc.gnu.org Content-Transfer-Encoding: quoted-printable Message-Id: <6A6ECEE0-BFC9-404E-9919-DC07BDB9358A@linaro.org> References: <637115673.6287.1639989206830@jenkins.jenkins> To: Tobias Burnus X-Mailer: Apple Mail (2.3608.120.23.2.7) X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_LOTSOFHASH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-regression@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-regression mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Dec 2021 14:20:28 -0000 Hi Tobias, This was sent out due to a bug in our CI. Sorry for the noise. Regards, -- Maxim Kuvyrkov https://www.linaro.org > On 20 Dec 2021, at 11:33, ci_notify@linaro.org wrote: >=20 > [TCWG CI] Regression caused by gcc: For -foffload=3D suggest also = 'disable' and 'default' [PR103644]: > commit 2c1ac0bf3d44e4ca6e32533d8b498c7d1dbd2425 > Author: Tobias Burnus >=20 > For -foffload=3D suggest also 'disable' and 'default' [PR103644] >=20 > Results regressed to > # reset_artifacts: > -10 > # build_abe binutils: > -9 > # build_abe stage1 -- --set = gcc_override_configure=3D--disable-libsanitizer --set = gcc_override_configure=3D--disable-multilib --set = gcc_override_configure=3D--with-cpu=3Dcortex-m4 --set = gcc_override_configure=3D--with-mode=3Dthumb --set = gcc_override_configure=3D--with-float=3Dhard: > -8 > # build_abe newlib: > -6 > # build_abe stage2 -- --set = gcc_override_configure=3D--disable-libsanitizer --set = gcc_override_configure=3D--disable-multilib --set = gcc_override_configure=3D--with-cpu=3Dcortex-m4 --set = gcc_override_configure=3D--with-mode=3Dthumb --set = gcc_override_configure=3D--with-float=3Dhard: > -5 > # benchmark -- -O2_mthumb = artifacts/build-2c1ac0bf3d44e4ca6e32533d8b498c7d1dbd2425/results_id: > 1 >=20 > from > # reset_artifacts: > -10 > # build_abe binutils: > -9 > # build_abe stage1 -- --set = gcc_override_configure=3D--disable-libsanitizer --set = gcc_override_configure=3D--disable-multilib --set = gcc_override_configure=3D--with-cpu=3Dcortex-m4 --set = gcc_override_configure=3D--with-mode=3Dthumb --set = gcc_override_configure=3D--with-float=3Dhard: > -8 > # build_abe newlib: > -6 > # build_abe stage2 -- --set = gcc_override_configure=3D--disable-libsanitizer --set = gcc_override_configure=3D--disable-multilib --set = gcc_override_configure=3D--with-cpu=3Dcortex-m4 --set = gcc_override_configure=3D--with-mode=3Dthumb --set = gcc_override_configure=3D--with-float=3Dhard: > -5 > # benchmark -- -O2_mthumb artifacts/build-baseline/results_id: > 1 >=20 > THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, = REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT. >=20 > This commit has regressed these CI configurations: > - tcwg_bmk_gnu_eabi_stm32/gnu_eabi-master-arm_eabi-coremark-O2 >=20 > First_bad build: = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-O2/7/artifact/artifacts/build-2c1ac0bf3d44e4c= a6e32533d8b498c7d1dbd2425/ > Last_good build: = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-O2/7/artifact/artifacts/build-ab18659afc05443= 4cef4d4757a3519f1100adc52/ > Baseline build: = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-O2/7/artifact/artifacts/build-baseline/ > Even more details: = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-O2/7/artifact/artifacts/ >=20 > Reproduce builds: > > mkdir investigate-gcc-2c1ac0bf3d44e4ca6e32533d8b498c7d1dbd2425 > cd investigate-gcc-2c1ac0bf3d44e4ca6e32533d8b498c7d1dbd2425 >=20 > # Fetch scripts > git clone https://git.linaro.org/toolchain/jenkins-scripts >=20 > # Fetch manifests and test.sh script > mkdir -p artifacts/manifests > curl -o artifacts/manifests/build-baseline.sh = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-O2/7/artifact/artifacts/manifests/build-basel= ine.sh --fail > curl -o artifacts/manifests/build-parameters.sh = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-O2/7/artifact/artifacts/manifests/build-param= eters.sh --fail > curl -o artifacts/test.sh = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-O2/7/artifact/artifacts/test.sh --fail > chmod +x artifacts/test.sh >=20 > # Reproduce the baseline build (build all pre-requisites) > ./jenkins-scripts/tcwg_bmk-build.sh @@ = artifacts/manifests/build-baseline.sh >=20 > # Save baseline build state (which is then restored in = artifacts/test.sh) > mkdir -p ./bisect > rsync -a --del --delete-excluded --exclude /bisect/ --exclude = /artifacts/ --exclude /gcc/ ./ ./bisect/baseline/ >=20 > cd gcc >=20 > # Reproduce first_bad build > git checkout --detach 2c1ac0bf3d44e4ca6e32533d8b498c7d1dbd2425 > ../artifacts/test.sh >=20 > # Reproduce last_good build > git checkout --detach ab18659afc054434cef4d4757a3519f1100adc52 > ../artifacts/test.sh >=20 > cd .. > >=20 > Full commit (up to 1000 lines): > > commit 2c1ac0bf3d44e4ca6e32533d8b498c7d1dbd2425 > Author: Tobias Burnus > Date: Thu Dec 16 11:19:37 2021 +0100 >=20 > For -foffload=3D suggest also 'disable' and 'default' [PR103644] >=20 > gcc/ChangeLog: >=20 > PR driver/103644 > * gcc.c (check_offload_target_name): Add 'default' and = 'disable' > to the candidate list. > --- > gcc/gcc.c | 25 ++++++++++++------------- > 1 file changed, 12 insertions(+), 13 deletions(-) >=20 > diff --git a/gcc/gcc.c b/gcc/gcc.c > index 694c2573109..b75b50b87b2 100644 > --- a/gcc/gcc.c > +++ b/gcc/gcc.c > @@ -4017,26 +4017,25 @@ check_offload_target_name (const char *target, = ptrdiff_t len) > memcpy (cand, OFFLOAD_TARGETS, olen); > for (c =3D strtok (cand, ","); c; c =3D strtok (NULL, ",")) > candidates.safe_push (c); > + candidates.safe_push ("default"); > + candidates.safe_push ("disable"); >=20 > char *target2 =3D XALLOCAVEC (char, len + 1); > memcpy (target2, target, len); > target2[len] =3D '\0'; >=20 > - error ("GCC is not configured to support %qs as offload = target", target2); > + error ("GCC is not configured to support %qs as %<-foffload=3D%> = argument", > + target2); >=20 > - if (candidates.is_empty ()) > - inform (UNKNOWN_LOCATION, "no offloading targets configured"); > + char *s; > + const char *hint =3D candidates_list_and_hint (target2, s, = candidates); > + if (hint) > + inform (UNKNOWN_LOCATION, > + "valid %<-foffload=3D%> arguments are: %s; " > + "did you mean %qs?", s, hint); > else > - { > - char *s; > - const char *hint =3D candidates_list_and_hint (target2, s, = candidates); > - if (hint) > - inform (UNKNOWN_LOCATION, > - "valid offload targets are: %s; did you mean %qs?", = s, hint); > - else > - inform (UNKNOWN_LOCATION, "valid offload targets are: %s", = s); > - XDELETEVEC (s); > - } > + inform (UNKNOWN_LOCATION, "valid %<-foffload=3D%> arguments are: = %s", s); > + XDELETEVEC (s); > return false; > } > return true; >