public inbox for gcc-regression@sourceware.org help / color / mirror / Atom feed
From: ci_notify@linaro.org To: Alan Modra <amodra@gmail.com> Cc: gcc-regression@gcc.gnu.org Subject: [TCWG CI] Regression caused by binutils: XCOFF C_STSYM test failure on 32-bit host Date: Sat, 18 Dec 2021 17:17:32 +0000 (UTC) [thread overview] Message-ID: <775344759.5837.1639847853824@jenkins.jenkins> (raw) [TCWG CI] Regression caused by binutils: XCOFF C_STSYM test failure on 32-bit host: commit eda0ddeb26a117660f3c0f54572053117641c2c3 Author: Alan Modra <amodra@gmail.com> XCOFF C_STSYM test failure on 32-bit host Results regressed to # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard: -8 # build_abe newlib: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard: -5 # benchmark -- -O2_LTO_mthumb artifacts/build-eda0ddeb26a117660f3c0f54572053117641c2c3/results_id: 1 from # reset_artifacts: -10 # build_abe binutils: -9 # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard: -8 # build_abe newlib: -6 # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard: -5 # benchmark -- -O2_LTO_mthumb artifacts/build-baseline/results_id: 1 THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT. This commit has regressed these CI configurations: - tcwg_bmk_gnu_eabi_stm32/gnu_eabi-master-arm_eabi-coremark-O2_LTO First_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O2_LTO/13/artifact/artifacts/build-eda0ddeb26a117660f3c0f54572053117641c2c3/ Last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O2_LTO/13/artifact/artifacts/build-237f6eac1577223034a3e3436bd270428d097534/ Baseline build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O2_LTO/13/artifact/artifacts/build-baseline/ Even more details: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O2_LTO/13/artifact/artifacts/ Reproduce builds: <cut> mkdir investigate-binutils-eda0ddeb26a117660f3c0f54572053117641c2c3 cd investigate-binutils-eda0ddeb26a117660f3c0f54572053117641c2c3 # Fetch scripts git clone https://git.linaro.org/toolchain/jenkins-scripts # Fetch manifests and test.sh script mkdir -p artifacts/manifests curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O2_LTO/13/artifact/artifacts/manifests/build-baseline.sh --fail curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O2_LTO/13/artifact/artifacts/manifests/build-parameters.sh --fail curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O2_LTO/13/artifact/artifacts/test.sh --fail chmod +x artifacts/test.sh # Reproduce the baseline build (build all pre-requisites) ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh # Save baseline build state (which is then restored in artifacts/test.sh) mkdir -p ./bisect rsync -a --del --delete-excluded --exclude /bisect/ --exclude /artifacts/ --exclude /binutils/ ./ ./bisect/baseline/ cd binutils # Reproduce first_bad build git checkout --detach eda0ddeb26a117660f3c0f54572053117641c2c3 ../artifacts/test.sh # Reproduce last_good build git checkout --detach 237f6eac1577223034a3e3436bd270428d097534 ../artifacts/test.sh cd .. </cut> Full commit (up to 1000 lines): <cut> commit eda0ddeb26a117660f3c0f54572053117641c2c3 Author: Alan Modra <amodra@gmail.com> Date: Tue Dec 14 21:13:21 2021 +1030 XCOFF C_STSYM test failure on 32-bit host This test was failing here and on another similar symbol: [ 4](sec 1)(fl 0x00)(ty 0)(scl 143) (nx 0) 0x05d1745d11745d21 .bs where correct output is [ 4](sec 1)(fl 0x00)(ty 0)(scl 143) (nx 0) 0x000000000000000a .bs The problem is caused by a 32-bit host pointer being sign-extended when stored into a 64-bit bfd_vma, and then that value not being trimmed back to 32 bits when used. The following belt-and-braces patch fixes both the store and subsequent reads. * coffcode.h (coff_slurp_symbol_table): Do not sign extend when storing a host pointer to syment.n_value. * coffgen.c (coff_get_symbol_info): Cast syment.n_value to a bfd_hostptr_t before using in arithmetic. (coff_print_symbol): Likewise. --- bfd/coffcode.h | 4 ++-- bfd/coffgen.c | 11 ++++++----- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/bfd/coffcode.h b/bfd/coffcode.h index e2b256648ad..4405c9fe5ea 100644 --- a/bfd/coffcode.h +++ b/bfd/coffcode.h @@ -4826,8 +4826,8 @@ coff_slurp_symbol_table (bfd * abfd) /* The value is actually a symbol index. Save a pointer to the symbol instead of the index. FIXME: This should use a union. */ - src->u.syment.n_value = - (long) (intptr_t) (native_symbols + src->u.syment.n_value); + src->u.syment.n_value + = (bfd_hostptr_t) (native_symbols + src->u.syment.n_value); dst->symbol.value = src->u.syment.n_value; src->fix_value = 1; break; diff --git a/bfd/coffgen.c b/bfd/coffgen.c index 5474f6c24d8..5681af1b621 100644 --- a/bfd/coffgen.c +++ b/bfd/coffgen.c @@ -2130,10 +2130,10 @@ coff_get_symbol_info (bfd *abfd, asymbol *symbol, symbol_info *ret) if (coffsymbol (symbol)->native != NULL && coffsymbol (symbol)->native->fix_value && coffsymbol (symbol)->native->is_sym) - ret->value = - ((coffsymbol (symbol)->native->u.syment.n_value - - (bfd_hostptr_t) obj_raw_syments (abfd)) - / sizeof (combined_entry_type)); + ret->value + = (((bfd_hostptr_t) coffsymbol (symbol)->native->u.syment.n_value + - (bfd_hostptr_t) obj_raw_syments (abfd)) + / sizeof (combined_entry_type)); } /* Print out information about COFF symbol. */ @@ -2181,7 +2181,8 @@ coff_print_symbol (bfd *abfd, if (! combined->fix_value) val = (bfd_vma) combined->u.syment.n_value; else - val = ((combined->u.syment.n_value - (bfd_hostptr_t) root) + val = (((bfd_hostptr_t) combined->u.syment.n_value + - (bfd_hostptr_t) root) / sizeof (combined_entry_type)); fprintf (file, "(sec %2d)(fl 0x%02x)(ty %3x)(scl %3d) (nx %d) 0x", </cut> >From hjl@sc.intel.com Sat Dec 18 18:48:14 2021 Return-Path: <hjl@sc.intel.com> X-Original-To: gcc-regression@gcc.gnu.org Delivered-To: gcc-regression@gcc.gnu.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by sourceware.org (Postfix) with ESMTPS id C4A4F3858C27 for <gcc-regression@gcc.gnu.org>; Sat, 18 Dec 2021 18:48:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C4A4F3858C27 X-IronPort-AV: E=McAfee;i="6200,9189,10202"; a="239894271" X-IronPort-AV: E=Sophos;i="5.88,216,1635231600"; d="scan'208";a="239894271" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2021 10:48:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,216,1635231600"; d="scan'208";a="615918448" Received: from scymds01.sc.intel.com ([10.148.94.138]) by orsmga004.jf.intel.com with ESMTP; 18 Dec 2021 10:48:11 -0800 Received: from gnu-ivb-1.sc.intel.com (gnu-ivb-1.sc.intel.com [172.25.70.227]) by scymds01.sc.intel.com with ESMTP id 1BIImBoM009659; Sat, 18 Dec 2021 10:48:11 -0800 Received: by gnu-ivb-1.sc.intel.com (Postfix, from userid 1000) id 5B78712004D; Sat, 18 Dec 2021 10:48:11 -0800 (PST) Date: Sat, 18 Dec 2021 10:48:11 -0800 To: skpgkp2@gmail.com, hjl.tools@gmail.com, gcc-regression@gcc.gnu.org Subject: Regressions on master at commit r12-6058 vs commit r12-6053 on Linux/i686 User-Agent: Heirloom mailx 12.5 7/5/10 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20211218184811.5B78712004D@gnu-ivb-1.sc.intel.com> From: "H.J. Lu" <hjl@sc.intel.com> X-Spam-Status: No, score=-3468.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_NUMSUBJECT, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-regression@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-regression mailing list <gcc-regression.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-regression>, <mailto:gcc-regression-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-regression/> List-Post: <mailto:gcc-regression@gcc.gnu.org> List-Help: <mailto:gcc-regression-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-regression>, <mailto:gcc-regression-request@gcc.gnu.org?subject=subscribe> X-List-Received-Date: Sat, 18 Dec 2021 18:48:14 -0000 New failures: New passes: FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -O1 FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -O2 FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -O2 -flto -fno-use-linker-plugin -flto-partition=none FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -O3 -g FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -Og -g FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -Os FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -O1 FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -O2 FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -O2 -flto -fno-use-linker-plugin -flto-partition=none FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -O3 -g FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -Og -g FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -Os FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -O1 FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -O2 FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -O2 -flto -fno-use-linker-plugin -flto-partition=none FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -O3 -g FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -Og -g FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -Os FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -O1 FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -O2 FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -O2 -flto -fno-use-linker-plugin -flto-partition=none FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -O3 -g FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -Og -g FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -Os FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -O1 FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -O2 FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -O2 -flto -fno-use-linker-plugin -flto-partition=none FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -O3 -g FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -Og -g FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -Os FAIL: gcc.dg/builtin-dynamic-object-size-1.c execution test FAIL: gcc.dg/builtin-dynamic-object-size-2.c execution test FAIL: gcc.dg/builtin-object-size-1.c execution test FAIL: gcc.dg/builtin-object-size-2.c execution test
next reply other threads:[~2021-12-18 17:17 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-18 17:17 ci_notify [this message] [not found] ` <Yb6/sV1dkhNSRWdH@squeak.grove.modra.org> 2021-12-21 14:32 ` Maxim Kuvyrkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=775344759.5837.1639847853824@jenkins.jenkins \ --to=ci_notify@linaro.org \ --cc=amodra@gmail.com \ --cc=gcc-regression@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).