From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by sourceware.org (Postfix) with ESMTPS id A6FF23858421 for ; Tue, 21 Dec 2021 14:37:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A6FF23858421 Received: by mail-lj1-x22f.google.com with SMTP id bn20so21746226ljb.8 for ; Tue, 21 Dec 2021 06:37:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=2SxvsAziZh4DBhlJNlQYMuYLtYP3dJN/zdddkrPfUOs=; b=zx4Y4kY0eoxg5sEezEUxD0Qjyu+nCxCicdgBQodgaFWGeqv1806By+DT+6tDkvh2KR jpvKR/vvlwixgMWF60yl+QyQc+Kc2Q/2FOMXYNPo21OmgI4sofm8x6ZwzCSclkrH0vg2 m1yey6dbYjBBBhclrDk33s5IAE/+cNGasc5nwGdr/L03vjG3s+Vsst80ltMXgJbcHaX2 JghL9eJkFfjTDzAgWh09HWdR1XNhq0TqlDLWAoe/6sR7zRGN2pPqLvn+TpUjdepMouyD LM6in7kulVd4Zffvbb7FPYFBnxqKipmPZ4ignLZULO7S9YrhDrlPF+yqAqPF0xGONrei Rxqw== X-Gm-Message-State: AOAM533Bal2V7NzbtDKzJlPDMfekXlEJUsmNpPaj7xBMTKCV22Yq8EG6 skCCQuq4zlnly6Q/RzyljXhme8L/fm9t X-Google-Smtp-Source: ABdhPJx/kcnpLe/tJvLZ6MkGYWzRZ2cem87BRh/3MMrZVYKu2pq2usl7lj6sRelJz0P76JkANmZd7w== X-Received: by 2002:a2e:7819:: with SMTP id t25mr2782850ljc.374.1640097473943; Tue, 21 Dec 2021 06:37:53 -0800 (PST) Received: from [192.168.0.135] ([185.30.228.158]) by smtp.gmail.com with ESMTPSA id cf18sm1855776lfb.251.2021.12.21.06.37.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Dec 2021 06:37:53 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: [TCWG CI] Regression caused by gcc: Adjust 'gfortran.dg/goacc/privatization-1-*' [PR103576, PR103697] From: Maxim Kuvyrkov In-Reply-To: <2049980274.5596.1639790175925@jenkins.jenkins> Date: Tue, 21 Dec 2021 17:37:53 +0300 Cc: gcc-regression@gcc.gnu.org Content-Transfer-Encoding: quoted-printable Message-Id: <7CAD58A5-888D-4A05-9E69-D9DC77541A73@linaro.org> References: <2049980274.5596.1639790175925@jenkins.jenkins> To: Thomas Schwinge X-Mailer: Apple Mail (2.3608.120.23.2.7) X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_LOTSOFHASH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-regression@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-regression mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Dec 2021 14:37:59 -0000 Hi Thomas, This was sent out due to a bug in our CI. Sorry for the noise. Regards, -- Maxim Kuvyrkov https://www.linaro.org > On 18 Dec 2021, at 04:16, ci_notify@linaro.org wrote: >=20 > [TCWG CI] Regression caused by gcc: Adjust = 'gfortran.dg/goacc/privatization-1-*' [PR103576, PR103697]: > commit 228d64af4e244faabab5c47506920a1bde85d74e > Author: Thomas Schwinge >=20 > Adjust 'gfortran.dg/goacc/privatization-1-*' [PR103576, PR103697] >=20 > Results regressed to > # reset_artifacts: > -10 > # build_abe binutils: > -9 > # build_abe stage1 -- --set = gcc_override_configure=3D--disable-libsanitizer --set = gcc_override_configure=3D--disable-multilib --set = gcc_override_configure=3D--with-cpu=3Dcortex-m4 --set = gcc_override_configure=3D--with-mode=3Dthumb --set = gcc_override_configure=3D--with-float=3Dhard: > -8 > # build_abe newlib: > -6 > # build_abe stage2 -- --set = gcc_override_configure=3D--disable-libsanitizer --set = gcc_override_configure=3D--disable-multilib --set = gcc_override_configure=3D--with-cpu=3Dcortex-m4 --set = gcc_override_configure=3D--with-mode=3Dthumb --set = gcc_override_configure=3D--with-float=3Dhard: > -5 > # benchmark -- -O3_LTO_mthumb = artifacts/build-228d64af4e244faabab5c47506920a1bde85d74e/results_id: > 1 >=20 > from > # reset_artifacts: > -10 > # build_abe binutils: > -9 > # build_abe stage1 -- --set = gcc_override_configure=3D--disable-libsanitizer --set = gcc_override_configure=3D--disable-multilib --set = gcc_override_configure=3D--with-cpu=3Dcortex-m4 --set = gcc_override_configure=3D--with-mode=3Dthumb --set = gcc_override_configure=3D--with-float=3Dhard: > -8 > # build_abe newlib: > -6 > # build_abe stage2 -- --set = gcc_override_configure=3D--disable-libsanitizer --set = gcc_override_configure=3D--disable-multilib --set = gcc_override_configure=3D--with-cpu=3Dcortex-m4 --set = gcc_override_configure=3D--with-mode=3Dthumb --set = gcc_override_configure=3D--with-float=3Dhard: > -5 > # benchmark -- -O3_LTO_mthumb artifacts/build-baseline/results_id: > 1 >=20 > THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, = REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT. >=20 > This commit has regressed these CI configurations: > - tcwg_bmk_gnu_eabi_stm32/gnu_eabi-master-arm_eabi-coremark-O3_LTO >=20 > First_bad build: = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts/build-228d64af4e= 244faabab5c47506920a1bde85d74e/ > Last_good build: = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts/build-7f1239cb43= fad3293cf5bcd3678d1cba128d04c6/ > Baseline build: = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts/build-baseline/ > Even more details: = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts/ >=20 > Reproduce builds: > > mkdir investigate-gcc-228d64af4e244faabab5c47506920a1bde85d74e > cd investigate-gcc-228d64af4e244faabab5c47506920a1bde85d74e >=20 > # Fetch scripts > git clone https://git.linaro.org/toolchain/jenkins-scripts >=20 > # Fetch manifests and test.sh script > mkdir -p artifacts/manifests > curl -o artifacts/manifests/build-baseline.sh = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts/manifests/build-= baseline.sh --fail > curl -o artifacts/manifests/build-parameters.sh = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts/manifests/build-= parameters.sh --fail > curl -o artifacts/test.sh = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts/test.sh --fail > chmod +x artifacts/test.sh >=20 > # Reproduce the baseline build (build all pre-requisites) > ./jenkins-scripts/tcwg_bmk-build.sh @@ = artifacts/manifests/build-baseline.sh >=20 > # Save baseline build state (which is then restored in = artifacts/test.sh) > mkdir -p ./bisect > rsync -a --del --delete-excluded --exclude /bisect/ --exclude = /artifacts/ --exclude /gcc/ ./ ./bisect/baseline/ >=20 > cd gcc >=20 > # Reproduce first_bad build > git checkout --detach 228d64af4e244faabab5c47506920a1bde85d74e > ../artifacts/test.sh >=20 > # Reproduce last_good build > git checkout --detach 7f1239cb43fad3293cf5bcd3678d1cba128d04c6 > ../artifacts/test.sh >=20 > cd .. > >=20 > Full commit (up to 1000 lines): > > commit 228d64af4e244faabab5c47506920a1bde85d74e > Author: Thomas Schwinge > Date: Tue Dec 14 07:03:52 2021 +0100 >=20 > Adjust 'gfortran.dg/goacc/privatization-1-*' [PR103576, PR103697] >=20 > ... for the recent commit 494ebfa7c9aacaeb6ec1fccc47a0e49f31eb2bb8 > "Fortran: Handle compare in OpenMP atomic", which changes the = GIMPLE IR > such that a temporary is no longer used; 'original' dump: >=20 > x =3D *a; > - { > - integer(kind=3D4) D.4237; > - > - D.4237 =3D *a; > #pragma omp atomic relaxed > - &y =3D D.4237; > - } > + &y =3D *a; > } >=20 > (I'm not familiar to comment whether that's correct; but it appears = that the > difference again disappears in later compiler passes.) >=20 > These OpenACC test cases verify behavior re OpenACC privatization = levels, and > have to be adjusted accordingly. >=20 > gcc/testsuite/ > PR fortran/103576 > PR testsuite/103697 > * gfortran.dg/goacc/privatization-1-compute-loop.f90: = Adjust. > * gfortran.dg/goacc/privatization-1-compute.f90: Likewise. > * gfortran.dg/goacc/privatization-1-routine_gang-loop.f90: > Likewise. > * gfortran.dg/goacc/privatization-1-routine_gang.f90: = Likewise. > --- > gcc/testsuite/gfortran.dg/goacc/privatization-1-compute-loop.f90 = | 1 - > gcc/testsuite/gfortran.dg/goacc/privatization-1-compute.f90 = | 1 - > gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang-loop.f90 = | 1 - > gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang.f90 = | 1 - > 4 files changed, 4 deletions(-) >=20 > diff --git = a/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute-loop.f90 = b/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute-loop.f90 > index bcd7159ae5b..47ba5baf439 100644 > --- a/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute-loop.f90 > +++ b/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute-loop.f90 > @@ -50,7 +50,6 @@ contains > ! { dg-note {variable 'x' in 'private' clause isn't candidate for = adjusting OpenACC privatization level: not addressable} "" { target = *-*-* } l_loop$c_loop } > ! { dg-note {variable 'y' in 'private' clause is candidate for = adjusting OpenACC privatization level} "" { target *-*-* } l_loop$c_loop = } > ! { dg-note {variable 'C\.[0-9]+' declared in block potentially = has improper OpenACC privatization level: 'const_decl'} "TODO" { target = *-*-* } l_loop$c_loop } > - ! { dg-note {variable 'D\.[0-9]+' declared in block isn't = candidate for adjusting OpenACC privatization level: not addressable} "" = { target *-*-* } l_loop$c_loop } > ! { dg-note {variable 'y' ought to be adjusted for OpenACC = privatization level: 'vector'} "" { target *-*-* } l_loop$c_loop } > !$acc end parallel > end subroutine f > diff --git = a/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute.f90 = b/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute.f90 > index 31f998dfc92..4813e44a233 100644 > --- a/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute.f90 > +++ b/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute.f90 > @@ -43,6 +43,5 @@ contains > ! { dg-note {variable 'j' in 'private' clause potentially has = improper OpenACC privatization level: 'parm_decl'} "TODO3" { xfail *-*-* = } l_compute$c_compute } > ! { dg-note {variable 'a' in 'private' clause potentially has = improper OpenACC privatization level: 'parm_decl'} "TODO4" { xfail *-*-* = } l_compute$c_compute } > ! { dg-note {variable 'C\.[0-9]+' declared in block potentially = has improper OpenACC privatization level: 'const_decl'} "TODO" { target = *-*-* } l_compute$c_compute } > - ! { dg-note {variable 'D\.[0-9]+' declared in block isn't = candidate for adjusting OpenACC privatization level: not addressable} "" = { target *-*-* } l_compute$c_compute } > end subroutine f > end module m > diff --git = a/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang-loop.f90 = b/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang-loop.f90 > index db6d8226ed0..36f2a886e47 100644 > --- = a/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang-loop.f90 > +++ = b/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang-loop.f90 > @@ -50,7 +50,6 @@ contains > ! { dg-note {variable 'x' in 'private' clause isn't candidate for = adjusting OpenACC privatization level: not addressable} "" { target = *-*-* } l_loop$c_loop } > ! { dg-note {variable 'y' in 'private' clause is candidate for = adjusting OpenACC privatization level} "" { target *-*-* } l_loop$c_loop = } > ! { dg-note {variable 'C\.[0-9]+' declared in block potentially = has improper OpenACC privatization level: 'const_decl'} "TODO" { target = *-*-* } l_loop$c_loop } > - ! { dg-note {variable 'D\.[0-9]+' declared in block isn't = candidate for adjusting OpenACC privatization level: not addressable} "" = { target *-*-* } l_loop$c_loop } > ! { dg-note {variable 'y' ought to be adjusted for OpenACC = privatization level: 'vector'} "" { target *-*-* } l_loop$c_loop } > end subroutine f > end module m > diff --git = a/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang.f90 = b/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang.f90 > index 725bd5e2ebe..0615a445e44 100644 > --- a/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang.f90 > +++ b/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang.f90 > @@ -43,5 +43,4 @@ contains > ! { dg-note {variable 'j' in 'private' clause potentially has = improper OpenACC privatization level: 'parm_decl'} "TODO" { xfail *-*-* = } l_routine$c_routine } > ! { dg-note {variable 'a' in 'private' clause potentially has = improper OpenACC privatization level: 'parm_decl'} "TODO" { xfail *-*-* = } l_routine$c_routine } > ! { dg-note {variable 'C\.[0-9]+' declared in block potentially = has improper OpenACC privatization level: 'const_decl'} "TODO" { xfail = *-*-* } l_routine$c_routine } > - ! { dg-note {variable 'D\.[0-9]+' declared in block isn't = candidate for adjusting OpenACC privatization level: not addressable} = "TODO" { xfail *-*-* } l_routine$c_routine } > end module m >