From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by sourceware.org (Postfix) with ESMTPS id EE2A93858C2C for ; Tue, 21 Dec 2021 14:21:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EE2A93858C2C Received: by mail-lj1-x22b.google.com with SMTP id v15so21759499ljc.0 for ; Tue, 21 Dec 2021 06:21:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=K1wRIfk74JdfwMzoTqmJyneFJaw/HyXBGc4lkOF8LEM=; b=ZSaaX64tX3Rm4BP8OYsf5j0vBOMTVkFMAJmDlkOCzTlb4B3V3XWdLZNE0vDvS9fwqE zUoH/J8iFo4G/7Lh9ey3ag95RdMdjHD9etgMbhqK1ZyjVP5NUUNmt+0lXQvQa7atoheH 8/UDkgyy2rgL/PFTO3v+gAN9+ZXxBqLyjgrxPcgIyHgtOcuL8+PyTi54dzfs4hKlR6fY 1GOr/WakO+/r26xOQzzLzsoJRWQx8LA5+vob7MGUExOgI9WUP0WzHpNwd7W0ouPX1iJR yqgbHSrO/ZqFAFKDwvFY7DVCJTIBCAQRaiaDW+tzdGQ16c6CQVkDqN1MRseRKrLW6zkV FZ+A== X-Gm-Message-State: AOAM53301pgJVnh1hPaUpBlsXfnW/nHd3BqOZBjac48nElw0/UUL06vO SAJwdJULGichQUA0/O/iODn0 X-Google-Smtp-Source: ABdhPJzr30lg12b8RyN+PuTMWGP7BWqxasjSDSIc9JlsuyPvhWccvHit1zDknv7Iw2pzqfsQHPebBg== X-Received: by 2002:a2e:801a:: with SMTP id j26mr535833ljg.468.1640096473778; Tue, 21 Dec 2021 06:21:13 -0800 (PST) Received: from [192.168.0.135] ([185.30.228.158]) by smtp.gmail.com with ESMTPSA id e17sm2725261lfr.296.2021.12.21.06.21.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Dec 2021 06:21:13 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: [TCWG CI] Regression caused by gcc: Fortran: fix checking of elemental functions of type CLASS From: Maxim Kuvyrkov In-Reply-To: <1207918258.6080.1639928184262@jenkins.jenkins> Date: Tue, 21 Dec 2021 17:21:12 +0300 Cc: gcc-regression@gcc.gnu.org Content-Transfer-Encoding: quoted-printable Message-Id: <7E337A2B-FBA5-49AC-A499-F73ED8744F17@linaro.org> References: <1207918258.6080.1639928184262@jenkins.jenkins> To: Harald Anlauf X-Mailer: Apple Mail (2.3608.120.23.2.7) X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_LOTSOFHASH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-regression@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-regression mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Dec 2021 14:21:16 -0000 Hi Harald, This was sent out due to a bug in our CI. Sorry for the noise. Regards, -- Maxim Kuvyrkov https://www.linaro.org > On 19 Dec 2021, at 18:36, ci_notify@linaro.org wrote: >=20 > [TCWG CI] Regression caused by gcc: Fortran: fix checking of elemental = functions of type CLASS: > commit ce80f2c0e7a86e555201e9e61a26306adff4a074 > Author: Harald Anlauf >=20 > Fortran: fix checking of elemental functions of type CLASS >=20 > Results regressed to > # reset_artifacts: > -10 > # build_abe binutils: > -9 > # build_abe stage1 -- --set = gcc_override_configure=3D--disable-libsanitizer --set = gcc_override_configure=3D--disable-multilib --set = gcc_override_configure=3D--with-cpu=3Dcortex-m4 --set = gcc_override_configure=3D--with-mode=3Dthumb --set = gcc_override_configure=3D--with-float=3Dhard: > -8 > # build_abe newlib: > -6 > # build_abe stage2 -- --set = gcc_override_configure=3D--disable-libsanitizer --set = gcc_override_configure=3D--disable-multilib --set = gcc_override_configure=3D--with-cpu=3Dcortex-m4 --set = gcc_override_configure=3D--with-mode=3Dthumb --set = gcc_override_configure=3D--with-float=3Dhard: > -5 > # benchmark -- -O3_mthumb = artifacts/build-ce80f2c0e7a86e555201e9e61a26306adff4a074/results_id: > 1 >=20 > from > # reset_artifacts: > -10 > # build_abe binutils: > -9 > # build_abe stage1 -- --set = gcc_override_configure=3D--disable-libsanitizer --set = gcc_override_configure=3D--disable-multilib --set = gcc_override_configure=3D--with-cpu=3Dcortex-m4 --set = gcc_override_configure=3D--with-mode=3Dthumb --set = gcc_override_configure=3D--with-float=3Dhard: > -8 > # build_abe newlib: > -6 > # build_abe stage2 -- --set = gcc_override_configure=3D--disable-libsanitizer --set = gcc_override_configure=3D--disable-multilib --set = gcc_override_configure=3D--with-cpu=3Dcortex-m4 --set = gcc_override_configure=3D--with-mode=3Dthumb --set = gcc_override_configure=3D--with-float=3Dhard: > -5 > # benchmark -- -O3_mthumb artifacts/build-baseline/results_id: > 1 >=20 > THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, = REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT. >=20 > This commit has regressed these CI configurations: > - tcwg_bmk_gnu_eabi_stm32/gnu_eabi-release-arm_eabi-coremark-O3 >=20 > First_bad build: = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-release-arm_eabi-coremark-O3/1/artifact/artifacts/build-ce80f2c0e7a86e= 555201e9e61a26306adff4a074/ > Last_good build: = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-release-arm_eabi-coremark-O3/1/artifact/artifacts/build-a316bd50f82d04= 613fa224de7883260c6720896d/ > Baseline build: = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-release-arm_eabi-coremark-O3/1/artifact/artifacts/build-baseline/ > Even more details: = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-release-arm_eabi-coremark-O3/1/artifact/artifacts/ >=20 > Reproduce builds: > > mkdir investigate-gcc-ce80f2c0e7a86e555201e9e61a26306adff4a074 > cd investigate-gcc-ce80f2c0e7a86e555201e9e61a26306adff4a074 >=20 > # Fetch scripts > git clone https://git.linaro.org/toolchain/jenkins-scripts >=20 > # Fetch manifests and test.sh script > mkdir -p artifacts/manifests > curl -o artifacts/manifests/build-baseline.sh = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-release-arm_eabi-coremark-O3/1/artifact/artifacts/manifests/build-base= line.sh --fail > curl -o artifacts/manifests/build-parameters.sh = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-release-arm_eabi-coremark-O3/1/artifact/artifacts/manifests/build-para= meters.sh --fail > curl -o artifacts/test.sh = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-release-arm_eabi-coremark-O3/1/artifact/artifacts/test.sh --fail > chmod +x artifacts/test.sh >=20 > # Reproduce the baseline build (build all pre-requisites) > ./jenkins-scripts/tcwg_bmk-build.sh @@ = artifacts/manifests/build-baseline.sh >=20 > # Save baseline build state (which is then restored in = artifacts/test.sh) > mkdir -p ./bisect > rsync -a --del --delete-excluded --exclude /bisect/ --exclude = /artifacts/ --exclude /gcc/ ./ ./bisect/baseline/ >=20 > cd gcc >=20 > # Reproduce first_bad build > git checkout --detach ce80f2c0e7a86e555201e9e61a26306adff4a074 > ../artifacts/test.sh >=20 > # Reproduce last_good build > git checkout --detach a316bd50f82d04613fa224de7883260c6720896d > ../artifacts/test.sh >=20 > cd .. > >=20 > Full commit (up to 1000 lines): > > commit ce80f2c0e7a86e555201e9e61a26306adff4a074 > Author: Harald Anlauf > Date: Fri Dec 10 22:41:24 2021 +0100 >=20 > Fortran: fix checking of elemental functions of type CLASS >=20 > gcc/fortran/ChangeLog: >=20 > PR fortran/103606 > * resolve.c (resolve_fl_procedure): Do not access CLASS = components > before class container has been built. >=20 > gcc/testsuite/ChangeLog: >=20 > PR fortran/103606 > * gfortran.dg/pr103606.f90: New test. >=20 > (cherry picked from commit = 7e913caad081ea85da4f257265f2d3383cdbe8d5) > --- > gcc/fortran/resolve.c | 3 ++- > gcc/testsuite/gfortran.dg/pr103606.f90 | 12 ++++++++++++ > 2 files changed, 14 insertions(+), 1 deletion(-) >=20 > diff --git a/gcc/fortran/resolve.c b/gcc/fortran/resolve.c > index bf7902742e2..1367d58a963 100644 > --- a/gcc/fortran/resolve.c > +++ b/gcc/fortran/resolve.c > @@ -13237,7 +13237,8 @@ resolve_fl_procedure (gfc_symbol *sym, int = mp_flag) >=20 > /* An elemental function is required to return a scalar 12.7.1 */ > if (sym->attr.elemental && sym->attr.function > - && (sym->as || (sym->ts.type =3D=3D BT_CLASS && CLASS_DATA = (sym)->as))) > + && (sym->as || (sym->ts.type =3D=3D BT_CLASS && = sym->attr.class_ok > + && CLASS_DATA (sym)->as))) > { > gfc_error ("ELEMENTAL function %qs at %L must have a scalar " > "result", sym->name, &sym->declared_at); > diff --git a/gcc/testsuite/gfortran.dg/pr103606.f90 = b/gcc/testsuite/gfortran.dg/pr103606.f90 > new file mode 100644 > index 00000000000..43283184e89 > --- /dev/null > +++ b/gcc/testsuite/gfortran.dg/pr103606.f90 > @@ -0,0 +1,12 @@ > +! { dg-do compile } > +! PR fortran/103606 - ICE in resolve_fl_procedure > +! Contributed by G.Steinmetz > + > +program p > + type t > + end type > +contains > + elemental function f() result(z) ! { dg-error "CLASS variable" } > + class(t) :: z > + end > +end >