From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 4A82F3858C2C for ; Tue, 21 Dec 2021 15:19:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4A82F3858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: UF6cWd8w/rQAwaq9BHShXuU+nr3G6j8+ewXXciItSiYKKsvzzUzEfftRzdlVmZAXNAFGOPXXjQ ENZAy9onBcFZiZEeTwWcetng9CxWCyVGRIJE6s5bgUEmC5wyuF4XWOcGyRdt3cJDz6HYDDNKHb YQ8f7LX/kGgDQab+KdlukpCv5m6g0ON1LGrjbMw51VH9mwwDgA6y5XuWLOyl6zONkHqXig2j40 bHumjl27g6K28gikZD8h2PdYSONTfFy3MByZX+8x+4n1qjArEOYD05Z4l9wgckanyJeaWmek4d TCVG7uNCrtk1FzwF5RUuAoEc X-IronPort-AV: E=Sophos;i="5.88,223,1635235200"; d="scan'208";a="72483468" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 21 Dec 2021 07:19:07 -0800 IronPort-SDR: IZCzZvFgYRAbm0KkDxlR7TAUiQtL6msuf9bWXiU0/xj9GxTvXQIn7v/1CKBxwcnpiqOjCZsPeW qwiEUk4Ro61Kuau2WnZnWGozN3AHjkJr5tLpGMCi+mCzljiV3d26+lmqOPOFRpfVUaGSAxL2lg exCtDAyBG4dsX7clybEow5TojT7pAgZHt5+M2BK3H3Adjj7FtD4P/+MbDUsWweKg4+vF+35FPS R/TZgKONcGA1h43BTZlx3YOXI7gDTlyIa5MqmEuEmZEuzLZvebWmtABMjiRyIFxJCjZGifa4ds cCw= From: Thomas Schwinge To: Maxim Kuvyrkov CC: Subject: Re: [TCWG CI] Regression caused by gcc: Adjust 'gfortran.dg/goacc/privatization-1-*' [PR103576, PR103697] In-Reply-To: <7CAD58A5-888D-4A05-9E69-D9DC77541A73@linaro.org> References: <2049980274.5596.1639790175925@jenkins.jenkins> <7CAD58A5-888D-4A05-9E69-D9DC77541A73@linaro.org> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/27.1 (x86_64-pc-linux-gnu) Date: Tue, 21 Dec 2021 16:18:58 +0100 Message-ID: <874k72x9y5.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_LOTSOFHASH, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-regression@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-regression mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Dec 2021 15:19:09 -0000 Hi Maxim! On 2021-12-21T17:37:53+0300, Maxim Kuvyrkov wro= te: > This was sent out due to a bug in our CI. Sorry for the noise. ;-) No worries, thanks for confirming what I suspected. Gr=C3=BC=C3=9Fe Thomas >> On 18 Dec 2021, at 04:16, ci_notify@linaro.org wrote: >> >> [TCWG CI] Regression caused by gcc: Adjust 'gfortran.dg/goacc/privatizat= ion-1-*' [PR103576, PR103697]: >> commit 228d64af4e244faabab5c47506920a1bde85d74e >> Author: Thomas Schwinge >> >> Adjust 'gfortran.dg/goacc/privatization-1-*' [PR103576, PR103697] >> >> Results regressed to >> # reset_artifacts: >> -10 >> # build_abe binutils: >> -9 >> # build_abe stage1 -- --set gcc_override_configure=3D--disable-libsaniti= zer --set gcc_override_configure=3D--disable-multilib --set gcc_override_co= nfigure=3D--with-cpu=3Dcortex-m4 --set gcc_override_configure=3D--with-mode= =3Dthumb --set gcc_override_configure=3D--with-float=3Dhard: >> -8 >> # build_abe newlib: >> -6 >> # build_abe stage2 -- --set gcc_override_configure=3D--disable-libsaniti= zer --set gcc_override_configure=3D--disable-multilib --set gcc_override_co= nfigure=3D--with-cpu=3Dcortex-m4 --set gcc_override_configure=3D--with-mode= =3Dthumb --set gcc_override_configure=3D--with-float=3Dhard: >> -5 >> # benchmark -- -O3_LTO_mthumb artifacts/build-228d64af4e244faabab5c47506= 920a1bde85d74e/results_id: >> 1 >> >> from >> # reset_artifacts: >> -10 >> # build_abe binutils: >> -9 >> # build_abe stage1 -- --set gcc_override_configure=3D--disable-libsaniti= zer --set gcc_override_configure=3D--disable-multilib --set gcc_override_co= nfigure=3D--with-cpu=3Dcortex-m4 --set gcc_override_configure=3D--with-mode= =3Dthumb --set gcc_override_configure=3D--with-float=3Dhard: >> -8 >> # build_abe newlib: >> -6 >> # build_abe stage2 -- --set gcc_override_configure=3D--disable-libsaniti= zer --set gcc_override_configure=3D--disable-multilib --set gcc_override_co= nfigure=3D--with-cpu=3Dcortex-m4 --set gcc_override_configure=3D--with-mode= =3Dthumb --set gcc_override_configure=3D--with-float=3Dhard: >> -5 >> # benchmark -- -O3_LTO_mthumb artifacts/build-baseline/results_id: >> 1 >> >> THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, REPROD= UCTION INSTRUCTIONS, AND THE RAW COMMIT. >> >> This commit has regressed these CI configurations: >> - tcwg_bmk_gnu_eabi_stm32/gnu_eabi-master-arm_eabi-coremark-O3_LTO >> >> First_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-t= cwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifact= s/build-228d64af4e244faabab5c47506920a1bde85d74e/ >> Last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-t= cwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifact= s/build-7f1239cb43fad3293cf5bcd3678d1cba128d04c6/ >> Baseline build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tc= wg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts= /build-baseline/ >> Even more details: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect= -tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifa= cts/ >> >> Reproduce builds: >> >> mkdir investigate-gcc-228d64af4e244faabab5c47506920a1bde85d74e >> cd investigate-gcc-228d64af4e244faabab5c47506920a1bde85d74e >> >> # Fetch scripts >> git clone https://git.linaro.org/toolchain/jenkins-scripts >> >> # Fetch manifests and test.sh script >> mkdir -p artifacts/manifests >> curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/= tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremar= k-O3_LTO/13/artifact/artifacts/manifests/build-baseline.sh --fail >> curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/jo= b/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-corem= ark-O3_LTO/13/artifact/artifacts/manifests/build-parameters.sh --fail >> curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi= -bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/13/artifact= /artifacts/test.sh --fail >> chmod +x artifacts/test.sh >> >> # Reproduce the baseline build (build all pre-requisites) >> ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baselin= e.sh >> >> # Save baseline build state (which is then restored in artifacts/test.sh= ) >> mkdir -p ./bisect >> rsync -a --del --delete-excluded --exclude /bisect/ --exclude /artifacts= / --exclude /gcc/ ./ ./bisect/baseline/ >> >> cd gcc >> >> # Reproduce first_bad build >> git checkout --detach 228d64af4e244faabab5c47506920a1bde85d74e >> ../artifacts/test.sh >> >> # Reproduce last_good build >> git checkout --detach 7f1239cb43fad3293cf5bcd3678d1cba128d04c6 >> ../artifacts/test.sh >> >> cd .. >> >> >> Full commit (up to 1000 lines): >> >> commit 228d64af4e244faabab5c47506920a1bde85d74e >> Author: Thomas Schwinge >> Date: Tue Dec 14 07:03:52 2021 +0100 >> >> Adjust 'gfortran.dg/goacc/privatization-1-*' [PR103576, PR103697] >> >> ... for the recent commit 494ebfa7c9aacaeb6ec1fccc47a0e49f31eb2bb8 >> "Fortran: Handle compare in OpenMP atomic", which changes the GIMPLE = IR >> such that a temporary is no longer used; 'original' dump: >> >> x =3D *a; >> - { >> - integer(kind=3D4) D.4237; >> - >> - D.4237 =3D *a; >> #pragma omp atomic relaxed >> - &y =3D D.4237; >> - } >> + &y =3D *a; >> } >> >> (I'm not familiar to comment whether that's correct; but it appears t= hat the >> difference again disappears in later compiler passes.) >> >> These OpenACC test cases verify behavior re OpenACC privatization lev= els, and >> have to be adjusted accordingly. >> >> gcc/testsuite/ >> PR fortran/103576 >> PR testsuite/103697 >> * gfortran.dg/goacc/privatization-1-compute-loop.f90: Adjust. >> * gfortran.dg/goacc/privatization-1-compute.f90: Likewise. >> * gfortran.dg/goacc/privatization-1-routine_gang-loop.f90: >> Likewise. >> * gfortran.dg/goacc/privatization-1-routine_gang.f90: Likewis= e. >> --- >> gcc/testsuite/gfortran.dg/goacc/privatization-1-compute-loop.f90 | = 1 - >> gcc/testsuite/gfortran.dg/goacc/privatization-1-compute.f90 | = 1 - >> gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang-loop.f90 | = 1 - >> gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang.f90 | = 1 - >> 4 files changed, 4 deletions(-) >> >> diff --git a/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute-loo= p.f90 b/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute-loop.f90 >> index bcd7159ae5b..47ba5baf439 100644 >> --- a/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute-loop.f90 >> +++ b/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute-loop.f90 >> @@ -50,7 +50,6 @@ contains >> ! { dg-note {variable 'x' in 'private' clause isn't candidate for ad= justing OpenACC privatization level: not addressable} "" { target *-*-* } l= _loop$c_loop } >> ! { dg-note {variable 'y' in 'private' clause is candidate for adjus= ting OpenACC privatization level} "" { target *-*-* } l_loop$c_loop } >> ! { dg-note {variable 'C\.[0-9]+' declared in block potentially has = improper OpenACC privatization level: 'const_decl'} "TODO" { target *-*-* }= l_loop$c_loop } >> - ! { dg-note {variable 'D\.[0-9]+' declared in block isn't candidate= for adjusting OpenACC privatization level: not addressable} "" { target *-= *-* } l_loop$c_loop } >> ! { dg-note {variable 'y' ought to be adjusted for OpenACC privatiza= tion level: 'vector'} "" { target *-*-* } l_loop$c_loop } >> !$acc end parallel >> end subroutine f >> diff --git a/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute.f90= b/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute.f90 >> index 31f998dfc92..4813e44a233 100644 >> --- a/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute.f90 >> +++ b/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute.f90 >> @@ -43,6 +43,5 @@ contains >> ! { dg-note {variable 'j' in 'private' clause potentially has improp= er OpenACC privatization level: 'parm_decl'} "TODO3" { xfail *-*-* } l_comp= ute$c_compute } >> ! { dg-note {variable 'a' in 'private' clause potentially has improp= er OpenACC privatization level: 'parm_decl'} "TODO4" { xfail *-*-* } l_comp= ute$c_compute } >> ! { dg-note {variable 'C\.[0-9]+' declared in block potentially has = improper OpenACC privatization level: 'const_decl'} "TODO" { target *-*-* }= l_compute$c_compute } >> - ! { dg-note {variable 'D\.[0-9]+' declared in block isn't candidate= for adjusting OpenACC privatization level: not addressable} "" { target *-= *-* } l_compute$c_compute } >> end subroutine f >> end module m >> diff --git a/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gan= g-loop.f90 b/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang-l= oop.f90 >> index db6d8226ed0..36f2a886e47 100644 >> --- a/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang-loop.= f90 >> +++ b/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang-loop.= f90 >> @@ -50,7 +50,6 @@ contains >> ! { dg-note {variable 'x' in 'private' clause isn't candidate for ad= justing OpenACC privatization level: not addressable} "" { target *-*-* } l= _loop$c_loop } >> ! { dg-note {variable 'y' in 'private' clause is candidate for adjus= ting OpenACC privatization level} "" { target *-*-* } l_loop$c_loop } >> ! { dg-note {variable 'C\.[0-9]+' declared in block potentially has = improper OpenACC privatization level: 'const_decl'} "TODO" { target *-*-* }= l_loop$c_loop } >> - ! { dg-note {variable 'D\.[0-9]+' declared in block isn't candidate= for adjusting OpenACC privatization level: not addressable} "" { target *-= *-* } l_loop$c_loop } >> ! { dg-note {variable 'y' ought to be adjusted for OpenACC privatiza= tion level: 'vector'} "" { target *-*-* } l_loop$c_loop } >> end subroutine f >> end module m >> diff --git a/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gan= g.f90 b/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang.f90 >> index 725bd5e2ebe..0615a445e44 100644 >> --- a/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang.f90 >> +++ b/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang.f90 >> @@ -43,5 +43,4 @@ contains >> ! { dg-note {variable 'j' in 'private' clause potentially has improp= er OpenACC privatization level: 'parm_decl'} "TODO" { xfail *-*-* } l_routi= ne$c_routine } >> ! { dg-note {variable 'a' in 'private' clause potentially has improp= er OpenACC privatization level: 'parm_decl'} "TODO" { xfail *-*-* } l_routi= ne$c_routine } >> ! { dg-note {variable 'C\.[0-9]+' declared in block potentially has = improper OpenACC privatization level: 'const_decl'} "TODO" { xfail *-*-* } = l_routine$c_routine } >> - ! { dg-note {variable 'D\.[0-9]+' declared in block isn't candidate= for adjusting OpenACC privatization level: not addressable} "TODO" { xfail= *-*-* } l_routine$c_routine } >> end module m >> ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955