From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by sourceware.org (Postfix) with ESMTPS id BDF51385800B for ; Tue, 21 Dec 2021 14:38:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BDF51385800B Received: by mail-lf1-x129.google.com with SMTP id bp20so14153233lfb.6 for ; Tue, 21 Dec 2021 06:38:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=NVx8ww/Qio8gE4t070jcBzObwB6qIKQDwNMF7YrNx88=; b=KLrY0FZtDv4SnvOApDWPbUI5TNOmyTmAPmmwMZDLt8bZ59QzW44fmzBIkq0RU8BDTa e8SEEHdULjujwOlGauKyY5dRqRwcCWsKtf/BChvwAvstUPLoybWF9JzSSIgg2JtrPXFl sUamxlzrs2IVfNKsXBFzXJw60ZFclNX2LdPWRWM+BZ6fdeIgbE9vr5BiOak7zCnHy2I5 6K59U/dsiov6Y9nPvolB0urFF9LALxRUsxJIz+2lXP1cLPXHmLgsptXvsfAV8Xg/EV9A iLY2oQstK86BYz6636UTQqzO04n+mVj/e5fMq+hqZzRuoaJg7TFv0kxOnK0MQHDx18pi G9Sw== X-Gm-Message-State: AOAM533JO150X7ezaWB/4qgvDW5sn16vABgmpFlqHEbX35k5hvw3e1eY uzotWpwK5evE2iQxzGmGyJBe X-Google-Smtp-Source: ABdhPJwKJLBmtvbdFD3C21FX1oBmRbf41KXlkw9AaLIWEy41yJ5/d6Pmgt1bB38PGREyN5uFIja7Yw== X-Received: by 2002:ac2:511b:: with SMTP id q27mr3391423lfb.69.1640097503425; Tue, 21 Dec 2021 06:38:23 -0800 (PST) Received: from [192.168.0.135] ([185.30.228.158]) by smtp.gmail.com with ESMTPSA id cf18sm1855776lfb.251.2021.12.21.06.38.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Dec 2021 06:38:22 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: [TCWG CI] Regression caused by gcc: Preserve cpu specific CRTSTUFF_T_CFLAGS on powerpc-vxworks7 From: Maxim Kuvyrkov In-Reply-To: <1359594183.5519.1639771235957@jenkins.jenkins> Date: Tue, 21 Dec 2021 17:38:22 +0300 Cc: gcc-regression@gcc.gnu.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <1359594183.5519.1639771235957@jenkins.jenkins> To: Olivier Hainque X-Mailer: Apple Mail (2.3608.120.23.2.7) X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_LOTSOFHASH, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-regression@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-regression mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Dec 2021 14:38:26 -0000 Hi Olivier, This was sent out due to a bug in our CI. Sorry for the noise. Regards, -- Maxim Kuvyrkov https://www.linaro.org > On 17 Dec 2021, at 23:00, ci_notify@linaro.org wrote: >=20 > [TCWG CI] Regression caused by gcc: Preserve cpu specific = CRTSTUFF_T_CFLAGS on powerpc-vxworks7: > commit 0ecb48d753005405f84876ed3032c4cda789e072 > Author: Olivier Hainque >=20 > Preserve cpu specific CRTSTUFF_T_CFLAGS on powerpc-vxworks7 >=20 > Results regressed to > # reset_artifacts: > -10 > # build_abe binutils: > -9 > # build_abe stage1 -- --set = gcc_override_configure=3D--disable-libsanitizer --set = gcc_override_configure=3D--disable-multilib --set = gcc_override_configure=3D--with-cpu=3Dcortex-m4 --set = gcc_override_configure=3D--with-mode=3Dthumb --set = gcc_override_configure=3D--with-float=3Dhard: > -8 > # build_abe newlib: > -6 > # build_abe stage2 -- --set = gcc_override_configure=3D--disable-libsanitizer --set = gcc_override_configure=3D--disable-multilib --set = gcc_override_configure=3D--with-cpu=3Dcortex-m4 --set = gcc_override_configure=3D--with-mode=3Dthumb --set = gcc_override_configure=3D--with-float=3Dhard: > -5 > # benchmark -- -Os_LTO_mthumb = artifacts/build-0ecb48d753005405f84876ed3032c4cda789e072/results_id: > 1 >=20 > from > # reset_artifacts: > -10 > # build_abe binutils: > -9 > # build_abe stage1 -- --set = gcc_override_configure=3D--disable-libsanitizer --set = gcc_override_configure=3D--disable-multilib --set = gcc_override_configure=3D--with-cpu=3Dcortex-m4 --set = gcc_override_configure=3D--with-mode=3Dthumb --set = gcc_override_configure=3D--with-float=3Dhard: > -8 > # build_abe newlib: > -6 > # build_abe stage2 -- --set = gcc_override_configure=3D--disable-libsanitizer --set = gcc_override_configure=3D--disable-multilib --set = gcc_override_configure=3D--with-cpu=3Dcortex-m4 --set = gcc_override_configure=3D--with-mode=3Dthumb --set = gcc_override_configure=3D--with-float=3Dhard: > -5 > # benchmark -- -Os_LTO_mthumb artifacts/build-baseline/results_id: > 1 >=20 > THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, = REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT. >=20 > This commit has regressed these CI configurations: > - tcwg_bmk_gnu_eabi_stm32/gnu_eabi-master-arm_eabi-coremark-Os_LTO >=20 > First_bad build: = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-Os_LTO/12/artifact/artifacts/build-0ecb48d753= 005405f84876ed3032c4cda789e072/ > Last_good build: = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-Os_LTO/12/artifact/artifacts/build-16c848090f= 237c2398930b8c0ef75acebf4fa44d/ > Baseline build: = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-Os_LTO/12/artifact/artifacts/build-baseline/ > Even more details: = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-Os_LTO/12/artifact/artifacts/ >=20 > Reproduce builds: > > mkdir investigate-gcc-0ecb48d753005405f84876ed3032c4cda789e072 > cd investigate-gcc-0ecb48d753005405f84876ed3032c4cda789e072 >=20 > # Fetch scripts > git clone https://git.linaro.org/toolchain/jenkins-scripts >=20 > # Fetch manifests and test.sh script > mkdir -p artifacts/manifests > curl -o artifacts/manifests/build-baseline.sh = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-Os_LTO/12/artifact/artifacts/manifests/build-= baseline.sh --fail > curl -o artifacts/manifests/build-parameters.sh = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-Os_LTO/12/artifact/artifacts/manifests/build-= parameters.sh --fail > curl -o artifacts/test.sh = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-Os_LTO/12/artifact/artifacts/test.sh --fail > chmod +x artifacts/test.sh >=20 > # Reproduce the baseline build (build all pre-requisites) > ./jenkins-scripts/tcwg_bmk-build.sh @@ = artifacts/manifests/build-baseline.sh >=20 > # Save baseline build state (which is then restored in = artifacts/test.sh) > mkdir -p ./bisect > rsync -a --del --delete-excluded --exclude /bisect/ --exclude = /artifacts/ --exclude /gcc/ ./ ./bisect/baseline/ >=20 > cd gcc >=20 > # Reproduce first_bad build > git checkout --detach 0ecb48d753005405f84876ed3032c4cda789e072 > ../artifacts/test.sh >=20 > # Reproduce last_good build > git checkout --detach 16c848090f237c2398930b8c0ef75acebf4fa44d > ../artifacts/test.sh >=20 > cd .. > >=20 > Full commit (up to 1000 lines): > > commit 0ecb48d753005405f84876ed3032c4cda789e072 > Author: Olivier Hainque > Date: Tue Dec 7 13:26:30 2021 +0000 >=20 > Preserve cpu specific CRTSTUFF_T_CFLAGS on powerpc-vxworks7 >=20 > The unconditional assignment performed in t-vxworks to handle > include flags currently overrides what specific cpu ports had > for the regular (!vxworks) crtstuff objects. >=20 > This was not done on purpose and the proposed change adjusts the > configuration bits to apply the vxworks specific flags on top of > the cpu ones instead. >=20 > 2021-12-07 Olivier Hainque >=20 > * config.host (powerpc*-wrs-vxworks7*): Place t-crtstuff > ahead of the other files in tmake_files. > * config/t-vxworks: Add to CRTSTUFF_T_CFLAGS instead of > overriding it. > --- > libgcc/config.host | 3 ++- > libgcc/config/t-vxworks | 4 +++- > 2 files changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/libgcc/config.host b/libgcc/config.host > index 1c1b60cac0b..a94f4bf41db 100644 > --- a/libgcc/config.host > +++ b/libgcc/config.host > @@ -1235,7 +1235,8 @@ powerpc*-*-linux*) > md_unwind_header=3Drs6000/linux-unwind.h > ;; > powerpc*-wrs-vxworks7*) > - tmake_file=3D"$tmake_file rs6000/t-vxworks = rs6000/t-savresfgpr rs6000/t-crtstuff rs6000/t-linux t-dfprules = rs6000/t-ppc64-fp t-slibgcc-libgcc" > + tmake_file=3D"$tmake_file rs6000/t-vxworks = rs6000/t-savresfgpr rs6000/t-linux t-dfprules rs6000/t-ppc64-fp = t-slibgcc-libgcc" > + tmake_file=3D"rs6000/t-crtstuff ${tmake_file}" > case $ppc_fp_type in > 64) > ;; > diff --git a/libgcc/config/t-vxworks b/libgcc/config/t-vxworks > index aa794744976..18a0b1ee469 100644 > --- a/libgcc/config/t-vxworks > +++ b/libgcc/config/t-vxworks > @@ -17,4 +17,6 @@ LIBGCC2_INCLUDES =3D -nostdinc -I. \ > -I$(VSB_DIR)/h -I$(VSB_DIR)/share/h -I=3D/system -I=3D/public, \ > -I=3D/ -I=3D/wrn/coreip) >=20 > -CRTSTUFF_T_CFLAGS =3D $(LIBGCC2_INCLUDES) > +# Use these also for the vxcrstuff objects (.e.g for version.h), on = top of > +# the options possibly already set specifically for the target: > +CRTSTUFF_T_CFLAGS +=3D $(LIBGCC2_INCLUDES) >