From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D343B3858D28 for ; Mon, 24 Apr 2023 16:30:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D343B3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682353829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bZCoorFHfQx/fjZJAfAB1HNuMtTnXQ4MYSWTURiXjzs=; b=NXITebekjJJ0KTWoPG4bnCx+tvzHo47fy1nYjzvkKGwawYGhA4pTDI9A6I9x0fwpYwEHHn l9nTmPizkEovhP0/+FochpsSOI0G22YkRamf+jSgDv+cGhkwYPd6DHNjrWCCcdx22Mclgj C3dxvglO7WhtaLo074W8YATyKraywyE= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-563-r-YKO2VLMrC11-6uGRzd4w-1; Mon, 24 Apr 2023 12:30:26 -0400 X-MC-Unique: r-YKO2VLMrC11-6uGRzd4w-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-4eff7227f49so121923e87.2 for ; Mon, 24 Apr 2023 09:30:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682353824; x=1684945824; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bZCoorFHfQx/fjZJAfAB1HNuMtTnXQ4MYSWTURiXjzs=; b=SwdM3Owza1TVs/0KsvwzFW72J84YlIgFUCTDe6wSc7soom7CfcHCmlr2WLvVLeEyFe vSlHGW8GeED/5IXEt+Jp7n3SFYgYXDgFK2F2ULMaaM/D6FvRnNdkcynjgT49N1lvfsDM FfrJ43d/jx4mMxdrBOEWan6SglzlupvAnAvqDVY098KilrlxQ+cxpsKYbX4mDvLGDjmu fqDR4J6nIwVHvvmUfSoF4+baY/iK4BLQWEbyPIMdfOTMvgSSBJYsx44HuEJBPtKyWcHX mFl56u/WWyKPn5EPT89AayHG4wmp+qPQ8fPhtCK0M/znv+0XquF7QUUBpCEjs3AMJhz9 i6TQ== X-Gm-Message-State: AAQBX9e5AXXwpYlpkCu24KgP/7Q1Ke0Xfo1WlCcMIfilqRTGVfAZ9vzF q7t4FwYbZVq3nzQudXmewod+uMJpBj6j3/LHwuyUN0Ztkw4g4aJkGC5dqYjnbr7Wq0YGGftV1m7 opkCevRNXo0yvRoq7CRywD6AIGu05lZA4C7LYFA== X-Received: by 2002:ac2:50c1:0:b0:4ee:da89:61e2 with SMTP id h1-20020ac250c1000000b004eeda8961e2mr3416803lfm.27.1682353824745; Mon, 24 Apr 2023 09:30:24 -0700 (PDT) X-Google-Smtp-Source: AKy350ZN0sZvn1284NfVG/IRUcQJ0BgSMzcmsOB8cpuG6eVeDYfywitH3C6l/nAlQCwFFaBRJVo8M0MBPP+wkNxJGLY= X-Received: by 2002:ac2:50c1:0:b0:4ee:da89:61e2 with SMTP id h1-20020ac250c1000000b004eeda8961e2mr3416798lfm.27.1682353824452; Mon, 24 Apr 2023 09:30:24 -0700 (PDT) MIME-Version: 1.0 References: <202304220330.33M3UOTu3169661@shliclel4214.sh.intel.com> <0afbbbd8-3f8a-dc82-832c-8dd315dc6916@idea> In-Reply-To: <0afbbbd8-3f8a-dc82-832c-8dd315dc6916@idea> From: Jonathan Wakely Date: Mon, 24 Apr 2023 17:30:13 +0100 Message-ID: Subject: Re: [r14-159 Regression] FAIL: std/ranges/iota/max_size_type.cc execution test on Linux/x86_64 To: Patrick Palka Cc: Jakub Jelinek , "haochen.jiang" , "jason@redhat.com" , "gcc-regression@gcc.gnu.org" , "gcc-patches@gcc.gnu.org" , "haochen.jiang@intel.com" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 24 Apr 2023 at 17:27, Patrick Palka wrote: > > On Sun, 23 Apr 2023, Jonathan Wakely wrote: > > > > > > > On Saturday, April 22, 2023, Jakub Jelinek wrote: > > > On Sat, Apr 22, 2023 at 11:30:24AM +0800, haochen.jiang via Gcc-patches wrote: > > >> On Linux/x86_64, > > >> > > >> 03cebd304955a6b9c5607e09312d77f1307cc98e is the first bad commit > > >> commit 03cebd304955a6b9c5607e09312d77f1307cc98e > > >> Author: Jason Merrill > > >> Date: Tue Apr 18 21:32:07 2023 -0400 > > >> > > >> c++: fix 'unsigned typedef-name' extension [PR108099] > > >> > > >> caused > > >> > > >> FAIL: std/ranges/iota/max_size_type.cc execution test > > > > > > That is mentioned in > > > https://gcc.gnu.org/pipermail/gcc-patches/2023-April/616439.html > > > as known problem. I think the test should use std::make_signed > > > instead of signed rep_t > > IIUC we can't portably use make_signed here since __int128 is considered > an integral type only in GNU mode and not in strict mode. Right (for now ... C++23 means we can make it an integer type, and I think we might as well apply that to all -std modes, but that work isn't done yet). > > > > > It's already testing non-public implementation details, it could just use #if and use signed __int128 or signed long long as appropriate. > > Sounds good, patch posted at https://gcc.gnu.org/pipermail/gcc-patches/2023-April/616598.html