From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by sourceware.org (Postfix) with ESMTPS id B5CE33858418 for ; Thu, 23 Dec 2021 11:21:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B5CE33858418 Received: by mail-lj1-x22c.google.com with SMTP id i63so8546224lji.3 for ; Thu, 23 Dec 2021 03:21:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=/yslfZvz6fSugXxfM2tpSTScE4G/hncav9gHoi05vUw=; b=ceiegFQlZ58gaivrnWTDKylWMtd1AwqYjS+5kGlon3fjBM4EmcgOAS5I+76Ff986wX EAljzzXPPFUG6BpuD1DSZ1N/KParKKBpSF9X7nAb2rRYImpvEzPgVeqiDCoLYJ1DuSwb PYGlEJinaR6+GD+pFk1xkpe06qNIhg9A+wMLhh9AoZRmzZCi49ZRRHaQA7k+JOx8gJV9 0A0q+dLZ3zf5sI795GEM5WQIOBsTyhNSbLWVVdOGAklBPBqjklT+6vUC6GvtmvukbfQi lb8CoA3CbocT1rDnfJuNmIm74uIcryAA0oDOAY+eG0QILpqwb7aY1Kill9dcoi3KMuv2 jN/Q== X-Gm-Message-State: AOAM532xQqK1Sd8S+Pw7zIvfPgv4DyZGfwHbjKFS2mI90IjnR1bxw8N3 d9Nb4T/puc4FxZ7x4PW7oAVy X-Google-Smtp-Source: ABdhPJycCarU3SYM39wDc6fOoN7UM2RGEXIqLVOU+6Ljl7BxRtrfC9HhOvrgTCSlSBgdYUHkDF3Q2Q== X-Received: by 2002:a2e:b8cf:: with SMTP id s15mr1360520ljp.297.1640258515343; Thu, 23 Dec 2021 03:21:55 -0800 (PST) Received: from [192.168.0.135] ([185.30.228.158]) by smtp.gmail.com with ESMTPSA id bp31sm474154lfb.129.2021.12.23.03.21.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Dec 2021 03:21:54 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\)) Subject: Re: [TCWG CI] Regression caused by binutils: gdb: Powerpc mark xfail in gdb.base/catch-syscall.exp From: Maxim Kuvyrkov In-Reply-To: <25103f22a93cbc1c3b6e40cd9ba919a3dbdfb3e3.camel@us.ibm.com> Date: Thu, 23 Dec 2021 14:21:54 +0300 Cc: gcc-regression@gcc.gnu.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <485385377.5313.1639722152898@jenkins.jenkins> <25103f22a93cbc1c3b6e40cd9ba919a3dbdfb3e3.camel@us.ibm.com> To: Carl Love X-Mailer: Apple Mail (2.3608.120.23.2.7) X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_LOTSOFHASH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-regression@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-regression mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Dec 2021 11:21:59 -0000 Hi Carl, This was a purely CI issue, nothing to do with your patch. Regards, -- Maxim Kuvyrkov https://www.linaro.org > On 22 Dec 2021, at 19:14, Carl Love wrote: >=20 > Maxim: >=20 > Thanks for the email. I just wanted to double check with you if there > is something that needs to be done. I have only had a chance to = quickly > look at the original email. It sounds like my patch is OK, just an > issue with the CI. Note, I am traveling and only checking email > occasionally. Thanks for your help with this. >=20 > Carl=20 >=20 > On Tue, 2021-12-21 at 17:39 +0300, Maxim Kuvyrkov wrote: >> Hi Carl, >>=20 >> This was sent out due to a bug in our CI. Sorry for the noise. >>=20 >> Regards, >>=20 >> -- >> Maxim Kuvyrkov >> https://www.linaro.org=20 >>=20 >>> On 17 Dec 2021, at 09:22, ci_notify@linaro.org wrote: >>>=20 >>> [TCWG CI] Regression caused by binutils: gdb: Powerpc mark xfail in >>> gdb.base/catch-syscall.exp: >>> commit 408db576c98b232de0b1a1ee3495bad0d1c704cf >>> Author: Carl Love >>>=20 >>> gdb: Powerpc mark xfail in gdb.base/catch-syscall.exp >>>=20 >>> Results regressed to >>> # reset_artifacts: >>> -10 >>> # build_abe binutils: >>> -9 >>> # build_abe stage1 -- --set gcc_override_configure=3D--disable- >>> libsanitizer --set gcc_override_configure=3D--disable-multilib --set >>> gcc_override_configure=3D--with-cpu=3Dcortex-m4 --set >>> gcc_override_configure=3D--with-mode=3Dthumb --set >>> gcc_override_configure=3D--with-float=3Dhard: >>> -8 >>> # build_abe newlib: >>> -6 >>> # build_abe stage2 -- --set gcc_override_configure=3D--disable- >>> libsanitizer --set gcc_override_configure=3D--disable-multilib --set >>> gcc_override_configure=3D--with-cpu=3Dcortex-m4 --set >>> gcc_override_configure=3D--with-mode=3Dthumb --set >>> gcc_override_configure=3D--with-float=3Dhard: >>> -5 >>> # benchmark -- -Os_LTO_mthumb artifacts/build- >>> 408db576c98b232de0b1a1ee3495bad0d1c704cf/results_id: >>> 1 >>>=20 >>> from >>> # reset_artifacts: >>> -10 >>> # build_abe binutils: >>> -9 >>> # build_abe stage1 -- --set gcc_override_configure=3D--disable- >>> libsanitizer --set gcc_override_configure=3D--disable-multilib --set >>> gcc_override_configure=3D--with-cpu=3Dcortex-m4 --set >>> gcc_override_configure=3D--with-mode=3Dthumb --set >>> gcc_override_configure=3D--with-float=3Dhard: >>> -8 >>> # build_abe newlib: >>> -6 >>> # build_abe stage2 -- --set gcc_override_configure=3D--disable- >>> libsanitizer --set gcc_override_configure=3D--disable-multilib --set >>> gcc_override_configure=3D--with-cpu=3Dcortex-m4 --set >>> gcc_override_configure=3D--with-mode=3Dthumb --set >>> gcc_override_configure=3D--with-float=3Dhard: >>> -5 >>> # benchmark -- -Os_LTO_mthumb artifacts/build-baseline/results_id: >>> 1 >>>=20 >>> THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, >>> REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT. >>>=20 >>> This commit has regressed these CI configurations: >>> - tcwg_bmk_gnu_eabi_stm32/gnu_eabi-master-arm_eabi-coremark-Os_LTO >>>=20 >>> First_bad build:=20 >>> = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-Os_LTO/10/artifact/artifacts/build-408db576c9= 8b232de0b1a1ee3495bad0d1c704cf/ >>>=20 >>> Last_good build:=20 >>> = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-Os_LTO/10/artifact/artifacts/build-e6582e1b3c= 194b01a2461f5c5326fcf358303607/ >>>=20 >>> Baseline build:=20 >>> = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-Os_LTO/10/artifact/artifacts/build-baseline/ >>>=20 >>> Even more details:=20 >>> = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-Os_LTO/10/artifact/artifacts/ >>>=20 >>>=20 >>> Reproduce builds: >>> >>> mkdir investigate-binutils-408db576c98b232de0b1a1ee3495bad0d1c704cf >>> cd investigate-binutils-408db576c98b232de0b1a1ee3495bad0d1c704cf >>>=20 >>> # Fetch scripts >>> git clone=20 >>> https://git.linaro.org/toolchain/jenkins-scripts >>>=20 >>>=20 >>> # Fetch manifests and test.sh script >>> mkdir -p artifacts/manifests >>> curl -o artifacts/manifests/build-baseline.sh=20 >>> = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-Os_LTO/10/artifact/artifacts/manifests/build-= baseline.sh >>> --fail >>> curl -o artifacts/manifests/build-parameters.sh=20 >>> = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-Os_LTO/10/artifact/artifacts/manifests/build-= parameters.sh >>> --fail >>> curl -o artifacts/test.sh=20 >>> = https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_e= abi-master-arm_eabi-coremark-Os_LTO/10/artifact/artifacts/test.sh >>> --fail >>> chmod +x artifacts/test.sh >>>=20 >>> # Reproduce the baseline build (build all pre-requisites) >>> ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build- >>> baseline.sh >>>=20 >>> # Save baseline build state (which is then restored in >>> artifacts/test.sh) >>> mkdir -p ./bisect >>> rsync -a --del --delete-excluded --exclude /bisect/ --exclude >>> /artifacts/ --exclude /binutils/ ./ ./bisect/baseline/ >>>=20 >>> cd binutils >>>=20 >>> # Reproduce first_bad build >>> git checkout --detach 408db576c98b232de0b1a1ee3495bad0d1c704cf >>> ../artifacts/test.sh >>>=20 >>> # Reproduce last_good build >>> git checkout --detach e6582e1b3c194b01a2461f5c5326fcf358303607 >>> ../artifacts/test.sh >>>=20 >>> cd .. >>> >>>=20 >>> Full commit (up to 1000 lines): >>> >>> commit 408db576c98b232de0b1a1ee3495bad0d1c704cf >>> Author: Carl Love >>> Date: Mon Nov 29 16:28:42 2021 +0000 >>>=20 >>> gdb: Powerpc mark xfail in gdb.base/catch-syscall.exp >>>=20 >>> Powerpc is not reporting the >>>=20 >>> Catchpoint 1 (returned from syscall execve), .... >>>=20 >>> as expected. The issue appears to be with the kernel not >>> returning the >>> expected result. This patch marks the test failure as an xfail. >>>=20 >>> Bug:=20 >>> https://sourceware.org/bugzilla/show_bug.cgi?id=3D28623 >>>=20 >>> --- >>> gdb/testsuite/gdb.base/catch-syscall.exp | 37 >>> ++++++++++++++++++++++++++------ >>> 1 file changed, 31 insertions(+), 6 deletions(-) >>>=20 >>> diff --git a/gdb/testsuite/gdb.base/catch-syscall.exp >>> b/gdb/testsuite/gdb.base/catch-syscall.exp >>> index cdd5e2aec47..b0d524c1a03 100644 >>> --- a/gdb/testsuite/gdb.base/catch-syscall.exp >>> +++ b/gdb/testsuite/gdb.base/catch-syscall.exp >>> @@ -127,7 +127,28 @@ proc check_return_from_syscall { syscall { >>> pattern "" } } { >>> } >>>=20 >>> set thistest "syscall $syscall has returned" >>> - gdb_test "continue" "Catchpoint $decimal \\(returned from >>> syscall ${pattern}\\).*" $thistest >>> + if { $pattern eq "execve" } { >>> + gdb_test_multiple "continue" $thistest { >>> + -re -wrap "Catchpoint $decimal \\(returned from syscall >>> ${pattern}\\).*" { >>> + pass $thistest >>> + return 1 >>> + } >>> + -re -wrap ".*Breakpoint $decimal, main .*" { >>> + # On Powerpc the kernel does not report the returned >>> from >>> + # syscall as expected by the test. GDB bugzilla 28623. >>> + if { [istarget "powerpc64*-linux*"] } { >>> + xfail $thistest >>> + } else { >>> + fail $thistest >>> + } >>> + return 0 >>> + } >>> + } >>> + >>> + } else { >>> + gdb_test "continue" "Catchpoint $decimal \\(returned from >>> syscall ${pattern}\\).*" $thistest >>> + return 1 >>> + } >>> } >>>=20 >>> # Internal procedure that performs two 'continue' commands and >>> checks if >>> @@ -142,7 +163,7 @@ proc check_continue { syscall { pattern "" } } >>> { >>> # Testing if the inferior has called the syscall. >>> check_call_to_syscall $syscall $pattern >>> # And now, that the syscall has returned. >>> - check_return_from_syscall $syscall $pattern >>> + return [check_return_from_syscall $syscall $pattern] >>> } >>>=20 >>> # Inserts a syscall catchpoint with an argument. >>> @@ -348,11 +369,15 @@ proc test_catch_syscall_execve {} { >>> # Check for entry/return across the execve, making sure that >>> the >>> # syscall_state isn't lost when turning into a new process. >>> insert_catch_syscall_with_arg "execve" >>> - check_continue "execve" >>> + if [check_continue "execve"] { >>> + # The check_continue test generates an XFAIL on >>> Powerpc. In >>> + # that case, gdb is already at main so don't do the >>> continue. >>> + >>>=20 >>> - # Continue to main so extended-remote can read files as needed. >>> - # (Otherwise that "Reading" output confuses >>> gdb_continue_to_end.) >>> - gdb_continue "main" >>> + # Continue to main so extended-remote can read files as >>> needed. >>> + # (Otherwise that "Reading" output confuses >>> gdb_continue_to_end.) >>> + gdb_continue "main" >>> + } >>>=20 >>> # Now can we finish? >>> check_for_program_end >>> >=20