From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 46ACA385842F for ; Thu, 3 Nov 2022 16:50:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 46ACA385842F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667494215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sCemHewo0di10kwbV9vzTLuDq3/8eIZyKoV7sn0gIiU=; b=ZDo0zTdZHS2Wi4Y53Pwna8D55Un7zs3yY/RRrjxciQkB06riwLktlLpaGkHq8cSilAmk2i W02pfW5oEwdctBBWryfSSJ6BhlIHn99nokKfLuzb0wmO37Rane+xuvuvcjDmzaa/mmzvWB JzhLSFIfDkv7LdoSEfMd2p+2nQRZsW8= Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-638-HMCbm9LFPT6M9FdriO-5MQ-1; Thu, 03 Nov 2022 12:50:14 -0400 X-MC-Unique: HMCbm9LFPT6M9FdriO-5MQ-1 Received: by mail-io1-f69.google.com with SMTP id u11-20020a6b490b000000b006bbcc07d893so1394240iob.9 for ; Thu, 03 Nov 2022 09:50:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sCemHewo0di10kwbV9vzTLuDq3/8eIZyKoV7sn0gIiU=; b=KeyOLqZUUpqFhI/QbT9Tnsw4k1DPsdz3pVjOUDtsoUjX1mJJb/BPqfDnHKOy9T8HLn EG8a81OufCHK4w0HzSaI2Ij9SL/D7b0KiSWyCcDg8VSI0Tr1WzBFC5nHt1Pl6gxjeNJV vpulHGRKpTi48fm+36FFq32KYcH0B8MX3eGADxeO54qT/z72Dzo/dtv0OztGoE0WXwfy ZtY8ydyV7itEYXCnfCfxdRgb67qH//25VGXy9ZkCsgN92424MOnfjWtQcm2AFCNXA7+I WAabPZZDn6INoOQs487pzHHnrJVjCmZZklxNmkx2+YQ4/ivNmtXd2qjjoPqzeYpSk+62 0sAQ== X-Gm-Message-State: ACrzQf2rnW4EA1SMm1IbjyL/C5sIM5vtIVVMzRICNSCLud+jjV2QDszj Rj8AjNq8j2I8HVgK+rj1odT0i3rkCiYF4VM/2kgm+wmf/++VxYyz79nkSj1KMin61+J1HG2+83U V2hNqW3P+NBcm0aZmMt8iAQ== X-Received: by 2002:a92:6612:0:b0:300:d0b2:182d with SMTP id a18-20020a926612000000b00300d0b2182dmr4823798ilc.217.1667494213406; Thu, 03 Nov 2022 09:50:13 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7WF3zuiqt5mxYjuoE9RsDzSRw8qrgkXMYLjy/o0Cp61SJEg/ZKgkkkYM7116HY6jO1sbI/3Q== X-Received: by 2002:a92:6612:0:b0:300:d0b2:182d with SMTP id a18-20020a926612000000b00300d0b2182dmr4823785ilc.217.1667494213099; Thu, 03 Nov 2022 09:50:13 -0700 (PDT) Received: from ?IPV6:2607:fea8:a263:f600::72c3? ([2607:fea8:a263:f600::72c3]) by smtp.gmail.com with ESMTPSA id d11-20020a05663802ab00b0036fdc9ef995sm357745jaq.92.2022.11.03.09.50.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 09:50:12 -0700 (PDT) Message-ID: Date: Thu, 3 Nov 2022 12:50:11 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [TCWG CI] Failure after basepoints/gcc-13-3596-ge7310e24b1c: Make ranger vrp1 default. To: ci_notify@linaro.org Cc: gcc-regression@gcc.gnu.org References: <824519934.20242.1667338782766@jenkins.jenkins> From: Andrew MacLeod In-Reply-To: <824519934.20242.1667338782766@jenkins.jenkins> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_LOTSOFHASH,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This problem should be resolved with: commit 6fd485d15c1a2c427c39bcd45e03bed8cde689e6 Author: Andrew MacLeod Date:   Wed Nov 2 21:37:49 2022 -0400     Update range query cache when a statement is updated. On 11/1/22 17:39, ci_notify@linaro.org wrote: > Failure after basepoints/gcc-13-3596-ge7310e24b1c: Make ranger vrp1 default.: > > Results changed to > -10 > # true: > 0 > # build_abe binutils: > 1 > # build_abe gcc: > 2 > # build_abe linux: > 4 > # build_abe glibc: > # FAILED > # First few build errors in logs: > # 00:00:12 pthread_create.c:50:1: error: alias must point to a defined variable or function > # 00:02:24 /home/tcwg-buildslave/workspace/tcwg_gnu_2/glibc/csu/../csu/libc-tls.c:202: undefined reference to `_startup_fatal_not_constant' > # 00:02:24 collect2: error: ld returned 1 exit status > # 00:02:24 make[2]: *** [../Rules:293: /home/tcwg-buildslave/workspace/tcwg_gnu_2/abe/builds/armv8l-unknown-linux-gnueabihf/armv8l-unknown-linux-gnueabihf/glibc-glibc.git~master/support/test-run-command] Error 1 > # 00:02:24 make[1]: *** [Makefile:484: support/others] Error 2 > # 00:02:24 make: *** [Makefile:9: all] Error 2 > > from > -10 > # true: > 0 > # build_abe binutils: > 1 > # build_abe gcc: > 2 > # build_abe linux: > 4 > # build_abe glibc: > 5 > # build_abe gdb: > 6 > > THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT. > > For latest status see comments in https://linaro.atlassian.net/browse/GNU-692 . > Status of basepoints/gcc-13-3596-ge7310e24b1c commit for tcwg_gnu_native_build: > commit e7310e24b1c0ca67b1bb507c1330b2bf39e59e32 > Author: Andrew MacLeod > Date: Tue Oct 25 16:42:41 2022 -0400 > > Make ranger vrp1 default. > > Turn on ranger as the default vrp1 pass and adjust testcases. > > gcc/ > * params.opt (param_vrp1_mode): Make ranger default. > > gcc/testsuite/ > * gcc.dg/pr68217.c: Test [-INF, -INF][0, 0] instead of [-INF, 0]. > * gcc.dg/tree-ssa/vrp-unreachable.c: New. Test unreachable removal. > * master-arm > ** Failure after basepoints/gcc-13-3596-ge7310e24b1c: Make ranger vrp1 default.: > ** https://ci.linaro.org/job/tcwg_gnu_native_build-build-master-arm/505/ > > Bad build: https://ci.linaro.org/job/tcwg_gnu_native_build-build-master-arm/505/artifact/artifacts > Good build: https://ci.linaro.org/job/tcwg_gnu_native_build-build-master-arm/504/artifact/artifacts > > Reproduce current build: > > mkdir -p investigate-gcc-e7310e24b1c0ca67b1bb507c1330b2bf39e59e32 > cd investigate-gcc-e7310e24b1c0ca67b1bb507c1330b2bf39e59e32 > > # Fetch scripts > git clone https://git.linaro.org/toolchain/jenkins-scripts > > # Fetch manifests for bad and good builds > mkdir -p bad/artifacts good/artifacts > curl -o bad/artifacts/manifest.sh https://ci.linaro.org/job/tcwg_gnu_native_build-build-master-arm/505/artifact/artifacts/manifest.sh --fail > curl -o good/artifacts/manifest.sh https://ci.linaro.org/job/tcwg_gnu_native_build-build-master-arm/504/artifact/artifacts/manifest.sh --fail > > # Reproduce bad build > (cd bad; ../jenkins-scripts/tcwg_gnu-build.sh ^^ true %%rr[top_artifacts] artifacts) > # Reproduce good build > (cd good; ../jenkins-scripts/tcwg_gnu-build.sh ^^ true %%rr[top_artifacts] artifacts) > > > Full commit (up to 1000 lines): > > commit e7310e24b1c0ca67b1bb507c1330b2bf39e59e32 > Author: Andrew MacLeod > Date: Tue Oct 25 16:42:41 2022 -0400 > > Make ranger vrp1 default. > > Turn on ranger as the default vrp1 pass and adjust testcases. > > gcc/ > * params.opt (param_vrp1_mode): Make ranger default. > > gcc/testsuite/ > * gcc.dg/pr68217.c: Test [-INF, -INF][0, 0] instead of [-INF, 0]. > * gcc.dg/tree-ssa/vrp-unreachable.c: New. Test unreachable removal. > --- > gcc/params.opt | 2 +- > gcc/testsuite/gcc.dg/pr68217.c | 2 +- > gcc/testsuite/gcc.dg/tree-ssa/vrp-unreachable.c | 42 +++++++++++++++++++++++++ > 3 files changed, 44 insertions(+), 2 deletions(-) > > diff --git a/gcc/params.opt b/gcc/params.opt > index 3001566e641..a34fee193fc 100644 > --- a/gcc/params.opt > +++ b/gcc/params.opt > @@ -1166,7 +1166,7 @@ Common Joined UInteger Var(param_vect_induction_float) Init(1) IntegerRage(0, 1) > Enable loop vectorization of floating point inductions. > > -param=vrp1-mode= > -Common Joined Var(param_vrp1_mode) Enum(vrp_mode) Init(VRP_MODE_VRP) Param Optimization > +Common Joined Var(param_vrp1_mode) Enum(vrp_mode) Init(VRP_MODE_RANGER) Param Optimization > --param=vrp1-mode=[vrp|ranger] Specifies the mode VRP1 should operate in. > > -param=vrp2-mode= > diff --git a/gcc/testsuite/gcc.dg/pr68217.c b/gcc/testsuite/gcc.dg/pr68217.c > index eb4f15e048f..60c80106760 100644 > --- a/gcc/testsuite/gcc.dg/pr68217.c > +++ b/gcc/testsuite/gcc.dg/pr68217.c > @@ -10,4 +10,4 @@ int foo (void) > return 0; > } > > -/* { dg-final { scan-tree-dump "\\\[-INF, 0\\\]" "vrp1" } } */ > +/* { dg-final { scan-tree-dump "\\\[-INF, -INF\\\]\\\[0, 0\\\]" "vrp1" } } */ > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/vrp-unreachable.c b/gcc/testsuite/gcc.dg/tree-ssa/vrp-unreachable.c > new file mode 100644 > index 00000000000..cdc57403c6e > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/tree-ssa/vrp-unreachable.c > @@ -0,0 +1,42 @@ > +/* { dg-do compile } */ > +/* { dg-options "-O2 -fdump-tree-vrp1-alias -fdump-tree-vrp2-alias" } */ > + > +void dead (unsigned n); > +void alive (unsigned n); > + > +void func (unsigned n, unsigned m) > +{ > + if (n == 0) > + __builtin_unreachable(); > + if (n == 1) > + __builtin_unreachable(); > + if (n & 0x1) > + __builtin_unreachable(); > + if (n == 2) > + __builtin_unreachable(); > + if (n == 3) > + __builtin_unreachable(); > + if (n & 0x2) > + __builtin_unreachable(); > + if (n == 4) > + __builtin_unreachable(); > + if (n == 5) > + __builtin_unreachable(); > + if (n & 0x4) > + __builtin_unreachable(); > + if (n == 6) > + __builtin_unreachable(); > + if (n == 7) > + __builtin_unreachable(); > + if (n <8) > + dead (n); > + if (n != m) > + __builtin_unreachable(); > + alive (n); > + alive (m); > +} > + > +/* { dg-final { scan-tree-dump-not "dead" "vrp1" } } */ > +/* { dg-final { scan-tree-dump-times "builtin_unreachable" 1 "vrp1" } } */ > +/* { dg-final { scan-tree-dump-not "builtin_unreachable" "vrp2" } } */ > +/* { dg-final { scan-tree-dump-times "fff8" 4 "vrp2" } } */ >