From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id 9A6733858018 for ; Sun, 8 Aug 2021 11:49:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9A6733858018 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wr1-x42c.google.com with SMTP id h14so17428225wrx.10 for ; Sun, 08 Aug 2021 04:49:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to; bh=EnWFFMLibV3yJJoTrtXcmRdfZGBeNVpNWTljKbkZSJ4=; b=L04vENtHppUOf4GwI4Sffygy2r/J0vx0on2vX2HZOFG0MvzfJl2iG+wC2IKnEA3etW /qbdRHTa45xD4B82Ez7IM0K93C4z44QRBi4flSaluMWMnoRe4Ql5E77cPafcqyMc8g6d mycpCPHuExNT8KJdnogR3a4xVehMpFsHF3dOosbfPgcaV2sFlOzJ9/3TfjdYC2SacGvG 0tNN6/snl1Mg8mPMMptrsDhBz5eQLu8XAaIyYsSHP4jf86Atn62gWQ0RitQMmgEC1xv4 z3PmognNVjllAcDNgb6EQN2hnyAorQYfsKaOCPH8naCzYjWejbNb95W/q2cnOqp5q9Up ZjLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to; bh=EnWFFMLibV3yJJoTrtXcmRdfZGBeNVpNWTljKbkZSJ4=; b=CCA7fvskUFDd9dSfrOmkMKB9abKL/AyUph7GSi5TEYesmkzkUYe+XO0/usZHh/M0P6 /rhE6f+bI82Ug1B9ouJvlDk9ffmoxyzcqiJUsG79g33NuzhuHauIbMEqxKRpBTT0qcjQ xLd6WQ5NiPKOC8RHg+tTiu3gRHV4YoVkkRf2mFbY1cWBVVvUbKrIDKw3nOKkgpR+MLSy 0GjYv6PqcwYLJ5UM4Jk6/rsmxpUhJBjOAoR6mm9trC2Cd6XSPkyxxDobde1VQBjfeAHk plAGlrkN9O7InaE35kikzhVk5MG6YVuMVk5BiKHwc8lPGglhecs7najtNdhQI0S3gzkg wEzQ== X-Gm-Message-State: AOAM5305XYEVTVPBLynp3CiLPbZJmErH4eNKmcDyNO/fN6Y3BClrn/Tz qf4cCQE/cn77UzECmGSwTzOFyOuSRoDNgQ== X-Google-Smtp-Source: ABdhPJxOHeKY9RqLOGqsFxWiubh6Ver2bvZcGvBn+w7yLe9jGrxWV6dGkL+cU5IMxA+B4q3J7s8Hwg== X-Received: by 2002:adf:e507:: with SMTP id j7mr20346753wrm.113.1628423338488; Sun, 08 Aug 2021 04:48:58 -0700 (PDT) Received: from [192.168.0.40] ([86.14.124.218]) by smtp.gmail.com with ESMTPSA id n8sm15548414wrx.46.2021.08.08.04.48.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Aug 2021 04:48:57 -0700 (PDT) Subject: Re: [PATCH] More rustspec.cc cleanups To: Mark Wielaard Cc: gcc-rust@gcc.gnu.org References: <20210805233424.331178-1-mark@klomp.org> <9ebd75fa-b14a-b224-93a9-e8f4f0363672@embecosm.com> From: Philip Herron Message-ID: <0ec62186-56cb-336c-4d59-0d855addd782@embecosm.com> Date: Sun, 8 Aug 2021 12:48:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="syID6D0ExdrFbMhEQcfu4fpRgbnkxBtpD" X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-rust@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: gcc-rust mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Aug 2021 11:49:02 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --syID6D0ExdrFbMhEQcfu4fpRgbnkxBtpD Content-Type: multipart/mixed; boundary="R385qm1SxoNXcg3huCpY9N3v0C7f71Si0"; protected-headers="v1" From: Philip Herron To: Mark Wielaard Cc: gcc-rust@gcc.gnu.org Message-ID: <0ec62186-56cb-336c-4d59-0d855addd782@embecosm.com> Subject: Re: [PATCH] More rustspec.cc cleanups References: <20210805233424.331178-1-mark@klomp.org> <9ebd75fa-b14a-b224-93a9-e8f4f0363672@embecosm.com> In-Reply-To: --R385qm1SxoNXcg3huCpY9N3v0C7f71Si0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US On 07/08/2021 00:08, Mark Wielaard wrote: > Hi Philip, > > On Fri, Aug 06, 2021 at 03:58:24PM +0100, Philip Herron wrote: >> Great patch, this file has been neglected. This is now being merged >> https://github.com/Rust-GCC/gccrs/pull/610 >> >> Its not 100% clear but is the compiler driver here automatically addin= g >> in -lc or is it simply checking if it saw_libc? > It does pass -lc (if not saw_libc). You can see what is invoked with > which arguments using -v (e.g. gcc/gccrs -B gcc -v foobar.rs). > > One of the things we are using is the crt1.o startup code, which > provides the _start symbol and which relies on libc (in particular > __libc_start_main and abort). > > The patch wasn't really meant to change how we currently do > assembling, linking and startup. But just to remove those parts that > were unnecessary because they were go specific. > > Cheers, > > Mark > Awesome thanks for checking. Agreed that this patch was not meant to change that behavior but it was a great start at cleaning up the driver. I am now wondering if rustc reuses the same type of startup code. I'll go ask more questions about it :) Thanks --Phil=C2=A0 --R385qm1SxoNXcg3huCpY9N3v0C7f71Si0-- --syID6D0ExdrFbMhEQcfu4fpRgbnkxBtpD Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsD5BAABCAAjFiEET83ATZOayqRjyL0Cr7gxHEFOdpkFAmEPxKgFAwAAAAAACgkQr7gxHEFOdplC AQv+M7EpxUePwgaLKKPOh0LoepMt7uE/5/bmBewSbHwK7NI0XZf3GwfD1m2NZFGhuR8darUlooZ8 6FuvLWcL0NmqsydPWuncszyhh6biJeLTL963MEEgom31TWIAg9eWAnXfuaQogFnEEWnfOtjEOeYH hxooYmbGezouXFMkHFjKF0aLLJ81ajmLcYiHMIZ7EmKJccl9qac8Cq25ZQZ06CYGcYyUufss9jyP 8erQHVNgC9x2HjWx/7uoXgtOA5JrFIgFFebVnxV+coOqHuTpo5pTseLp6GmkRfoJVwKcA3PS+lyj dGcICdJZQ8oqQa6f6PpQRGJyX8BDMg2JMiFceP5WZbudSwmlcVb6k8TM014NG+RQ9Ssd8nHhM2Xc 6ZF7FHFU37yQ+6mPBz+jTNry9lBtl9tOgnYpAW4238SKwx4I1VbbTHltpvTZsaHEkoIatBCudCWE zVNMb1OSAmn2zfr7nQpvPrpfKjg3SirwuMxavDYjwNAIXI3aDM6hyA171PLd =AOut -----END PGP SIGNATURE----- --syID6D0ExdrFbMhEQcfu4fpRgbnkxBtpD--