From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 9F21E3850624; Fri, 9 Dec 2022 13:24:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9F21E3850624 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 635F433813; Fri, 9 Dec 2022 13:24:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1670592259; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FlNYnHDvFZ8PXkx1Cm9u05Qz5gJSBNVX9lCMfYlDVyk=; b=cFJyuAyiEIKsJURHzg5ySd2EDBoL9NOr4jWTcSihSZQgNE9Hgf0Z0qBAjH/w4w9F+L+wk6 2uXtGUXJ5rSxxul4OUjbNvdd+qpDEIAIzi82sf6P2MgbvkqkfLTohsHcpDyUAxF1k+05Jh PxsIPe0pSP9izM30VZut+omi095lBj4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1670592259; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FlNYnHDvFZ8PXkx1Cm9u05Qz5gJSBNVX9lCMfYlDVyk=; b=H9zuZiDYkGzrwI5E9fkHk+/kH+lxo+U1n9PHoTAV0Uxlfcfat19WzjxSF04mTGHBhCNp9Y Ed/BVxAPKsGXm5Dg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3712E13597; Fri, 9 Dec 2022 13:24:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6CFRCwM3k2PNawAAMHmgww (envelope-from ); Fri, 09 Dec 2022 13:24:19 +0000 Message-ID: <1281c3e2-842e-2882-c109-63a6adb4796a@suse.cz> Date: Fri, 9 Dec 2022 14:24:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: Rust front-end patches v4 To: arthur.cohen@embecosm.com, gcc-patches@gcc.gnu.org Cc: gcc-rust@gcc.gnu.org References: <20221206101417.778807-1-arthur.cohen@embecosm.com> Content-Language: en-US From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: <20221206101417.778807-1-arthur.cohen@embecosm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/6/22 11:13, arthur.cohen@embecosm.com wrote: > Similarly to the previous round of patches, this patchset does not contain any > new features - only fixes for the reviews of the v3. New features will follow > shortly once that first patchset is merged. > > Once again, thank you to all the contributors who made this possible and > especially to Philip Herron for his dedication to the project. Hello. Congratulations for the patch set approval! I noticed a minor git issues when I tried approving the patches: warning: quoted CRLF detected .git/rebase-apply/patch:3850: trailing whitespace. /* TODO: spec syntax rules state that "MacroInvocationSemi" can be used as .git/rebase-apply/patch:3851: trailing whitespace. * ExternalItem, but text body isn't so clear. Adding MacroInvocationSemi warning: 2 lines add whitespace errors. .git/rebase-apply/patch:3374: indent with spaces. \ .git/rebase-apply/patch:3427: indent with spaces. \ warning: 2 lines add whitespace errors. .git/rebase-apply/patch:315: indent with spaces. // rust precedences .git/rebase-apply/patch:316: indent with spaces. PREC_CLOSURE = -40, // used for closures .git/rebase-apply/patch:317: indent with spaces. PREC_JUMP = -30, // used for break, continue, return, and yield .git/rebase-apply/patch:318: indent with spaces. PREC_RANGE = -10, // used for range (although weird comment in rustc about this) .git/rebase-apply/patch:319: indent with spaces. PREC_BINOP = FROM_ASSOC_OP, warning: squelched 6 whitespace errors warning: 11 lines add whitespace errors. .git/rebase-apply/patch:21: trailing whitespace. ; .git/rebase-apply/patch:26: trailing whitespace. ; warning: 2 lines add whitespace errors. .git/rebase-apply/patch:22: trailing whitespace. * If you're unable to find an open issue addressing the problem, [open a new one](https://github.com/Rust-GCC/gccrs/issues/new). .git/rebase-apply/patch:23: trailing whitespace. Be sure to include a **title and clear description**, as much relevant information as possible, and a **code sample** .git/rebase-apply/patch:36: trailing whitespace. These will be imported into a GitHub PR to follow the normal review process, .git/rebase-apply/patch:43: trailing whitespace. * Do not open an issue on GitHub until you have collected positive feedback about the change. .git/rebase-apply/patch:61: trailing whitespace. * Where possible please add test cases to `gcc/testsuite/rust/` for all PRs. warning: squelched 15 whitespace errors warning: 20 lines add whitespace errors. Can you please take a look at that? Cheers, Martin