From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [IPv6:2001:67c:2050:0:465::201]) by sourceware.org (Postfix) with ESMTPS id D933E3858D20; Wed, 13 Sep 2023 20:13:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D933E3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=gdcproject.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gdcproject.org Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4RmBV729FNz9snD; Wed, 13 Sep 2023 22:13:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gdcproject.org; s=MBO0001; t=1694636015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KaZ80WxpmnI1O7yfY+ncJ1ZHAsL+qPu6/leHrtcw384=; b=tlHoqzWOz0ZuIYwxV/Mj6ONr39cnp/JCRpHCIHVmlMJuvlcRFZeEHl5n6mLLiFFyj0bosg SDvRAzyAtwYLywBgKhAZTR8+iU0ShobmKKKfcXuXReTErfV6IcQUko60FcSrz8Ugfj/v8B Eedf79uj0kIFMNfD1ueLZrD2mBc1hsSXiL4BpPwCkyZP0UXSTyxlFk3jnJxAuQ7ttuFJee lZKY6kkZoUj4Y3toDuJLQpDb8kJSEZPeMqBzvEcXefepMIfWHnlWvxN0UBS8NRAC27WE/S tIo+66yGRA8/LE8oN8yzdHhGVkKkByZ+qEYH6I9rdZEB4hNut05d8g8zrp5jXw== Date: Wed, 13 Sep 2023 22:13:31 +0200 From: Iain Buclaw Subject: Re: [PATCHSET] Reintroduce targetrustm hooks To: Arthur Cohen , gcc-patches@gcc.gnu.org Cc: "gcc-rust@gcc.gnu.org" References: <606cbf6f-1c99-9beb-1e98-809cb57df1c6@embecosm.com> In-Reply-To: <606cbf6f-1c99-9beb-1e98-809cb57df1c6@embecosm.com> MIME-Version: 1.0 Message-Id: <1694634574.b90urzerf1.astroid@pulse.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4RmBV729FNz9snD X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Excerpts from Arthur Cohen's message of September 7, 2023 3:41 pm: > Alright, was not expecting to mess up this patchset so bad so here we go: >=20 > This patchset reintroduces proper targetrustm hooks without the old > problematic mess of macros we had, which had been removed for the first > merge of gccrs upstream. >=20 > Tested on x86-64 GNU Linux, and has also been present in our development > repository for a long time - added by this pull-request from Iain [1] > which was merged in October 2022. >=20 > Ok for trunk? >=20 > [PATCH 01/14] rust: Add skeleton support and documentation for > [PATCH 02/14] rust: Reintroduce TARGET_RUST_CPU_INFO hook > [PATCH 03/14] rust: Reintroduce TARGET_RUST_OS_INFO hook > [PATCH 04/14] rust: Implement TARGET_RUST_CPU_INFO for i[34567]86-*-* > [PATCH 05/14] rust: Implement TARGET_RUST_OS_INFO for *-*-darwin* > [PATCH 06/14] rust: Implement TARGET_RUST_OS_INFO for *-*-freebsd* > [PATCH 07/14] rust: Implement TARGET_RUST_OS_INFO for *-*-netbsd* > [PATCH 08/14] rust: Implement TARGET_RUST_OS_INFO for *-*-openbsd* > [PATCH 09/14] rust: Implement TARGET_RUST_OS_INFO for *-*-solaris2*. > [PATCH 10/14] rust: Implement TARGET_RUST_OS_INFO for *-*-dragonfly* > [PATCH 11/14] rust: Implement TARGET_RUST_OS_INFO for *-*-vxworks* > [PATCH 12/14] rust: Implement TARGET_RUST_OS_INFO for *-*-fuchsia*. > [PATCH 13/14] rust: Implement TARGET_RUST_OS_INFO for > [PATCH 14/14] rust: Implement TARGET_RUST_OS_INFO for *-*-*linux*. >=20 Thanks for eventually getting round to this. As the co-author of this patch series, I'm not going to look at it. FWIW, these being Rust-specific target changes isolated to just Rust-specific files, you should have the automony to commit without needing any request for review - at least this is my understanding when have made D-specific target changes in the past that have not touched common back-end headers. I'll let someone else confirm and check over the shared parts touched by the patch however. For reviewers, this is pretty much a mirror of the D front-end's CPU and OS-specific target hooks (D has built-in version identifiers, not built-in attributes, but both Rust and D are otherwise the same in the kind of information exposed by them). > [1]: https://github.com/Rust-GCC/gccrs/pull/1543 >=20 The other GitHub pull request that added these is here. https://github.com/Rust-GCC/gccrs/pull/1596 Regards, Iain.