Re: [PATCH Rust front-end v3 35/46] gccrs: Add metadata ouptput pass

[Arthur Cohen <arthur.cohen@embecosm.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1352 bytes --]

On 10/26/22 23:04, David Malcolm wrote:
> %{On Wed, 2022-10-26 at 10:18 +0200, arthur.cohen@embecosm.com wrote:
>> From: Philip Herron <philip.herron@embecosm.com>
>>
>> Extern crates statements to tell the front-end to look for another
>> library.
>> The mechanism here is heavily inspired from gccgo, so when we compile
>> a
>> library for example we invoke:
>>
> 
> [...snip...]
> 
>> +      rust_error_at (Location (),
>> +                    "expected metadata-output path to have base file
>> name of: "
>> +                    "%<%s%> got %<%s%>",
>> +                    expected_file_name.c_str (), path_base_name);
> 
> I can't comment on the patch in depth, but does rust_error_at call into
> GCC's regular diagnostics?
> 
> If so, "%qs" is a more idiomatic way to express printing a string
> argument in quotes (and bold), rather than "%<%s%>", though IIRC they
> do the same thing (unless I'm missing something?).

I also believe that they do the same thing. We have some %<%s%> 
left-over from previous, more complex format strings, so good catch and 
thank you for noticing. I'll fix them up.

> This shows up in a few places in this patch, and might affect other
> patches in the kit - though it's a minor nitpick, of course.
> 
> Dave
> 

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3195 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]