From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 38A753857346; Mon, 18 Dec 2023 19:00:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 38A753857346 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 38A753857346 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.137.252 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702926038; cv=none; b=wWGr8EXV8EESgpHavk8HIYqNXVDHfFQ6XRfwlY1ZrR/2JSjh8b5l7pn2KWBvG998K7yVtHO8IoT3gJmesb+UMsvkXKRD6n0BSv+iN+t/ISGd/s5nbKtacrbeh+VQpU8WwS4JXPMQ8rLucZKiOiI4tsckTH7q8oLBi3tqCp4F4t4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702926038; c=relaxed/simple; bh=LUsNtGpwgQ0LbsRZ98dRT5mlzZCGmjBE3mdSCQiqKZY=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=jZ0oRTIOMJo0cDKhbQmmsko9VVj7l4Sh2JVB+yvkk/5ts0+k6CSb5RumfAFOfiP1SxjU0l3bRiORVyIIpN6HASCqb9s/cPITj02NO99DwLc/8R/Sd9IOLavaDXLsI3mqND+FwwwogA58lo6x/xtwTBz9D6GGMhxEsknnMEMpt1s= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: 4bibPK/ZSuWaQEp7snrqdw== X-CSE-MsgGUID: vnvKmytYTCqcXg2YJoNr9A== X-IronPort-AV: E=Sophos;i="6.04,286,1695715200"; d="scan'208";a="25660515" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 18 Dec 2023 11:00:33 -0800 IronPort-SDR: u76by+HlfLUyNBqpTGYlmgy+FcGz/KIQGFUBxzBox3wfZkXywXG82Vt8SSqcyAjLRzGeiOUpQn 0OK2UdHMBFCGvNSX2+RTiXagmd9d7d0HoZslx4NuM4Ss+TEyL7he3Pbbr3F49gbQf1ydLVbm21 nY/tLEqzhqAB0HB2hF9G0M9zdKi1aQZ7iL3ak0uoXPiFHkthurIj1DzOzUoBDXF/JP/OIPUgjf aXhiVeHK+q17g0dKTL0AGJXshmsBOiaCkqwFD2vLJkHOS//oNwFpARc2Ne0PWKsNnr0nJi7mw3 leM= Date: Mon, 18 Dec 2023 19:00:29 +0000 From: Joseph Myers To: Arthur Cohen CC: , , Raiki Tamura Subject: Re: [PATCH v3] libcpp: add function to check XID properties In-Reply-To: <20230908145908.915341-1-arthur.cohen@embecosm.com> Message-ID: <1f218960-1c67-31d1-5355-7d3c4f5639c6@codesourcery.com> References: <20230908145908.915341-1-arthur.cohen@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3102.7 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 8 Sep 2023, Arthur Cohen wrote: > + if (c < 0x80) > + { > + if (('A' <= c && c <= 'Z') || ('a' <= c && c <= 'z')) > + return CPP_XID_START | CPP_XID_CONTINUE; > + if (('0' <= c && c <= '9') || c == '_') > + return CPP_XID_CONTINUE; This may be an artifact of how the patch was mailed, but indentation seems off here (should be six spaces for both return statements). > + md = (mn + mx) / 2; > + if (c <= ucnranges[md].end) > + mx = md; > + else > + mn = md + 1; And likewise here (should be a tab for both assignments). OK with those indentation fixes. -- Joseph S. Myers joseph@codesourcery.com