From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 95E25385AC26 for ; Tue, 29 Jun 2021 22:11:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 95E25385AC26 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from reform (deer0x00.wildebeest.org [172.31.17.130]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 7AA3A3001553; Wed, 30 Jun 2021 00:11:48 +0200 (CEST) Received: by reform (Postfix, from userid 1000) id 0BDFA2E80F31; Wed, 30 Jun 2021 00:11:48 +0200 (CEST) From: Mark Wielaard To: gcc-rust@gcc.gnu.org Cc: Mark Wielaard Subject: [PATCH 1/2] Remove unused default_ty_param from TypeResolveGenericParam::visit Date: Wed, 30 Jun 2021 00:11:34 +0200 Message-Id: <20210629221135.309981-1-mark@klomp.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-rust@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: gcc-rust mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jun 2021 22:11:51 -0000 The default_ty_param was set, but not used. We do need to call TypeCheckType::Resolve on the default param, but don't need the result. --- gcc/rust/typecheck/rust-hir-type-check-type.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gcc/rust/typecheck/rust-hir-type-check-type.h b/gcc/rust/typecheck/rust-hir-type-check-type.h index b4baccf4299..6081ec549ce 100644 --- a/gcc/rust/typecheck/rust-hir-type-check-type.h +++ b/gcc/rust/typecheck/rust-hir-type-check-type.h @@ -255,11 +255,9 @@ public: void visit (HIR::TypeParam ¶m) override { - TyTy::BaseType *default_ty_param = nullptr; if (param.has_type ()) - { - default_ty_param = TypeCheckType::Resolve (param.get_type ().get ()); - } + TypeCheckType::Resolve (param.get_type ().get ()); + resolved = new TyTy::ParamType (param.get_type_representation (), param.get_mappings ().get_hirid (), param); } -- 2.32.0