From: Mark Wielaard <mark@klomp.org>
To: gcc-rust@gcc.gnu.org
Subject: shebang handling
Date: Mon, 5 Jul 2021 00:09:57 +0200 [thread overview]
Message-ID: <20210704220959.85580-1-mark@klomp.org> (raw)
Hi,
Shebang handling, the first line starting with #! was not done fully
correct and it isn't necessary to keep track of the shebang line in
the AST or HIR Crate classes.
Because an inner attribute also starts with #! the first line isn't
regarded as a shebang line if the #! is followed by (optional)
whitespace and comments and a [. In that case the #! is seen as the
start of an inner attribute.
I added various testcases that hopefully show the funny things you can
get when the first line starts with #!.
[PATCH 1/2] Handle shebang line, plus any whitespace and comment
[PATCH 2/2] Remove has_shebang flag from AST and HIR Crate classes
Patches can also be found here:
https://code.wildebeest.org/git/user/mjw/gccrs/log/?h=shebang
Cheers,
Mark
next reply other threads:[~2021-07-04 22:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-04 22:09 Mark Wielaard [this message]
2021-07-04 22:09 ` [PATCH 1/2] Handle shebang line, plus any whitespace and comment skipping in lexer Mark Wielaard
2021-07-04 22:09 ` [PATCH 2/2] Remove has_shebang flag from AST and HIR Crate classes Mark Wielaard
2021-07-05 5:46 ` shebang handling Marc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210704220959.85580-1-mark@klomp.org \
--to=mark@klomp.org \
--cc=gcc-rust@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).