From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 212E43858D3C for ; Wed, 1 Sep 2021 00:16:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 212E43858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from reform (deer0x1b.wildebeest.org [172.31.17.157]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 838B13000F0D for ; Wed, 1 Sep 2021 02:16:15 +0200 (CEST) Received: by reform (Postfix, from userid 1000) id 49CBA2E81023; Wed, 1 Sep 2021 02:16:15 +0200 (CEST) From: Mark Wielaard To: gcc-rust@gcc.gnu.org Subject: Cleanup some StructExpr related classes Date: Wed, 1 Sep 2021 02:15:39 +0200 Message-Id: <20210901001542.160965-1-mark@klomp.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-rust@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: gcc-rust mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Sep 2021 00:16:40 -0000 Hi, There are various Structure Expressions that don't actually "exist" because they are syntactically equivalent to other constructs. So we never really construct or use these classes. But they are still listed in various visitors, which is somewhat confusing. Removing the AST and HIR variants of these classes really cleans up the code IMHO. The following 3 patches can also be found on https://code.wildebeest.org/git/user/mjw/gccrs/log/?h=structexpr [PATCH 1/3] StructExprTuple doesn't really exist [PATCH 2/3] StructExprUnit doesn't really exist [PATCH 3/3] Remove Enumaration Expression, EnumExpr, classes Cheers, Mark