public inbox for gcc-rust@gcc.gnu.org
 help / color / mirror / Atom feed
From: Arthur Cohen <arthur.cohen@embecosm.com>
To: gcc-patches@gcc.gnu.org
Cc: gcc-rust@gcc.gnu.org, Arthur Cohen <arthur.cohen@embecosm.com>
Subject: [COMMITTED] gccrs: rustc_attrs: Allow `rustc_inherit_overflow_checks` as a builtin..
Date: Tue, 31 Jan 2023 14:24:24 +0100	[thread overview]
Message-ID: <20230131132424.661382-1-arthur.cohen@embecosm.com> (raw)

..attribute. We cannot yet handle this attribute, but we should not reject it either

gcc/rust/ChangeLog:

	* util/rust-attributes.cc: Add `rustc_inherit_overflow_checks` to list
	of builtin attributes.

gcc/testsuite/ChangeLog:

	* rust/compile/rustc_attr1.rs: New test.

Tested on x86_64-pc-linux-gnu, committed on master.

---
 gcc/rust/util/rust-attributes.cc          | 32 ++++++++++++-----------
 gcc/testsuite/rust/compile/rustc_attr1.rs | 13 +++++++++
 2 files changed, 30 insertions(+), 15 deletions(-)
 create mode 100644 gcc/testsuite/rust/compile/rustc_attr1.rs

diff --git a/gcc/rust/util/rust-attributes.cc b/gcc/rust/util/rust-attributes.cc
index 2cefdb247d1..9db77b40dfb 100644
--- a/gcc/rust/util/rust-attributes.cc
+++ b/gcc/rust/util/rust-attributes.cc
@@ -26,21 +26,23 @@ namespace Rust {
 namespace Analysis {
 
 // https://doc.rust-lang.org/stable/nightly-rustc/src/rustc_feature/builtin_attrs.rs.html#248
-static const BuiltinAttrDefinition __definitions[] = {
-  {"inline", CODE_GENERATION},
-  {"cold", CODE_GENERATION},
-  {"cfg", EXPANSION},
-  {"cfg_attr", EXPANSION},
-  {"deprecated", STATIC_ANALYSIS},
-  {"allow", STATIC_ANALYSIS},
-  {"doc", HIR_LOWERING},
-  {"must_use", STATIC_ANALYSIS},
-  {"lang", HIR_LOWERING},
-  {"link_section", CODE_GENERATION},
-  {"no_mangle", CODE_GENERATION},
-  {"repr", CODE_GENERATION},
-  {"path", EXPANSION},
-};
+static const BuiltinAttrDefinition __definitions[]
+  = {{"inline", CODE_GENERATION},
+     {"cold", CODE_GENERATION},
+     {"cfg", EXPANSION},
+     {"cfg_attr", EXPANSION},
+     {"deprecated", STATIC_ANALYSIS},
+     {"allow", STATIC_ANALYSIS},
+     {"doc", HIR_LOWERING},
+     {"must_use", STATIC_ANALYSIS},
+     {"lang", HIR_LOWERING},
+     {"link_section", CODE_GENERATION},
+     {"no_mangle", CODE_GENERATION},
+     {"repr", CODE_GENERATION},
+     {"path", EXPANSION},
+     // From now on, these are reserved by the compiler and gated through
+     // #![feature(rustc_attrs)]
+     {"rustc_inherit_overflow_checks", CODE_GENERATION}};
 
 BuiltinAttributeMappings *
 BuiltinAttributeMappings::get ()
diff --git a/gcc/testsuite/rust/compile/rustc_attr1.rs b/gcc/testsuite/rust/compile/rustc_attr1.rs
new file mode 100644
index 00000000000..4bc7d5e3553
--- /dev/null
+++ b/gcc/testsuite/rust/compile/rustc_attr1.rs
@@ -0,0 +1,13 @@
+// { dg-additional-options "-w" }
+
+#![feature(rustc_attrs)]
+
+pub struct NotI8(i8);
+
+impl NotI8 {
+    #[inline]
+    #[rustc_inherit_overflow_checks]
+    pub fn add(self, other: NotI8) -> NotI8 {
+        NotI8(self.0 + other.0)
+    }
+}
-- 
2.39.1


                 reply	other threads:[~2023-01-31 13:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230131132424.661382-1-arthur.cohen@embecosm.com \
    --to=arthur.cohen@embecosm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gcc-rust@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).