public inbox for
 help / color / mirror / Atom feed
From: Arthur Cohen <>
Cc:, Philip Herron <>
Subject: [COMMITTED] gccrs: Add guards against getting data from an empty vector
Date: Tue, 31 Jan 2023 14:25:15 +0100	[thread overview]
Message-ID: <> (raw)

From: Philip Herron <>


	* typecheck/ (TypeCheckContext::pop_return_type): Add
	guards around `std::vector<T>.pop_back()`.
	(TypeCheckContext::peek_context): Likewise for `std::vector<T>.back()`.

Tested on x86_64-pc-linux-gnu, committed on master.

 gcc/rust/typecheck/ | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gcc/rust/typecheck/ b/gcc/rust/typecheck/
index ad5f67cc1dd..af86b064c6c 100644
--- a/gcc/rust/typecheck/
+++ b/gcc/rust/typecheck/
@@ -142,12 +142,14 @@ TypeCheckContext::push_return_type (TypeCheckContextItem item,
 TypeCheckContext::pop_return_type ()
+  rust_assert (!return_type_stack.empty ());
   return_type_stack.pop_back ();
 TypeCheckContextItem &
 TypeCheckContext::peek_context ()
+  rust_assert (!return_type_stack.empty ());
   return return_type_stack.back ().first;

                 reply	other threads:[~2023-01-31 13:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).