public inbox for
 help / color / mirror / Atom feed
From: Arthur Cohen <>
Cc:, Philip Herron <>
Subject: [COMMITTED] gccrs: Remove param_use_canonical_types checks ported from c++ front-end
Date: Tue, 31 Jan 2023 14:25:30 +0100	[thread overview]
Message-ID: <> (raw)

From: Philip Herron <>

We are not fully setting TYPE_CANONICAL yet but we don't need to be as
strict as the C++ front-end yet. param_use_canonical_types is a command
line option we are not using either.


	* backend/ (comptypes): Remove some C++ specific checks in
	Rust const folder for now.

Tested on x86_64-pc-linux-gnu, committed on master.

 gcc/rust/backend/ | 22 +---------------------
 1 file changed, 1 insertion(+), 21 deletions(-)

diff --git a/gcc/rust/backend/ b/gcc/rust/backend/
index d79cd96f011..d2ddcfd2957 100644
--- a/gcc/rust/backend/
+++ b/gcc/rust/backend/
@@ -2916,27 +2916,7 @@ comptypes (tree t1, tree t2, int strict)
 	   perform a deep check. */
 	return structural_comptypes (t1, t2, strict);
-      if (flag_checking && param_use_canonical_types)
-	{
-	  bool result = structural_comptypes (t1, t2, strict);
-	  if (result && TYPE_CANONICAL (t1) != TYPE_CANONICAL (t2))
-	    /* The two types are structurally equivalent, but their
-	       canonical types were different. This is a failure of the
-	       canonical type propagation code.*/
-	    internal_error (
-	      "canonical types differ for identical types %qT and %qT", t1, t2);
-	  else if (!result && TYPE_CANONICAL (t1) == TYPE_CANONICAL (t2))
-	    /* Two types are structurally different, but the canonical
-	       types are the same. This means we were over-eager in
-	       assigning canonical types. */
-	    internal_error (
-	      "same canonical type node for different types %qT and %qT", t1,
-	      t2);
-	  return result;
-	}
-      if (!flag_checking && param_use_canonical_types)
+      if (!flag_checking)
 	return TYPE_CANONICAL (t1) == TYPE_CANONICAL (t2);
 	return structural_comptypes (t1, t2, strict);

                 reply	other threads:[~2023-01-31 13:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).